deduplicate rendered messages

elixir-lsp · Dec 21, 2023 · be46796 · be46796
1 parent f6fc44f
commit be46796
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/apps/language_server/lib/language_server/diagnostics.ex b/apps/language_server/lib/language_server/diagnostics.ex
@@ -346,6 +346,7 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
         }
       end
       |> Enum.sort_by(& &1["range"]["start"])
+      |> Enum.dedup()
 
     message = %{
       "uri" => uri,

diff --git a/apps/language_server/lib/language_server/server.ex b/apps/language_server/lib/language_server/server.ex
@@ -1626,9 +1626,9 @@ defmodule ElixirLS.LanguageServer.Server do
             # document open but was closed when build was triggered
             # document could have been edited
             # combine diagnostics
-            # they can be duplicated but it is not trivial to deduplicate
-            {parser_diagnostics_document_version,
-             Enum.uniq(parser_diagnostics ++ build_and_dialyzer_diagnostics)}
+            # they can be duplicated but it is not trivial to deduplicate here
+            # instead we deduplicate on publish with rendered messages
+            {parser_diagnostics_document_version, parser_diagnostics ++ build_and_dialyzer_diagnostics}
 
           true ->
             # document closed