fix crash on invalid diagnostic severity

elixir-lsp · Feb 27, 2024 · 586a935 · 586a935
1 parent a7151bf
commit 586a935
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/apps/language_server/lib/language_server/diagnostics.ex b/apps/language_server/lib/language_server/diagnostics.ex
@@ -4,6 +4,7 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
   from various sources
   """
   alias ElixirLS.LanguageServer.{SourceFile, JsonRpc}
+  require Logger
 
   @enforce_keys [:file, :severity, :message, :position, :compiler_name]
   defstruct [
@@ -314,10 +315,24 @@ defmodule ElixirLS.LanguageServer.Diagnostics do
       for %__MODULE__{} = diagnostic <- uri_diagnostics do
         severity =
           case diagnostic.severity do
-            :error -> 1
-            :warning -> 2
-            :information -> 3
-            :hint -> 4
+            :error ->
+              1
+
+            :warning ->
+              2
+
+            :information ->
+              3
+
+            :hint ->
+              4
+
+            other ->
+              Logger.warn(
+                "Invalid severity on diagnostic: #{inspect(other)}, using warning level"
+              )
+
+              2
           end
 
         %{

diff --git a/apps/language_server/lib/language_server/providers/on_type_formatting.ex b/apps/language_server/lib/language_server/providers/on_type_formatting.ex
@@ -49,6 +49,7 @@ defmodule ElixirLS.LanguageServer.Providers.OnTypeFormatting do
       {:ok, nil}
     end
   end
+
   def format(%SourceFile{} = _source_file, _line, _character, _, _options) do
     {:ok, nil}
   end