Aviod deadlock when meta pid is down

elixir-lsp · Jul 11, 2024 · 32f13b1 · 32f13b1
1 parent 87e5c6c
commit 32f13b1
Showing 1 changed file with 68 additions and 42 deletions.
diff --git a/apps/debug_adapter/lib/debug_adapter/stacktrace.ex b/apps/debug_adapter/lib/debug_adapter/stacktrace.ex
@@ -36,52 +36,78 @@ defmodule ElixirLS.DebugAdapter.Stacktrace do
   def get(pid) do
     case :dbg_iserver.safe_call({:get_meta, pid}) do
       {:ok, meta_pid} ->
-        [{level, {module, function, args}} | backtrace_rest] =
-          :int.meta(meta_pid, :backtrace, :all)
-
-        messages = :int.meta(meta_pid, :messages)
-
-        first_frame = %Frame{
-          level: level,
-          module: module,
-          function: {function, get_arity(args)},
-          args: args,
-          file: get_file(module),
-          # vscode raises invalid request when line is nil
-          line: break_line(pid) || 1,
-          bindings: get_bindings(meta_pid, level),
-          messages: messages
-        }
-
-        # If backtrace_rest is empty, calling stack_frames causes an exception
-        other_frames =
-          case backtrace_rest do
-            [] ->
-              []
-
-            _ ->
-              frames = List.zip([backtrace_rest, stack_frames(meta_pid, level)])
-
-              for {{level, {mod, function, args}}, {level, {mod, line}, bindings}} <- frames do
-                %Frame{
-                  level: level,
-                  module: mod,
-                  function: {function, get_arity(args)},
-                  args: args,
-                  file: get_file(mod),
-                  # vscode raises invalid request when line is nil
-                  line: line || 1,
-                  bindings: Enum.into(bindings, %{}),
-                  messages: messages
-                }
+        parent = self()
+        ref = Process.monitor(meta_pid)
+
+        meta_query_pid =
+          spawn(fn ->
+            [{level, {module, function, args}} | backtrace_rest] =
+              :int.meta(meta_pid, :backtrace, :all)
+
+            messages = :int.meta(meta_pid, :messages)
+
+            first_frame = %Frame{
+              level: level,
+              module: module,
+              function: {function, get_arity(args)},
+              args: args,
+              file: get_file(module),
+              # vscode raises invalid request when line is nil
+              line: break_line(pid) || 1,
+              bindings: get_bindings(meta_pid, level),
+              messages: messages
+            }
+
+            # If backtrace_rest is empty, calling stack_frames causes an exception
+            other_frames =
+              case backtrace_rest do
+                [] ->
+                  []
+
+                _ ->
+                  frames = List.zip([backtrace_rest, stack_frames(meta_pid, level)])
+
+                  for {{level, {mod, function, args}}, {level, {mod, line}, bindings}} <- frames do
+                    %Frame{
+                      level: level,
+                      module: mod,
+                      function: {function, get_arity(args)},
+                      args: args,
+                      file: get_file(mod),
+                      # vscode raises invalid request when line is nil
+                      line: line || 1,
+                      bindings: Enum.into(bindings, %{}),
+                      messages: messages
+                    }
+                  end
               end
-          end
 
-        [first_frame | other_frames]
+            send(parent, {:ok, [first_frame | other_frames]})
+          end)
+
+        receive do
+          {:ok, trace} ->
+            trace
+
+          {:DOWN, _, :process, ^meta_pid, reason} ->
+            Process.exit(meta_query_pid, :kill)
+
+            Output.debugger_console(
+              "Meta process down fo pid #{inspect(pid)}: #{inspect(reason)}\n"
+            )
+
+            []
+        after
+          5000 ->
+            Process.exit(meta_query_pid, :kill)
+            Process.demonitor(ref, false)
+            Output.debugger_console("Timed out while obtaining meta for pid #{inspect(pid)}\n")
+            []
+        end
 
       error ->
-        Output.debugger_important(
-          "Failed to obtain meta for pid #{inspect(pid)}: #{inspect(error)}"
+        Output.debugger_console(
+          "Failed to obtain meta for pid #{inspect(pid)}: #{inspect(error)}\n"
         )
 
         []