Deprioretize deprecated completions

#682
elixir-lsp · Oct 6, 2022 · 036d876 · 036d876
1 parent b941421
commit 036d876
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/apps/language_server/lib/language_server/providers/completion.ex b/apps/language_server/lib/language_server/providers/completion.ex
@@ -954,7 +954,15 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
   end
 
   defp sort_items(items) do
-    Enum.sort_by(items, fn %__MODULE__{priority: priority, label: label} ->
+    Enum.sort_by(items, fn %__MODULE__{priority: priority, label: label} = item ->
+      # deprioretize deprecated
+      priority =
+        if item.tags |> Enum.any?(&(&1 == :deprecated)) do
+          priority + 30
+        else
+          priority
+        end
+
       {priority, label =~ Regex.recompile!(~r/^[^a-zA-Z0-9]/), label}
     end)
   end

diff --git a/apps/language_server/lib/language_server/server.ex b/apps/language_server/lib/language_server/server.ex
@@ -327,9 +327,7 @@ defmodule ElixirLS.LanguageServer.Server do
       # close notification send before
       JsonRpc.log_message(
         :warning,
-        "Received textDocument/didOpen for file that is already open. Received uri: #{
-          inspect(uri)
-        }"
+        "Received textDocument/didOpen for file that is already open. Received uri: #{inspect(uri)}"
       )
 
       state