Skip to content

Conversation

@milmazz
Copy link
Member

@milmazz milmazz commented Nov 2, 2015

Closes #435

capture

@josevalim
Copy link
Member

Let's wait @dignifiedquire to sign this one off. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to run the minified build

@dignifiedquire
Copy link
Contributor

Just need to rebuild with minified then all good 👍

@milmazz
Copy link
Member Author

milmazz commented Nov 2, 2015

@josevalim @dignifiedquire Done!

@eksperimental
Copy link
Contributor

How abouy including the version number?

@milmazz
Copy link
Member Author

milmazz commented Nov 3, 2015

@eksperimental I wanted to keep it simple, if the user wants to know the version they can perfectly view it in the menu. Right?

@eksperimental
Copy link
Contributor

The user landing from the elixir website or anywhere else will only see the project name and may not that he can find the version.

@milmazz
Copy link
Member Author

milmazz commented Nov 3, 2015

Done!

screen shot 2015-11-03 at 8 00 00 am

@dignifiedquire
Copy link
Contributor

👍

milmazz added a commit that referenced this pull request Nov 3, 2015
Add project's name in the content on small screens
@milmazz milmazz merged commit 09c504a into elixir-lang:master Nov 3, 2015
@eksperimental
Copy link
Contributor

I am wondering what is the best way to tackle this.

Semantically speaking, the project name is part of the title (h1).
I am wondering if that's ok, and if it makes sense to put a small inside a h1 (I'm just wondering, I just don't have a taken position on this).

Aesthetically speaking, I am thinking is that the project name should be at least in bold.
I have played with making the version number 80% of the project name.
here's a screenshot.
ex_doc_project_name_h1

here's is another version with the project name with the same size as h1. and line-height smaller.
ex_doc_project_name_title_big

I think in the mobile version give to project name the same relevance as the title of the page is the right way to go.

what do you guys think about this?

@eksperimental
Copy link
Contributor

this the edited HTML code for the last screenshot.

<h1 style="line-height: 1.2em; ">
  <small class="visible-xs" style="font-weight: 800; font-size: 1em; ">Mix <small style="font-weight: 800; ">v1.2.0-dev</small></small>
  API Reference
</h1>

which makes me wonder if it makes any sense to still use small at all.

@milmazz milmazz deleted the issue_435 branch November 26, 2016 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants