Fix autolink anchors for non URL safe function names #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padde
force-pushed
the
fix-autolink-anchors
branch
3 times, most recently
from
77c3321 to
aae5201
Compare
padde
force-pushed
the
fix-autolink-anchors
branch
from
aae5201 to
62c6601
Compare
josevalim
added a commit
that referenced
this pull request
Oct 27, 2015
Fix autolink anchors for non URL safe function names
Member
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function names need to be URL escaped in the auto-generated links as well. Other spots I found like the links in the sidebar were already corrected.
For example this section in the elixir docs links to
<<>>/1, which generates the following markup:However, it should be like this
Note that I also changed the specs, which now assert that surrounding spaces are removed. This is now in line with the way
Autolink.project_functionsworks, which also strips spaces.