Copy symbolic links in the assets as actual files #1967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #1966 by modifying the asset copying function to handle symbolic links correctly.
Details
The commit f4a46cb changed the asset copying function from
File.copy/3
toFile.cp_r!/3
, which altered the handling of symbolic links.To resolve this, we add the option
dereference_symlinks: true
toFile.cp_r!/3
as advised by José Valim.Additional Changes
mix fix
to address linting issues present on the currentmain
branch. If necessary, I can create a separate PR or revert this commit based on reviewer feedback.Testing
mix lint
mix test
mix build
and check some pages indoc/index.html
Please review and let me know if any further changes are needed.