Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy symbolic links in the assets as actual files #1967

Merged

Conversation

aYukiSekiguchi
Copy link
Contributor

@aYukiSekiguchi aYukiSekiguchi commented Nov 21, 2024

Summary

This PR addresses issue #1966 by modifying the asset copying function to handle symbolic links correctly.

Details

The commit f4a46cb changed the asset copying function from File.copy/3 to File.cp_r!/3, which altered the handling of symbolic links.

To resolve this, we add the option dereference_symlinks: true to File.cp_r!/3 as advised by José Valim.

Additional Changes

  • Ran mix fix to address linting issues present on the current main branch. If necessary, I can create a separate PR or revert this commit based on reviewer feedback.

Testing

  • Passed mix lint
  • Passed mix test
  • Run mix build and check some pages in doc/index.html
  • Confirmed that all assets are actual files in the reproduced repository antikythera

Please review and let me know if any further changes are needed.

@josevalim josevalim merged commit 36adbeb into elixir-lang:main Nov 21, 2024
5 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants