Allow to reset async for ExUnit.Case by using it again #9360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinst
commented
Sep 21, 2019
kelvinst
changed the title
whatyouhide
reviewed
Sep 21, 2019
kelvinst
commented
Sep 22, 2019
| test "async must be true", context do | ||
| assert context.async | ||
| end | ||
| end |
There was a problem hiding this comment.
Couldn't find a better way to check the value saved to async attribute.
kelvinst
changed the title
josevalim
approved these changes
Sep 22, 2019
|
So I'm confused: the original issue #9355 is about warning if |
|
We want to allow it to be called multiples times because of case template. So we are fixing it so it works as expected if called multiple times (i.e. latest option wins). |
|
@josevalim got it! Thanks @kelvinst! 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9355