Add Logger.levels/0 #13136
Merged
Add Logger.levels/0 #13136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Nov 23, 2023
josevalim
reviewed
Nov 23, 2023
c4710n
force-pushed
the
zd/improve-logger
branch
from
91474b4
to
e624378
Compare
|
The suggestions have been commited. |
whatyouhide
approved these changes
Nov 23, 2023
c4710n
force-pushed
the
zd/improve-logger
branch
from
e624378
to
c52b8ba
Compare
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Nov 23, 2023
Co-authored-by: c4710n <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Logger.levels/0, which returns all the available levels of Logger.It's useful when checking the levels provided by a user.
Edit: Is it possible to backport it to 1.16? Or, we have to wait a few month to use it in a stable version. (1.16 is in the RC state, I'm not sure if merging new features is allowed.)