Reuse repeated prepared statements in unnamed mode #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkrutzer
force-pushed
the
unnamed-reuse-statements
branch
from
e3f5ff0 to
1b6ab14
Compare
josevalim
approved these changes
Nov 4, 2019
|
Looks great! Are you running it in prod? How is it behaving? |
|
We've been running it on staging for a bit, where we do around 1500 queries a second, and we've not seen any errors and the prepared statement count is stable. |
|
Thank you! |
jeroenbourgois
added a commit
to jackjoe/myxql
that referenced
this pull request
Nov 5, 2019
* 'master' of github.com:jackjoe/myxql: Re-use repeated prepared statements in unnamed mode (elixir-ecto#83) Fix flaky test Move ssl test to sync_test.exs to avoid races Release v0.2.10 Add prepare: :force_named, closes elixir-ecto#60 Do not leak statements in other operations Do not leak prepared queries, closes elixir-ecto#80 Make sure :unnamed :statement query get cleaned in cache Do not leak with prepare: :unnamed and cache: :statement Fix public_key_exchange check Parse results out of TestHelper.mysql/1 Fix typo in README.md (elixir-ecto#81)
wojtekmach
added a commit
that referenced
this pull request
Nov 28, 2019
This reverts commit ee3603d.
hkrutzer
added a commit
to hkrutzer/myxql
that referenced
this pull request
Nov 28, 2019
…lixir-ecto#83)"" This reverts commit ed3067e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @josevalim here we are seeing a performance regression in some cases due to no longer having an LRU cache, which Mariaex does have. José mentioned Postgrex reuses repeated prepared statements, which is what this PR implements.
Of course I am open to other implementations. I have not looked at the Postgrex code because augmenting the
last_refseemed easier, but if Postgrex has a better way of accomplishing this then I'm willing to take a look there.