-
Couldn't load subscription status.
- Fork 73
Reuse prepared statements for repeat statements in unnamed mode #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse prepared statements for repeat statements in unnamed mode #126
Conversation
| assert query == query2 | ||
| assert query.ref != query2.ref | ||
| assert query.statement_id != query2.statement_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure about this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be executing the prepared query without repreparing it.
ad9da99 to
ed93b19
Compare
ed93b19 to
0f97bab
Compare
|
@wojtekmach do you have time to take a look at this? |
|
Yeah, sorry for radio silence, I'll try to get to it soon. |
|
@wojtekmach @josevalim ping :) |
Co-authored-by: José Valim <[email protected]>
|
Is the idea here that you if you Just asking because I had some ideas reading through this PR but want to make sure I understand the goal. |
|
Yes, that's the idea. note it applies only to unnamed mode (when we prepare the queries and immediately discard them). |
|
I think this does what you want: greg-rychlewski@fd99c30 For unnamed:
For named:
Sorry I put this in my own branch because I thought it would be clearer than issuing fragmented comments. But if these ideas are good they can be applied here. |
|
@josevalim I didn't notice the age of this PR the first time I replied. Would it be acceptable to submit my version here: greg-rychlewski/myxql@fd99c30? Or if this is expected to pick back up I can leave it alone, no problem. |
|
@greg-rychlewski you can also send your commit on top of this one. So everyone gets recognized. Would that work? |
|
Oh yeah, for sure. Sorry I just never did anything like that before. I just push directly to the fork being used by the PR? |
|
Here is what I would do:
|
|
Closing in favour of #146 |
No description provided.