Stop runner if migration fails (#576)

elixir-ecto · Nov 21, 2023 · d5153e3 · d5153e3
1 parent 30c2cba
commit d5153e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/integration_test/sql/migrator.exs b/integration_test/sql/migrator.exs
@@ -112,6 +112,7 @@ defmodule Ecto.Integration.MigratorTest do
 
   test "bad execute migration" do
     assert catch_error(up(PoolRepo, 31, BadMigration, log: false))
+    assert DynamicSupervisor.which_children(Ecto.MigratorSupervisor) == []
   end
 
   test "broken link migration" do

diff --git a/lib/ecto/migration/runner.ex b/lib/ecto/migration/runner.ex
@@ -24,7 +24,7 @@ defmodule Ecto.Migration.Runner do
     log(level, "== Running #{version} #{inspect(module)}.#{operation}/0 #{direction}")
     {time, _} = :timer.tc(fn -> perform_operation(repo, module, operation) end)
     log(level, "== Migrated #{version} in #{inspect(div(time, 100_000) / 10)}s")
-
+  after
     stop()
   end