Emit telemetry event upon Repo start #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 6, 2020
lib/ecto/repo/supervisor.ex
Outdated
| @@ -169,6 +169,12 @@ defmodule Ecto.Repo.Supervisor do | |||
| def init({name, repo, otp_app, adapter, opts}) do | |||
| case runtime_config(:supervisor, repo, otp_app, opts) do | |||
| {:ok, opts} -> | |||
| :telemetry.execute( | |||
| [:ecto, :repo, :start], | |||
There was a problem hiding this comment.
I wouldn't use start in here because people may think this is a trace and that eventually we will have a stop/exception. What do you think about init or boot?
There was a problem hiding this comment.
Agreed, I'll change to init to match the action that is actually happening
|
💚 💙 💜 💛 ❤️ |
|
Awesome! Looking forward to the next release to leverage this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
telemetryhandlers to listen to an event that signals that a newRepohas been started. This feature enables automatic instrumentation for Repos, whose telemetry events are not knowable ahead of time.@josevalim I tried this out in the New Relic agent and it works quite nicely. The only other thought I had was that perhaps this is a more general pattern that could be recommended by
telemetry, which led to the thought that the event name itself could be something like[:telemetry, :broadcast]or something. I'm not totally sure about that, but I do like this pattern.closes #3266