Fix select_merge on map with outer join #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #3218 Three cases have been added to merge processing: - If the merge argument (`right`) is `nil`, return `left` unmodified. This can happen with a `:left_join` or `:full_join`. This is fully tested. - If the merge source (`left`) is `nil`, return `right` unmodified. This can happen with a `:right_join` or `:full_join`. This is not tested. - If both the source and argument are `nil`, return `nil`. This _probably_ shouldn’t happen, but is currently included for completeness. This is not tested.
|
Thanks @halostatue, the PR looks great. Just one comment: We generally like to avoid adding new fixtures/schemas/tables to integration tests, otherwise they would grow very unwieldy with time. Perhaps a simpler to add a |
|
Let me see what I can do. It will be much later today before I can get to it. |
|
Done. I did add one field to |
|
Thank you, fantastic work! 💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
to elixir-ecto/ecto_sql
that referenced
this pull request
Feb 3, 2020
Required to support elixir-ecto/ecto#3219.
zachdaniel
pushed a commit
to zachdaniel/ecto_sql
that referenced
this pull request
Sep 19, 2020
Required to support elixir-ecto/ecto#3219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3218
Three cases have been added to merge processing:
If the merge argument (
right) isnil, returnleftunmodified. This canhappen with a
:left_joinor:full_join. This is fully tested.If the merge source (
left) isnil, returnrightunmodified. This canhappen with a
:right_joinor:full_join. This is not tested.If both the source and argument are
nil, returnnil. This probablyshouldn’t happen, but is currently included for completeness. This is not
tested.