Skip to content

Commit

Permalink
Fix dynamic through assertion for has_many through assoc (#3217)
Browse files Browse the repository at this point in the history
Since dynamic through assertion is not matched to query - it results in two
same assertions and not testing the dynamic case.
  • Loading branch information
tspenov committed Jan 29, 2020
1 parent 60ba8fb commit 6c7afef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion integration_test/cases/assoc.exs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ defmodule Ecto.Integration.AssocTest do
assert [^u2, ^u1] = TestRepo.all(query)

# Dynamic through
Ecto.assoc([p1, p2], [:comments, :author]) |> order_by([a], a.name)
query = Ecto.assoc([p1, p2], [:comments, :author]) |> order_by([a], a.name)
assert [^u2, ^u1] = TestRepo.all(query)
end

Expand Down

0 comments on commit 6c7afef

Please sign in to comment.