Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a bit better the scripts #47

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Make a bit better the scripts #47

merged 1 commit into from
Dec 14, 2023

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Dec 13, 2023

Few minor improvements of build and run script:

  • Old scripts were building images with the old google server eu.gcr.io/tes-wes/$1:testing.
  • Using rootless buiildah, that allows to build with older docker format (Rahti issue).
  • Added possibility to change the tag.
  • Fixed suggested issues by shellcheck, like the no shebang problem

@lvarin lvarin requested a review from trispera December 13, 2023 14:22
@uniqueg
Copy link
Member

uniqueg commented Dec 14, 2023

Would you mind describing a bit what you did and what problem it addresses, @lvarin? :)

@lvarin
Copy link
Contributor Author

lvarin commented Dec 14, 2023

Would you mind describing a bit what you did and what problem it addresses, @lvarin? :)

Sure, done

@trispera trispera merged commit 822e46c into master Dec 14, 2023
10 checks passed
@trispera trispera deleted the improve-local-build branch December 14, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants