Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add V1.1 feature tests #14

Closed
wants to merge 6 commits into from

Conversation

lbeckman314
Copy link
Contributor

@lbeckman314 lbeckman314 commented Jan 23, 2023

Hello! I'm working on adding v1.1 support for the test suite to verify Funnel's TES compliance as part of @kellrott's lab. This PR is tracking #11 and can hopefully be of use! Happy to add, remove, or edit any changes as you see fit.

The spec class imports are are all explicitly included for the sake of completeness but can be removed if they're not needed due to v1.1 being backwards-compatible.

Currently working on adding tests for the changes listed in the v1.1 release page.

@lbeckman314
Copy link
Contributor Author

lbeckman314 commented Jan 23, 2023

v1.1 features to be tested (ref):

  • Proposal: add "backend_parameters" to tesResources (#154, spec / spec)
  • Add in new tesState for preempted state. (#184, spec)
  • feat: allow wildcards in output paths (#185, spec)
  • Making file type an optional argument (#155, spec)
  • Changing int64 to int32 for page_size and cpu_count (#175)
  • Adding ignore_error flag (#159, spec)
  • Add CANCELING state to delete cloud resources (#189, spec)
  • Adding streamable flag to tesInput (#157, spec)
  • Adding filtering features to task listing (#170)

@lbeckman314 lbeckman314 changed the title Add initial support for v1.1 unittest framework WIP Add V1.1 feature tests Jan 24, 2023
@uniqueg
Copy link
Member

uniqueg commented Jan 24, 2023

This is awesome! 🚀

Welcome @lbeckman314 and please let @LakiG and me know if you need anything. Also, please tag us on any reviews etc.

@uniqueg
Copy link
Member

uniqueg commented Jan 24, 2023

Btw, just to let you know: At some point in the not-too-distant future, we will decouple the runner from the tests and so everything TES-specific (models, test cases) will be migrated to a new repo. In this way, we can easily use the same test runner for running compliance tests against other OpenAPI specs like WES. We will of course keep you in the loop when we have a better idea when that will happen. For now, please follow the current structure.

@lbeckman314
Copy link
Contributor Author

Closing for now in favor of PR #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants