Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit tests #215

Closed
wants to merge 2 commits into from
Closed

fix: unit tests #215

wants to merge 2 commits into from

Conversation

athith-g
Copy link

Description

Fixes #214.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the documentation (or documentation does not need to be updated)
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @athith-g - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@uniqueg uniqueg mentioned this pull request May 20, 2024
@athith-g athith-g closed this May 20, 2024
@uniqueg uniqueg deleted the fix_unit_tests branch May 20, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: failing unit tests
1 participant