-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run without docker
#47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 189 189
=========================================
Hits 189 189 ☔ View full report in Codecov by Sentry. |
Please ignore above reviews, just wanted to see if this solution is viable or not to move further ahead and then implement it in tesk as well. PS: read the foca issue comment I leaft, I think it would be a good idea to use |
Please merge it if you think this is ok :) will discuss how to implement it in |
If I approve a review, feel free to go ahead and merge :) |
Oh, it seems I did not approve. My bad. |
Description
Run without docker
Type of change
Please delete options that are not relevant.