Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling days without results #5

Closed
ades4827 opened this issue Oct 3, 2023 · 2 comments
Closed

Filling days without results #5

ades4827 opened this issue Oct 3, 2023 · 2 comments

Comments

@ades4827
Copy link

ades4827 commented Oct 3, 2023

Hi, using periods like ->between I realized that the data returned by the query forms holes in the case of missing results.

For example using

->between( Carbon::now()->subDays(10)->format('Y-m-d'), Carbon::now()->format('Y-m-d'))

With the following dates:
2023-09-29 14:14:08
2023-10-01 14:14:03
2023-10-02 15:24:29
2023-10-02 15:24:35

I get 3 results.
If you want to use the trends in a graph it would be useful to have the possibility of obtaining the results for the other days too.

eliseekn added a commit that referenced this issue Oct 4, 2023
Add 'fillEmptyDates' method to fill data for empty dates
Fix get trends from 'between' method when using custom label
Update README.md
@eliseekn
Copy link
Owner

eliseekn commented Oct 4, 2023

Hello! Thank you for using my package. I've implemented a new update based on your request. You can now utilize the 'fillEmptyDates' method to automatically fill empty dates with a default value when using the 'between' method. Check the README for an example.

@eliseekn eliseekn closed this as completed Oct 4, 2023
@ades4827
Copy link
Author

ades4827 commented Oct 5, 2023

great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants