Update jitpack.yml #142
Merged
Update jitpack.yml #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-elimu
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Will we have to remove Java 11 from https://github.com/elimu-ai/analytics/blob/main/.github/workflows/gradle.yml as well?
Closed
After looking into it, I don't think that is necessary. The 11 and 17 in that file simply makes it so that it tests against both Java 11 and 17. The matrix.java variable dynamically sets the java version for each run so I don't necessarily think it is necessary but I am willing to do it if you think it should be done. |
nya-elimu
approved these changes
Dec 5, 2023
jo-elimu
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
@jpascoe32fb This change looks perfect to me. Please merge 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the Add jitpack.yml issue