Skip to content

Adjust logs#956

Merged
elie222 merged 1 commit intomainfrom
chore/logs
Nov 12, 2025
Merged

Adjust logs#956
elie222 merged 1 commit intomainfrom
chore/logs

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Nov 12, 2025

Summary by CodeRabbit

  • Refactor

    • Streamlined error handling throughout the application by removing redundant error formatting utilities and consolidating error logging to use raw error objects.
  • Chores

    • Version updated to v2.18.22.

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
inbox-zero Ready Ready Preview Nov 12, 2025 8:28pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

Walkthrough

The pull request removes four error formatting utility functions (isErrorMessage, formatZodError, formatGmailError, formatError) from the error module and updates error logging in reply-tracker utilities to log raw error objects instead of formatted strings. A version bump from v2.18.21 to v2.18.22 was also applied.

Changes

Cohort / File(s) Summary
Error utility cleanup
apps/web/utils/error.ts
Removed four public error formatting and type predicate functions: isErrorMessage, formatZodError, formatGmailError, and formatError. Gmail-related type guards and isError remain.
Error logging refactoring
apps/web/utils/reply-tracker/draft-tracking.ts, apps/web/utils/reply-tracker/handle-outbound.ts
Removed formatError imports and updated two catch blocks in each file to log raw error objects directly instead of formatted error strings. Renamed one catch variable from cleanupError to error.
Version bump
version.txt
Updated version from v2.18.21 to v2.18.22.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that removed functions in error.ts have no remaining imports or usages elsewhere in the codebase
  • Confirm that logging raw error objects in the reply-tracker files maintains adequate debugging information

Suggested reviewers

  • anakarentorosserrano-star
  • mosesjames7271-svg

Poem

🐰 Errors once dressed in formatted attire,
Now hop raw and wild, a simpler desire.
Four functions retire, their duty complete—
Version bumps up, refactoring so neat!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Adjust logs' is vague and generic, failing to convey the specific nature of the changes (removal of error formatting functions and direct raw error logging). Consider a more descriptive title such as 'Remove formatError helpers and log raw errors' or 'Replace formatted error logging with raw error objects' to better communicate the primary change.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/logs

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecdf361 and f1cc1b0.

📒 Files selected for processing (4)
  • apps/web/utils/error.ts (0 hunks)
  • apps/web/utils/reply-tracker/draft-tracking.ts (1 hunks)
  • apps/web/utils/reply-tracker/handle-outbound.ts (2 hunks)
  • version.txt (1 hunks)
💤 Files with no reviewable changes (1)
  • apps/web/utils/error.ts
🧰 Additional context used
📓 Path-based instructions (8)
apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • version.txt
  • apps/web/utils/reply-tracker/draft-tracking.ts
**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
apps/web/utils/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Create utility functions in utils/ folder for reusable logic

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
apps/web/utils/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • version.txt
  • apps/web/utils/reply-tracker/draft-tracking.ts
🧠 Learnings (5)
📚 Learning: 2025-09-17T22:05:28.646Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/llm.mdc:0-0
Timestamp: 2025-09-17T22:05:28.646Z
Learning: Applies to apps/web/utils/ai/**/*.{ts,tsx} : Use proper error types and logging for failures

Applied to files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: apps/web/CLAUDE.md:0-0
Timestamp: 2025-07-18T15:04:30.467Z
Learning: Applies to apps/web/**/*.{ts,tsx} : Use proper error handling with try/catch blocks

Applied to files:

  • apps/web/utils/reply-tracker/handle-outbound.ts
  • apps/web/utils/reply-tracker/draft-tracking.ts
📚 Learning: 2025-07-20T09:03:06.318Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/ultracite.mdc:0-0
Timestamp: 2025-07-20T09:03:06.318Z
Learning: Applies to **/*.{js,jsx,ts,tsx} : Don't use unnecessary catch clauses.

Applied to files:

  • apps/web/utils/reply-tracker/draft-tracking.ts
📚 Learning: 2025-07-20T09:00:41.968Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/security-audit.mdc:0-0
Timestamp: 2025-07-20T09:00:41.968Z
Learning: Applies to apps/web/app/api/**/*.{ts,js} : Review all new withError usage in API routes to ensure custom authentication is implemented where required.

Applied to files:

  • apps/web/utils/reply-tracker/draft-tracking.ts
📚 Learning: 2025-06-23T12:26:53.882Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/prisma.mdc:0-0
Timestamp: 2025-06-23T12:26:53.882Z
Learning: In this project, Prisma should be imported using 'import prisma from "@/utils/prisma";' in TypeScript files.

Applied to files:

  • apps/web/utils/reply-tracker/draft-tracking.ts
🧬 Code graph analysis (1)
apps/web/utils/reply-tracker/handle-outbound.ts (1)
apps/web/utils/reply-tracker/outbound.ts (1)
  • handleOutboundReply (13-94)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: test
🔇 Additional comments (6)
version.txt (1)

1-1: LGTM! Version bump aligns with the refactoring changes.

The patch version increment is appropriate for this logging refactor.

apps/web/utils/reply-tracker/draft-tracking.ts (2)

218-223: LGTM! Raw error logging preserves stack traces and metadata.

Logging the raw error object allows the structured logger to properly serialize all error details including stack traces, which is better than the previous formatted approach.


227-229: LGTM! Consistent error logging approach.

The raw error logging here is consistent with the inner catch block and aligns with the PR's objective to simplify error logging.

apps/web/utils/reply-tracker/handle-outbound.ts (3)

31-33: LGTM! Improved error logging for draft tracking.

The raw error object logging preserves complete error context including stack traces.


38-40: LGTM! Consistent error logging.

This change aligns with the broader refactoring to use raw error object logging throughout the module.


50-52: LGTM! Standardized error variable naming and logging.

The variable rename from cleanupError to error standardizes naming, and raw error logging is consistent with the other catch blocks.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@elie222 elie222 merged commit 4885d86 into main Nov 12, 2025
15 checks passed
@elie222 elie222 deleted the chore/logs branch November 12, 2025 20:28
@coderabbitai coderabbitai bot mentioned this pull request Nov 24, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 5, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments