Default to reply all for outlook

[elie222]

Summary by CodeRabbit

• Bug Fixes

  • Reply drafts now default to reply‑all, including all original recipients.

• New Features

  • Improved email address display: names are formatted consistently with addresses (e.g., "Name ").

• Improvements

  • More consistent message retrieval and recipient/header formatting for Outlook integrations.

• Chores

  • Version updated to v2.18.16.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
inbox-zero	Ready	Preview	Nov 11, 2025 0:50am

[coderabbitai]

Walkthrough

Changed Outlook reply-draft creation to use the reply-all endpoint and centralized Outlook message request builders/field selection; added email formatting utility and tests; bumped version from v2.18.15 to v2.18.16.

Changes

Cohort / File(s)	Summary
Outlook draft reply change apps/web/utils/outlook/mail.ts	Switched draft creation from /me/messages/{id}/createReply to /me/messages/{id}/createReplyAll; updated surrounding comments/terminology while preserving subsequent draft update flow.
Outlook request builders & field selection apps/web/utils/outlook/message.ts, apps/web/utils/outlook/thread.ts, apps/web/utils/email/microsoft.ts	Added MESSAGE_SELECT_FIELDS, createMessagesRequest(client), and createMessageRequest(client,messageId); replaced inline .api(...).select(...) usages with the new helpers; added recipient/From formatting helpers and used formatEmailWithName.
Email formatting utility & tests apps/web/utils/email.ts, apps/web/utils/email.test.ts	Added exported formatEmailWithName(name, address) and comprehensive tests covering empty/null values, special characters, Unicode, and round-trip compatibility with existing extract helpers.
Version bump version.txt	Incremented version from v2.18.15 to v2.18.16.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant App as App Code
  participant Outlook as Outlook Client
  participant Graph as Microsoft Graph API

  rect rgb(230, 248, 230)
    Note right of App: draftEmail flow (changed)
  end

  App->>Outlook: getClient()
  App->>Outlook: client.api("/me/messages/{id}/createReplyAll").post()
  Outlook->>Graph: POST createReplyAll
  Graph-->>Outlook: 201 Draft message (id)
  Outlook-->>App: draft message
  App->>Outlook: client.api("/me/messages/{draftId}").patch(updatedBody)
  Outlook->>Graph: PATCH update draft
  Graph-->>Outlook: 200 Updated draft
  Outlook-->>App: updated draft

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Areas needing extra attention:
  • apps/web/utils/outlook/message.ts (new public helpers and MESSAGE_SELECT_FIELDS consistency)
  • apps/web/utils/outlook/mail.ts (confirm reply-all semantics and recipient behavior)
  • apps/web/utils/email.ts and apps/web/utils/email.test.ts (new API correctness and test coverage)

Possibly related PRs

• Refactor email provider imports #702 — Touches the same draftEmail functionality in apps/web/utils/outlook/mail.ts; related to reply-draft behavior changes.
• Better retries for outlook #931 — Wraps draft create/update calls with retry logic; overlaps with modifications to the same draft flow.
• Fix outlook error #839 — Modifies Outlook message utilities and field selection; related to centralizing message selects and request helpers.

Suggested reviewers

• mosesjames7271-svg
• johnlowe399-blip

Poem

🐰
I hopped to change a reply to all,
stitched fields and helpers, big and small.
A name and email now align,
version bumped — we sip carrot wine. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 41.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title "Default to reply all for outlook" accurately reflects the primary change in the pull request - modifying the Outlook email reply behavior to use createReplyAll instead of createReply. However, the changeset includes several other significant modifications like adding formatEmailWithName utility function, refactoring with MESSAGE_SELECT_FIELDS constant, and version bump, which are not captured in the title.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/outlook-reply-all

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d360301 and 96dcf9a.

📒 Files selected for processing (5)

• apps/web/utils/email.test.ts (2 hunks)
• apps/web/utils/email.ts (1 hunks)
• apps/web/utils/email/microsoft.ts (4 hunks)
• apps/web/utils/outlook/message.ts (7 hunks)
• apps/web/utils/outlook/thread.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

apps/web/utils/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Create utility functions in utils/ folder for reusable logic

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

apps/web/utils/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

• apps/web/utils/email.ts
• apps/web/utils/outlook/message.ts
• apps/web/utils/email.test.ts
• apps/web/utils/outlook/thread.ts
• apps/web/utils/email/microsoft.ts

**/*.test.{ts,js}

📄 CodeRabbit inference engine (.cursor/rules/security.mdc)

Include security tests in your test suites to verify authentication, authorization, and error handling.

Files:

• apps/web/utils/email.test.ts

**/*.{test,spec}.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{test,spec}.{js,jsx,ts,tsx}: Don't use export or module.exports in test files.
Don't use focused tests.
Don't use disabled tests.
Make sure the assertion function, like expect, is placed inside an it() function call.
Don't nest describe() blocks too deeply in test files.
Don't use focused tests.
Don't use disabled tests.
Don't use export or module.exports in test files.

Files:

• apps/web/utils/email.test.ts

**/*.test.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/testing.mdc)

**/*.test.{ts,tsx}: Use Vitest (vitest) as the testing framework
Colocate tests next to the file under test (e.g., dir/format.ts with dir/format.test.ts)
In tests, mock the server-only module with vi.mock("server-only", () => ({}));
When testing code that uses Prisma, mock it with vi.mock("@/utils/prisma") and use the mock from @/utils/__mocks__/prisma
Use provided helpers for mocks: import { getEmail, getEmailAccount, getRule } from @/__tests__/helpers
Each test should be independent
Use descriptive test names
Mock external dependencies in tests
Clean up mocks between tests (e.g., vi.clearAllMocks() in beforeEach)
Avoid testing implementation details; focus on observable behavior
Do not mock the Logger

Files:

• apps/web/utils/email.test.ts

🧠 Learnings (6)

📚 Learning: 2025-10-02T23:23:48.064Z

Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/llm-test.mdc:0-0
Timestamp: 2025-10-02T23:23:48.064Z
Learning: Applies to apps/web/__tests__/**/*.test.ts : Prefer existing helpers from @/__tests__/helpers.ts (getEmailAccount, getEmail, getRule, getMockMessage, getMockExecutedRule) over custom helpers

Applied to files:

• apps/web/utils/email.test.ts
• apps/web/utils/email/microsoft.ts

📚 Learning: 2025-09-20T18:24:34.280Z

Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-09-20T18:24:34.280Z
Learning: Applies to **/*.test.{ts,tsx} : Use provided helpers for mocks: import `{ getEmail, getEmailAccount, getRule }` from `@/__tests__/helpers`

Applied to files:

• apps/web/utils/email.test.ts

📚 Learning: 2025-10-02T23:23:48.064Z

Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/llm-test.mdc:0-0
Timestamp: 2025-10-02T23:23:48.064Z
Learning: Applies to apps/web/__tests__/**/*.test.ts : Include standard test cases: happy path, error handling, edge cases (empty/null), different user configurations, and various input formats

Applied to files:

• apps/web/utils/email.test.ts

📚 Learning: 2025-09-20T18:24:34.280Z

Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-09-20T18:24:34.280Z
Learning: Applies to **/*.test.{ts,tsx} : Use descriptive test names

Applied to files:

• apps/web/utils/email.test.ts

📚 Learning: 2025-07-18T15:05:34.899Z

Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/gmail-api.mdc:0-0
Timestamp: 2025-07-18T15:05:34.899Z
Learning: Applies to apps/web/utils/gmail/**/*.ts : Keep provider-specific implementation details isolated in the appropriate utils subfolder (e.g., 'apps/web/utils/gmail/')

Applied to files:

• apps/web/utils/email.test.ts
• apps/web/utils/email/microsoft.ts

📚 Learning: 2025-10-02T23:23:48.064Z

Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/llm-test.mdc:0-0
Timestamp: 2025-10-02T23:23:48.064Z
Learning: Applies to apps/web/__tests__/**/*.test.ts : Test both AI and non-AI paths, including cases where no AI processing is required

Applied to files:

• apps/web/utils/email.test.ts

🧬 Code graph analysis (4)

apps/web/utils/outlook/message.ts (2)

apps/web/utils/outlook/client.ts (1)

• OutlookClient (19-80)

apps/web/utils/email.ts (1)

• formatEmailWithName (107-114)

apps/web/utils/email.test.ts (1)

apps/web/utils/email.ts (3)

• formatEmailWithName (107-114)
• extractNameFromEmail (9-16)
• extractEmailAddress (19-52)

apps/web/utils/outlook/thread.ts (1)

apps/web/utils/outlook/message.ts (1)

• createMessagesRequest (486-488)

apps/web/utils/email/microsoft.ts (1)

apps/web/utils/outlook/message.ts (1)

• MESSAGE_SELECT_FIELDS (13-14)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Jit Security
• GitHub Check: test
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

apps/web/utils/email.test.ts (1)

302-373: Great edge-case coverage on the new formatter.

Thanks for exercising null-ish inputs, unicode names, and the round-trip with the extractor helpers—this gives high confidence the helper won’t regress callers.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files

[cubic-dev-ai]

No issues found across 5 files