Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughTwo assistant settings components receive optimistic UI updates and improved error handling: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as Toggle UI
participant Handler as handleToggle
participant SWR as SWR mutate
participant API as execute()
User->>UI: Click toggle
UI->>Handler: onChange event
Handler->>SWR: mutate(optimisticData, false)
SWR->>UI: Update UI immediately
Handler->>API: execute({ enable })
alt Success
API-->>SWR: Server response
SWR->>UI: Validate/sync
else Error
API-->>Handler: Error
Handler->>SWR: mutate() re-fetch
SWR->>UI: Revert to server state
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx (1)
33-46: Well-implemented optimistic UI pattern.The
handleToggleimplementation perfectly mirrors the pattern inReferralSignatureSetting.tsx, providing instant UI feedback. The guard, optimistic update, and async execution are all correctly structured.Optional refactor suggestion: Since both
MultiRuleSettingandReferralSignatureSettinguse the identical optimistic toggle pattern, consider extracting this into a custom hook likeuseOptimisticToggleto reduce duplication:function useOptimisticToggle<T>({ data, mutate, execute, optimisticKey, }: { data: T | undefined; mutate: (data: T, revalidate: boolean) => void; execute: (params: { enabled: boolean }) => void; optimisticKey: keyof T; }) { return useCallback( (enabled: boolean) => { if (!data) return; const optimisticData = { ...data, [optimisticKey]: enabled, }; mutate(optimisticData, false); execute({ enabled }); }, [data, mutate, execute, optimisticKey] ); }This would centralize the pattern and make it reusable across other toggle settings in the future. However, this can be deferred if the pattern isn't used more widely yet.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx(4 hunks)apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsx(2 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (14)
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
version.txtapps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
version.txtapps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
apps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
apps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
apps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx🧠 Learnings (11)
📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/hooks/**/*.{ts,tsx} : Call `mutate()` after successful mutations to refresh dataApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-07-18T15:05:16.146Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/fullstack-workflow.mdc:0-0 Timestamp: 2025-07-18T15:05:16.146Z Learning: Applies to apps/web/hooks/**/*.ts : Call `mutate()` after successful mutations to refresh SWR data on the client.Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-07-18T15:04:44.818Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/data-fetching.mdc:0-0 Timestamp: 2025-07-18T15:04:44.818Z Learning: Applies to app/**/*.{ts,tsx} : For mutating data, use Next.js server actionsApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsx📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/*.tsx : Use `result?.serverError` with `toastError` and `toastSuccess`Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-07-18T15:04:44.818Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/data-fetching.mdc:0-0 Timestamp: 2025-07-18T15:04:44.818Z Learning: Applies to {app,components}/**/*.{ts,tsx} : Use `result?.serverError` with `toastError` and `toastSuccess` for error handling; success toast is optionalApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsxapps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-09-17T22:05:28.646Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/llm.mdc:0-0 Timestamp: 2025-09-17T22:05:28.646Z Learning: Applies to apps/web/utils/{ai,llms}/**/*.{ts,tsx} : Keep related AI functions co-located and extract common patterns into utilities; document complex AI logic with clear commentsApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-07-20T09:00:16.505Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/project-structure.mdc:0-0 Timestamp: 2025-07-20T09:00:16.505Z Learning: Applies to apps/web/app/**/*.tsx : Components with `onClick` must be client components with `use client` directiveApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-07-18T15:07:00.269Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/page-structure.mdc:0-0 Timestamp: 2025-07-18T15:07:00.269Z Learning: Applies to apps/web/app/(app)/*/**/*.tsx : If you need to use onClick in a component, that component is a client component and file must start with 'use client'Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-07-18T17:27:58.249Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/server-actions.mdc:0-0 Timestamp: 2025-07-18T17:27:58.249Z Learning: Applies to apps/web/utils/actions/*.ts : Use `adminActionClient` for actions restricted to admin users.Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2025-07-18T15:05:16.146Z
Learnt from: CR Repo: elie222/inbox-zero PR: 0 File: .cursor/rules/fullstack-workflow.mdc:0-0 Timestamp: 2025-07-18T15:05:16.146Z Learning: Applies to apps/web/components/**/*Form.tsx : Use `result?.serverError` with `toastError` and `toastSuccess` for error and success notifications in form submission handlers.Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx📚 Learning: 2024-08-23T11:37:26.779Z
Learnt from: aryanprince Repo: elie222/inbox-zero PR: 210 File: apps/web/app/(app)/stats/NewsletterModal.tsx:2-4 Timestamp: 2024-08-23T11:37:26.779Z Learning: `MoreDropdown` is a React component and `useUnsubscribeButton` is a custom React hook, and they should not be imported using `import type`.Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
apps/web/app/(app)/[emailAccountId]/assistant/settings/ReferralSignatureSetting.tsx (2)
27-34: Good error recovery pattern.Calling
mutate()in the error handler ensures the cache is refreshed to revert optimistic updates if the action fails. This provides a smooth user experience by automatically recovering from failures.Based on learnings.
41-54: Excellent optimistic UI implementation!The refactored
handleToggleachieves the "faster toggle" objective by:
- Guarding against missing data
- Constructing optimistic data
- Updating the cache immediately with
mutate(optimisticData, false)for instant UI feedback- Executing the action asynchronously
The
falseflag prevents immediate revalidation, allowing the optimistic update to show instantly while the server action completes in the background. The error handler (line 28) andonSettledensure eventual consistency.apps/web/app/(app)/[emailAccountId]/assistant/settings/MultiRuleSetting.tsx (1)
22-27: Consistent error recovery pattern.The addition of
mutate()in the error handler matches the pattern inReferralSignatureSetting.tsx, ensuring cache refresh to revert optimistic updates on failure. This consistency across components is excellent.Based on learnings.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
1 participant
Summary by CodeRabbit
Bug Fixes
Improvements
Chores