dont match on disabled learned patterns

[elie222]

Summary by CodeRabbit

• Refactor

  • Improved internal type organization and enhanced parameter flexibility for better code consistency.

• Chores

  • Version bumped to v2.17.9.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
inbox-zero	Ready	Preview	Oct 23, 2025 0:54am

[coderabbitai]

Walkthrough

This PR refactors type abstractions and introduces optional filtering behavior. A new public type GroupsWithRules is exported from the group matching utilities, replacing an internal type derivation. The getGroupsWithRules function now accepts an optional enabledOnly parameter (defaults true) to conditionally filter rules. Type annotations in the rule-matching module are updated to use the simplified public type.

Changes

Cohort / File(s)	Summary
Type abstraction and filter logic apps/web/utils/group/find-matching-group.ts	Exports new public type GroupsWithRules for the return type of getGroupsWithRules; adds optional enabledOnly parameter (defaults true); updates filter logic to conditionally filter groups based on rule enablement or nullability
Type consumer update apps/web/utils/ai/choose-rule/match-rules.ts	Replaces internal Awaited<ReturnType<typeof getGroupsWithRules>> annotations with the new public GroupsWithRules type; updates matchesGroupRule parameter type accordingly
Version bump version.txt	Updates version from v2.17.8 to v2.17.9

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The changes involve type extraction and parameter refinement with straightforward logic, but require verification of filter condition correctness and type alignment across multiple files. The optional parameter default and conditional filtering logic introduce moderate complexity despite modest file count.

Possibly related PRs

• Adjust group matches #285: Modifies the same matching modules (find-matching-group.ts and match-rules.ts) and updates GroupsWithRules type signatures.
• Make it easier to fix category/group for rule #312: Changes type annotations and function signatures in match-rules.ts for handling group rule types.

Poem

🐰 A type emerges, clean and bright,
Optional filters, logic made right,
Rules now flex with a boolean dance,
Public abstractions advance!
*hops happily*

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "dont match on disabled learned patterns" is directly related to the main functional change in the changeset. The core modifications involve making the enabledOnly parameter optional in getGroupsWithRules and implementing logic to filter out disabled rules when enabled filtering is active. This aligns perfectly with what the title conveys—preventing matches on disabled learned patterns. The title is concise, specific, and clearly communicates the primary change without vague terminology. A developer scanning the history would understand that this PR addresses how the system handles disabled pattern rules.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/group-fetching

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a098c03 and 611cd7b.

📒 Files selected for processing (3)

• apps/web/utils/ai/choose-rule/match-rules.ts (3 hunks)
• apps/web/utils/group/find-matching-group.ts (1 hunks)
• version.txt (1 hunks)

🧰 Additional context used

📓 Path-based instructions (10)

!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

• version.txt
• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

• version.txt
• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

apps/web/utils/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Create utility functions in utils/ folder for reusable logic

Files:

• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

apps/web/utils/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size

Files:

• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

• apps/web/utils/group/find-matching-group.ts
• apps/web/utils/ai/choose-rule/match-rules.ts

apps/web/utils/ai/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/llm.mdc)

apps/web/utils/ai/**/*.{ts,tsx}: Place main LLM feature implementations under apps/web/utils/ai/
LLM feature functions should follow the provided TypeScript pattern (separate system/user prompts, use createGenerateObject, Zod schema validation, early validation, return result.object)
Keep system prompts and user prompts separate
System prompt should define the LLM's role and task specifications
User prompt should contain the actual data and context
Always define a Zod schema for response validation
Make Zod schemas as specific as possible to guide LLM output
Use descriptive scoped loggers for each feature
Log inputs and outputs with appropriate log levels and include relevant context
Implement early returns for invalid inputs
Use proper error types and logging for failures
Implement fallbacks for AI failures
Add retry logic for transient failures using withRetry
Use XML-like tags to structure data in prompts
Remove excessive whitespace and truncate long inputs in prompts
Format prompt data consistently across similar functions
Use TypeScript types for all parameters and return values in LLM features
Define clear interfaces for complex input/output structures in LLM features

Files:

• apps/web/utils/ai/choose-rule/match-rules.ts

apps/web/utils/{ai,llms}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/llm.mdc)

Keep related AI functions co-located and extract common patterns into utilities; document complex AI logic with clear comments

Files:

• apps/web/utils/ai/choose-rule/match-rules.ts

🧬 Code graph analysis (1)

apps/web/utils/ai/choose-rule/match-rules.ts (1)

apps/web/utils/group/find-matching-group.ts (1)

• GroupsWithRules (6-6)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: test

🔇 Additional comments (5)

apps/web/utils/group/find-matching-group.ts (2)

6-6: LGTM! Good type export for reusability.

Exporting GroupsWithRules as a public type improves code maintainability and eliminates the need for consumers to derive the type using Awaited<ReturnType<typeof getGroupsWithRules>>.

---

8-22: No issues found. The default behavior change is intentional and correctly implemented.

Verification results:

• The enabled field exists on the Rule model in the Prisma schema
• Only one caller is affected: match-rules.ts line 304, which calls getGroupsWithRules({ emailAccountId }) without specifying enabledOnly
• The change aligns with the PR title: "dont match on disabled learned patterns"
• The LearnedPatternsLoader will now correctly skip disabled rules

The breaking change is intentional and the codebase structure supports it.

apps/web/utils/ai/choose-rule/match-rules.ts (3)

5-5: LGTM! Using the new public type.

Importing and using the GroupsWithRules type improves code clarity and maintainability compared to deriving it inline.

---

299-307: LGTM! Correctly filters disabled learned patterns.

The LearnedPatternsLoader now uses the default enabledOnly=true behavior, which means only enabled learned patterns will be loaded and matched. This aligns perfectly with the PR objective of not matching on disabled learned patterns.

---

498-519: LGTM! Type annotation improved.

The parameter type update to GroupsWithRules is consistent with the refactoring and improves code readability without changing the function's logic.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 3 files