Fix conversation labels not being removed

[elie222]

Summary by CodeRabbit

• Performance Improvements

  • Concurrentized thread-status operations to speed up processing and reduce latency.

• Bug Fixes

  • Improved removal of conflicting thread status labels to keep thread state consistent during updates.

• Tests

  • Updated tests to reflect new label-removal behavior and no-conflict scenarios.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
inbox-zero	Ready	Preview	Oct 23, 2025 0:29am

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Parallelizes thread status label removal and tracking updates by introducing removeConflictingThreadStatusLabels and running label-removal and tracker updates concurrently (Promise.all) in rule execution and outbound flows; adds tests adjustments and bumps version to v2.17.8.

Changes

Cohort / File(s)	Change Summary
Label management refactor apps/web/utils/reply-tracker/label-helpers.ts	Added exported removeConflictingThreadStatusLabels; introduced internal LabelIds type; refactored applyThreadStatusLabel to call removal separately (now run in parallel where used); updated getLabelIdsFromDb return type; added EmailLabel import; adjusted logging.
Rule execution concurrency apps/web/utils/ai/choose-rule/run-rules.ts	Added import for removeConflictingThreadStatusLabels and wrapped removeConflictingThreadStatusLabels and updateThreadTrackers in Promise.all for concurrent execution in rule-processing paths.
Outbound tracking concurrency apps/web/utils/reply-tracker/outbound.ts	Replaced sequential await applyThreadStatusLabel then await updateThreadTrackers with await Promise.all([applyThreadStatusLabel(...), updateThreadTrackers(...)]) to run both operations concurrently.
Tests apps/web/utils/reply-tracker/label-helpers.test.ts	Removed logger mocking; updated expectations so removeThreadLabels is not called when there are no provider labels or when label-creation fails.
Version bump version.txt	Bumped version from v2.17.7 to v2.17.8.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Caller
    participant RunRules as run-rules / outbound
    participant Labels as label-helpers
    participant Trackers as thread-trackers

    rect rgba(220,220,255,0.2)
    note right of RunRules: Original (sequential)
    Caller->>RunRules: process rule / send outbound
    RunRules->>Labels: applyThreadStatusLabel (adds label, inline removal previously)
    Labels->>Trackers: remove conflicting labels
    Labels->>Trackers: add new status label
    RunRules->>Trackers: updateThreadTrackers
    end

    rect rgba(220,255,220,0.2)
    note right of RunRules: New (concurrent)
    Caller->>RunRules: process rule / send outbound
    par Parallel removal & tracking update
        RunRules->>Labels: removeConflictingThreadStatusLabels(...)
        RunRules->>Trackers: updateThreadTrackers(...)
    end
    RunRules->>Labels: applyThreadStatusLabel (add-only)
    Labels->>Trackers: add new status label
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

Possibly related PRs

• Dont learn for to reply rule #779 — touches apps/web/utils/ai/choose-rule/run-rules.ts and modifies logic around rule systemType; closely related to rule-status handling changes here.
• Allow multiple rule matches #854 — also updates run-rules and conversation-tracking flows; overlaps with concurrent execution and tracker-update logic.

Suggested reviewers

• anakarentorosserrano-star

Poem

🐇 I hopped through labels, quick and spry,

Conflicts cleared in one swift try,
Trackers raced while labels fell,
Promises joined — all went well,
A tiny rabbit, coding sky-high.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Fix conversation labels not being removed" directly addresses the core objective of this pull request. The changeset introduces a new function removeConflictingThreadStatusLabels and refactors the label removal logic to properly handle the removal of conflicting thread status labels, which aligns perfectly with the stated title. The title is concise, clear, and specific enough for a team member reviewing history to understand that this is a bug fix addressing label removal functionality rather than a feature addition or generic change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/conversation-labelling

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30d1278 and f81c515.

📒 Files selected for processing (1)

• apps/web/utils/reply-tracker/label-helpers.test.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

**/*.test.{ts,js}

📄 CodeRabbit inference engine (.cursor/rules/security.mdc)

Include security tests in your test suites to verify authentication, authorization, and error handling.

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

apps/web/utils/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Create utility functions in utils/ folder for reusable logic

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

apps/web/utils/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

**/*.{test,spec}.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{test,spec}.{js,jsx,ts,tsx}: Don't use export or module.exports in test files.
Don't use focused tests.
Don't use disabled tests.
Make sure the assertion function, like expect, is placed inside an it() function call.
Don't nest describe() blocks too deeply in test files.
Don't use focused tests.
Don't use disabled tests.
Don't use export or module.exports in test files.

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

**/*.test.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/testing.mdc)

**/*.test.{ts,tsx}: Use Vitest (vitest) as the testing framework
Colocate tests next to the file under test (e.g., dir/format.ts with dir/format.test.ts)
In tests, mock the server-only module with vi.mock("server-only", () => ({}));
When testing code that uses Prisma, mock it with vi.mock("@/utils/prisma") and use the mock from @/utils/__mocks__/prisma
Use provided helpers for mocks: import { getEmail, getEmailAccount, getRule } from @/__tests__/helpers
Each test should be independent
Use descriptive test names
Mock external dependencies in tests
Clean up mocks between tests (e.g., vi.clearAllMocks() in beforeEach)
Avoid testing implementation details; focus on observable behavior
Do not mock the Logger

Files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

🧠 Learnings (3)

📚 Learning: 2025-09-20T18:24:34.280Z

Learnt from: CR
PR: elie222/inbox-zero#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-09-20T18:24:34.280Z
Learning: Applies to **/*.test.{ts,tsx} : In tests, mock the `server-only` module with `vi.mock("server-only", () => ({}));`

Applied to files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

📚 Learning: 2025-09-20T18:24:34.280Z

Learnt from: CR
PR: elie222/inbox-zero#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-09-20T18:24:34.280Z
Learning: Applies to **/*.test.{ts,tsx} : When testing code that uses Prisma, mock it with `vi.mock("@/utils/prisma")` and use the mock from `@/utils/__mocks__/prisma`

Applied to files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

📚 Learning: 2025-10-02T23:23:48.064Z

Learnt from: CR
PR: elie222/inbox-zero#0
File: .cursor/rules/llm-test.mdc:0-0
Timestamp: 2025-10-02T23:23:48.064Z
Learning: Applies to apps/web/__tests__/**/*.test.ts : Mock the Next.js server runtime marker by adding vi.mock("server-only", () => ({})) in LLM tests

Applied to files:

• apps/web/utils/reply-tracker/label-helpers.test.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Jit Security
• GitHub Check: test
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

apps/web/utils/reply-tracker/label-helpers.test.ts (1)

268-291: LGTM! Test correctly validates no-conflict scenario.

The updated test logic is correct: when there are no labels from the database and no labels from the provider, there are no conflicting labels to remove, so removeThreadLabels should not be called. The comment on line 272 clearly explains this scenario, and the expectation on lines 286-287 correctly reflects that removeThreadLabels should not be invoked when there are no conflicting labels.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d35dc3 and 30d1278.

📒 Files selected for processing (4)

• apps/web/utils/ai/choose-rule/run-rules.ts (2 hunks)
• apps/web/utils/reply-tracker/label-helpers.ts (6 hunks)
• apps/web/utils/reply-tracker/outbound.ts (1 hunks)
• version.txt (1 hunks)

🧰 Additional context used

📓 Path-based instructions (10)

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• version.txt
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

apps/web/utils/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Create utility functions in utils/ folder for reusable logic

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

apps/web/utils/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts
• version.txt
• apps/web/utils/reply-tracker/outbound.ts
• apps/web/utils/reply-tracker/label-helpers.ts

apps/web/utils/ai/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/llm.mdc)

apps/web/utils/ai/**/*.{ts,tsx}: Place main LLM feature implementations under apps/web/utils/ai/
LLM feature functions should follow the provided TypeScript pattern (separate system/user prompts, use createGenerateObject, Zod schema validation, early validation, return result.object)
Keep system prompts and user prompts separate
System prompt should define the LLM's role and task specifications
User prompt should contain the actual data and context
Always define a Zod schema for response validation
Make Zod schemas as specific as possible to guide LLM output
Use descriptive scoped loggers for each feature
Log inputs and outputs with appropriate log levels and include relevant context
Implement early returns for invalid inputs
Use proper error types and logging for failures
Implement fallbacks for AI failures
Add retry logic for transient failures using withRetry
Use XML-like tags to structure data in prompts
Remove excessive whitespace and truncate long inputs in prompts
Format prompt data consistently across similar functions
Use TypeScript types for all parameters and return values in LLM features
Define clear interfaces for complex input/output structures in LLM features

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts

apps/web/utils/{ai,llms}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/llm.mdc)

Keep related AI functions co-located and extract common patterns into utilities; document complex AI logic with clear comments

Files:

• apps/web/utils/ai/choose-rule/run-rules.ts

🧬 Code graph analysis (3)

apps/web/utils/ai/choose-rule/run-rules.ts (2)

apps/web/utils/reply-tracker/label-helpers.ts (1)

• removeConflictingThreadStatusLabels (13-73)

apps/web/utils/reply-tracker/handle-conversation-status.ts (1)

• updateThreadTrackers (101-155)

apps/web/utils/reply-tracker/outbound.ts (3)

apps/web/utils/reply-tracker/label-helpers.ts (1)

• applyThreadStatusLabel (82-146)

apps/web/utils/reply-tracker/handle-conversation-status.ts (1)

• updateThreadTrackers (101-155)

apps/web/utils/date.ts (1)

• internalDateToDate (59-71)

apps/web/utils/reply-tracker/label-helpers.ts (4)

apps/web/utils/reply-tracker/conversation-status-config.ts (2)

• ConversationStatus (10-14)
• CONVERSATION_STATUS_TYPES (3-8)

apps/web/utils/email/types.ts (2)

• EmailProvider (44-230)
• EmailLabel (13-24)

apps/web/utils/logger.ts (1)

• createScopedLogger (17-80)

apps/web/utils/rule/consts.ts (1)

• getRuleLabel (122-124)

🪛 GitHub Actions: Run Tests

apps/web/utils/reply-tracker/label-helpers.ts

[error] 95-95: TypeError: (0 , createScopedLogger)(...).with is not a function

🪛 GitHub Check: test

apps/web/utils/reply-tracker/label-helpers.ts

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > removes exactly 3 labels (all except target)
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:322:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > executes remove and add operations in parallel
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:308:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > handles label creation failure gracefully
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:284:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > creates label when not found in DB or provider labels
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:256:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > uses provider label when label ID not in database
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:208:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > removes other labels from thread and adds target label to message for ACTIONED
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:145:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > removes other labels from thread and adds target label to message for FYI
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:121:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > removes other labels from thread and adds target label to message for AWAITING_REPLY
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:101:11

---

[failure] 95-95: utils/reply-tracker/label-helpers.test.ts > applyThreadStatusLabel > removes other labels from thread and adds target label to message for TO_REPLY
TypeError: (0 , createScopedLogger)(...).with is not a function
❯ Module.applyThreadStatusLabel utils/reply-tracker/label-helpers.ts:95:63
❯ utils/reply-tracker/label-helpers.test.ts:69:11

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: cubic · AI code reviewer

🔇 Additional comments (8)

version.txt (1)

1-1: LGTM!

Standard version bump aligned with the parallelization improvements in this PR.

apps/web/utils/reply-tracker/outbound.ts (1)

77-92: LGTM! Effective parallelization.

The change to run applyThreadStatusLabel and updateThreadTrackers in parallel is safe because these operations are independent—one modifies labels through the provider API while the other updates local database trackers. This reduces total processing time without changing functionality.

apps/web/utils/ai/choose-rule/run-rules.ts (2)

31-31: LGTM!

Import of the new removeConflictingThreadStatusLabels helper is correctly placed and used below.

---

282-296: LGTM! Consistent parallelization pattern.

Running removeConflictingThreadStatusLabels and updateThreadTrackers concurrently is safe because they operate on independent resources—label operations via the provider API and database tracker updates respectively. This aligns with the concurrent execution pattern introduced throughout this PR.

apps/web/utils/reply-tracker/label-helpers.ts (4)

1-1: LGTM!

The EmailLabel import is correctly added to support the new removeConflictingThreadStatusLabels function signature.

---

11-12: LGTM!

The LabelIds type alias improves code clarity by explicitly documenting the structure of the conversation status label ID mapping.

---

13-73: LGTM! Well-designed label removal logic.

The new removeConflictingThreadStatusLabels function is well-implemented with:

• Efficient batch removal in a single API call
• Optional parameters to avoid redundant fetching when caller has the data
• Clear logging for observability
• Proper error handling that logs failures without throwing (resilient pattern)

The error handling pattern (.catch() with logging) ensures the operation doesn't block the overall flow if label removal fails, which is appropriate for this use case.

---

133-143: LGTM! Effective parallelization with efficient data reuse.

Running removeConflictingThreadStatusLabels and addLabel in parallel is safe because they operate on mutually exclusive labels. The change also efficiently passes pre-fetched dbLabelIds and providerLabels to avoid redundant lookups.

[cubic-dev-ai]

1 issue found across 4 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="apps/web/utils/reply-tracker/outbound.ts">

<violation number="1" location="apps/web/utils/reply-tracker/outbound.ts:77">
Running these two operations in Promise.all introduces a race: updateThreadTrackers now runs even when applyThreadStatusLabel rejects (e.g. provider.getLabels fails), so trackers can be updated while labels were never applied—previous sequential awaits avoided that inconsistent state.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}