Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughRemoves the pending/approval workflow across UI, APIs, and actions; treats rules as automated (enabled) by default in execution flow; updates risk evaluation to ignore automate flags; adds migrations to disable historically non-automated rules and mark pending/rejected executions as skipped; bumps version. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as UI (create/update)
participant Run as runRules
participant DB as DB (ExecutedRule)
participant Exec as executeAct
participant EP as Email Provider
UI->>Run: trigger rule evaluation / create executedRule
Run->>DB: saveExecutedRule(status=APPLYING, automated=true)
alt has immediate actions
Run->>Exec: executeAct({ executedRule, message, userId, userEmail, emailAccountId })
Exec->>EP: apply action items
EP-->>Exec: results
Exec->>DB: update status=APPLIED
else only delayed actions
Note over Run,DB: status remains APPLYING until delayed actions complete
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments:
apps/web/utils/risk.test.ts (line 120):
The test is calling getActionRiskLevel with the old function signature (3 parameters) but the function now only accepts 2 parameters after the refactoring.
View Details
📝 Patch Details
diff --git a/apps/web/utils/risk.test.ts b/apps/web/utils/risk.test.ts
index c98d6e030..b0c904c5a 100644
--- a/apps/web/utils/risk.test.ts
+++ b/apps/web/utils/risk.test.ts
@@ -117,7 +117,7 @@ describe("getActionRiskLevel", () => {
expectedMessageContains,
}) => {
it(name, () => {
- const result = getActionRiskLevel(action, hasAutomation, {
+ const result = getActionRiskLevel(action, {
instructions,
});
expect(result.level).toBe(expectedLevel);
Analysis
Test calling getActionRiskLevel() with outdated 3-parameter signature
What fails: Test in apps/web/utils/risk.test.ts line 120 calls getActionRiskLevel(action, hasAutomation, { instructions }) but function now only accepts 2 parameters: getActionRiskLevel(action: RiskAction, rule: RuleConditions)
How to reproduce:
cd apps/web && npx tsc --noEmit --skipLibCheck utils/risk.test.tsResult: TypeScript compilation error: error TS2554: Expected 2 arguments, but got 3.
Expected: Should compile without errors after removing the middle hasAutomation parameter from the test call
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 26 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/prisma/schema.prisma">
<violation number="1" location="apps/web/prisma/schema.prisma:378">
The new comment marks `automate` as unused and claims all rules are always automated, but rule creation still toggles this flag via `shouldAutomate` for risky cases, so the comment is misleading.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
elie222
changed the base branch from
cursor/implement-mcp-integration-system-cc46
to
main
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/components/email-list/EmailPanel.tsx (1)
31-31: Consider inlining the plan check.The
planvariable is only used once at line 68. You could simplify by usingrow.plan?.ruledirectly in the conditional, eliminating the intermediate variable.Apply this diff:
- const plan = row.plan; - return ( <div className="flex h-full flex-col overflow-y-hidden border-l border-border"> <div className="sticky border-b border-border p-4 md:flex md:items-center md:justify-between"> @@ -65,7 +63,7 @@ </div> </div> <div className="flex flex-1 flex-col overflow-y-auto"> - {plan?.rule && <PlanExplanation thread={row} provider={provider} />} + {row.plan?.rule && <PlanExplanation thread={row} provider={provider} />} <EmailThreadapps/web/components/email-list/PlanExplanation.tsx (1)
1-1: Consider migrating from deprecated capital-case package.The
capital-casepackage is deprecated, and maintainers recommend using thechange-caseumbrella package instead. While this doesn't block the current PR (as it's existing usage), consider planning a migration.Based on learnings.
Example migration:
-import { capitalCase } from "capital-case"; +import { capitalCase } from "change-case";
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (28)
apps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsx(1 hunks)apps/web/app/(app)/[emailAccountId]/assistant/AssistantTabs.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/CreatedRulesModal.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/Pending.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/automation/page.tsx(1 hunks)apps/web/app/(app)/[emailAccountId]/debug/rule-history/page.tsx(0 hunks)apps/web/app/api/resend/summary/route.ts(0 hunks)apps/web/app/api/rules/pending/route.ts(0 hunks)apps/web/app/api/threads/route.ts(0 hunks)apps/web/app/api/user/planned/route.ts(0 hunks)apps/web/components/ActionButtonsBulk.tsx(2 hunks)apps/web/components/email-list/EmailList.tsx(0 hunks)apps/web/components/email-list/EmailListItem.tsx(0 hunks)apps/web/components/email-list/EmailPanel.tsx(1 hunks)apps/web/components/email-list/PlanActions.tsx(0 hunks)apps/web/components/email-list/PlanExplanation.tsx(1 hunks)apps/web/prisma/migrations/20251001203533_convert_automate_false_to_disabled/migration.sql(1 hunks)apps/web/prisma/schema.prisma(3 hunks)apps/web/utils/actions/ai-rule.ts(0 hunks)apps/web/utils/ai/choose-rule/execute.ts(0 hunks)apps/web/utils/ai/choose-rule/run-rules.ts(3 hunks)apps/web/utils/risk.test.ts(7 hunks)apps/web/utils/risk.ts(3 hunks)apps/web/utils/rule/rule.ts(1 hunks)packages/resend/emails/summary.tsx(0 hunks)version.txt(1 hunks)
💤 Files with no reviewable changes (16)
- apps/web/app/(app)/[emailAccountId]/assistant/CreatedRulesModal.tsx
- apps/web/app/api/rules/pending/route.ts
- apps/web/app/(app)/[emailAccountId]/assistant/AssistantTabs.tsx
- apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx
- apps/web/app/api/threads/route.ts
- apps/web/app/api/resend/summary/route.ts
- packages/resend/emails/summary.tsx
- apps/web/app/(app)/[emailAccountId]/assistant/Pending.tsx
- apps/web/app/(app)/[emailAccountId]/debug/rule-history/page.tsx
- apps/web/components/email-list/EmailListItem.tsx
- apps/web/app/api/user/planned/route.ts
- apps/web/components/email-list/PlanActions.tsx
- apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx
- apps/web/utils/actions/ai-rule.ts
- apps/web/components/email-list/EmailList.tsx
- apps/web/utils/ai/choose-rule/execute.ts
🧰 Additional context used
📓 Path-based instructions (25)
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/prisma/migrations/20251001203533_convert_automate_false_to_disabled/migration.sqlapps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/prisma/schema.prismaapps/web/components/email-list/EmailPanel.tsxapps/web/utils/rule/rule.tsapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/utils/risk.test.tsversion.txtapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.tsapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/prisma/migrations/20251001203533_convert_automate_false_to_disabled/migration.sqlapps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/prisma/schema.prismaapps/web/components/email-list/EmailPanel.tsxapps/web/utils/rule/rule.tsapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/utils/risk.test.tsversion.txtapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.tsapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/components/email-list/EmailPanel.tsxapps/web/utils/rule/rule.tsapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/utils/risk.test.tsapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.tsapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/components/email-list/EmailPanel.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/components/email-list/EmailPanel.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/components/email-list/EmailPanel.tsxapps/web/utils/rule/rule.tsapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/utils/risk.test.tsapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.tsapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
apps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsx
apps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsx
apps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/components/email-list/EmailPanel.tsxapps/web/utils/rule/rule.tsapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/utils/risk.test.tsapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.tsapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/components/email-list/EmailPanel.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(app)/[emailAccountId]/automation/page.tsxapps/web/components/email-list/EmailPanel.tsxapps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsxapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsxapps/web/prisma/schema.prisma
📄 CodeRabbit inference engine (.cursor/rules/prisma.mdc)
The Prisma schema file must be located at
apps/web/prisma/schema.prismaFiles:
apps/web/prisma/schema.prismaapps/web/components/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use React Hook Form with Zod validation for form handling
Use the
LoadingContentcomponent to handle loading and error states consistently in data-fetching components.Use PascalCase for components (e.g.
components/Button.tsx)Files:
apps/web/components/email-list/EmailPanel.tsxapps/web/components/ActionButtonsBulk.tsxapps/web/components/email-list/PlanExplanation.tsxapps/web/components/!(ui)/**
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
All other components are in
components/Files:
apps/web/components/email-list/EmailPanel.tsxapps/web/components/email-list/PlanExplanation.tsx**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/utils/rule/rule.tsapps/web/utils/risk.test.tsapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.tsapps/web/utils/**
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Create utility functions in
utils/folder for reusable logicFiles:
apps/web/utils/rule/rule.tsapps/web/utils/risk.test.tsapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.tsapps/web/utils/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle sizeFiles:
apps/web/utils/rule/rule.tsapps/web/utils/risk.test.tsapps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/risk.ts**/*.test.{ts,js}
📄 CodeRabbit inference engine (.cursor/rules/security.mdc)
Include security tests in your test suites to verify authentication, authorization, and error handling.
Files:
apps/web/utils/risk.test.ts**/*.{test,spec}.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{test,spec}.{js,jsx,ts,tsx}: Don't use export or module.exports in test files.
Don't use focused tests.
Don't use disabled tests.
Make sure the assertion function, like expect, is placed inside an it() function call.
Don't nest describe() blocks too deeply in test files.
Don't use focused tests.
Don't use disabled tests.
Don't use export or module.exports in test files.Files:
apps/web/utils/risk.test.ts**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/testing.mdc)
**/*.test.{ts,tsx}: Use Vitest (vitest) as the testing framework
Colocate tests next to the file under test (e.g., dir/format.ts with dir/format.test.ts)
In tests, mock theserver-onlymodule withvi.mock("server-only", () => ({}));
When testing code that uses Prisma, mock it withvi.mock("@/utils/prisma")and use the mock from@/utils/__mocks__/prisma
Use provided helpers for mocks: import{ getEmail, getEmailAccount, getRule }from@/__tests__/helpers
Each test should be independent
Use descriptive test names
Mock external dependencies in tests
Clean up mocks between tests (e.g.,vi.clearAllMocks()inbeforeEach)
Avoid testing implementation details; focus on observable behavior
Do not mock the LoggerFiles:
apps/web/utils/risk.test.tsapps/web/utils/ai/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/llm.mdc)
apps/web/utils/ai/**/*.{ts,tsx}: Place main LLM feature implementations under apps/web/utils/ai/
LLM feature functions should follow the provided TypeScript pattern (separate system/user prompts, use createGenerateObject, Zod schema validation, early validation, return result.object)
Keep system prompts and user prompts separate
System prompt should define the LLM's role and task specifications
User prompt should contain the actual data and context
Always define a Zod schema for response validation
Make Zod schemas as specific as possible to guide LLM output
Use descriptive scoped loggers for each feature
Log inputs and outputs with appropriate log levels and include relevant context
Implement early returns for invalid inputs
Use proper error types and logging for failures
Implement fallbacks for AI failures
Add retry logic for transient failures using withRetry
Use XML-like tags to structure data in prompts
Remove excessive whitespace and truncate long inputs in prompts
Format prompt data consistently across similar functions
Use TypeScript types for all parameters and return values in LLM features
Define clear interfaces for complex input/output structures in LLM featuresFiles:
apps/web/utils/ai/choose-rule/run-rules.tsapps/web/utils/{ai,llms}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/llm.mdc)
Keep related AI functions co-located and extract common patterns into utilities; document complex AI logic with clear comments
Files:
apps/web/utils/ai/choose-rule/run-rules.ts🧬 Code graph analysis (5)
apps/web/app/(app)/[emailAccountId]/automation/page.tsx (1)
apps/web/components/TabSelect.tsx (1)
TabSelect(44-100)apps/web/components/email-list/EmailPanel.tsx (1)
apps/web/components/email-list/PlanExplanation.tsx (1)
PlanExplanation(7-47)apps/web/utils/rule/rule.ts (1)
apps/web/utils/risk.ts (1)
getActionRiskLevel(24-103)apps/web/utils/risk.test.ts (1)
apps/web/utils/risk.ts (1)
getActionRiskLevel(24-103)apps/web/utils/risk.ts (1)
apps/web/utils/condition.ts (2)
isAIRule(33-37)RuleConditions(16-31)🔇 Additional comments (10)
version.txt (1)
1-1: Version bump looks good.v2.13.1 aligns with the release context; nothing else to flag here.
apps/web/app/(app)/[emailAccountId]/assistant/AddRuleDialog.tsx (1)
14-16: Width adjustment looks good.The expanded dialog width aligns with the broader pending-rule cleanup and should give RulesPrompt more breathing room. No issues spotted.
apps/web/components/ActionButtonsBulk.tsx (3)
4-4: LGTM! Import cleanup aligns with feature removal.The removal of
CheckCircleIconandXCircleIconimports is correct and consistent with the elimination of approve/reject actions from the component.
6-13: LGTM! Simplified props interface.The props interface correctly reflects the removal of approval/rejection functionality, maintaining only the three core actions. The naming convention is consistent and follows React patterns.
23-54: LGTM! Correct memoization and button configuration.The
useMemoimplementation is correct:
- All dependencies are properly listed in the dependency array (line 53)
- Button definitions are clean with appropriate loading states and accessibility attributes
- The three-button structure aligns with the simplified feature set
apps/web/components/email-list/EmailPanel.tsx (1)
68-68: LGTM! Simplified PlanExplanation invocation aligns with pending rules removal.The change correctly simplifies the PlanExplanation component call to pass only the required
threadandproviderprops, removing the plan execution hooks that are no longer needed.apps/web/components/email-list/PlanExplanation.tsx (1)
7-11: LGTM! Clean simplification of component surface.The prop signature change correctly removes the plan execution props (executingPlan, rejectingPlan, executePlan, rejectPlan) and simplifies the component to display-only functionality. The guard clauses appropriately handle null cases.
apps/web/app/(app)/[emailAccountId]/automation/page.tsx (1)
100-103: LGTM! Clean removal of pending tab logic.The simplification correctly removes the
Suspenseboundary andhasPendingRuleconditional logic, directly renderingTabSelectwith the simplified tab options. Theselectedprop correctly defaults to"rules"and navigation is handled viahrefin the tab options.apps/web/utils/ai/choose-rule/run-rules.ts (2)
250-251: LGTM! Correct alignment with pending feature removal.Setting
automated: trueandstatus: ExecutedRuleStatus.APPLYINGby default correctly reflects that all rules now execute immediately without requiring approval. The comment clearly documents this behavioral change from the previousPENDINGstatus.
160-179: APPLIED status transition fully implemented
- executeAct (apps/web/utils/ai/choose-rule/execute.ts) updates
ExecutedRuleStatus.APPLIED- checkAndCompleteExecutedRule (apps/web/utils/scheduled-actions/executor.ts) updates
ExecutedRuleStatus.APPLIED
No further action required.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
apps/web/__tests__/helpers.ts(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/create/examples.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/rule/create/page.tsx(0 hunks)apps/web/prisma/migrations/20251003000636_default_rule_automate/migration.sql(1 hunks)apps/web/prisma/schema.prisma(3 hunks)apps/web/utils/actions/rule.ts(0 hunks)apps/web/utils/actions/rule.validation.ts(0 hunks)apps/web/utils/ai/assistant/chat.ts(0 hunks)apps/web/utils/rule/rule.ts(3 hunks)
💤 Files with no reviewable changes (9)
- apps/web/tests/helpers.ts
- apps/web/utils/ai/assistant/chat.ts
- apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx
- apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx
- apps/web/app/(app)/[emailAccountId]/assistant/rule/create/page.tsx
- apps/web/utils/actions/rule.validation.ts
- apps/web/utils/actions/rule.ts
- apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
- apps/web/app/(app)/[emailAccountId]/assistant/create/examples.tsx
🧰 Additional context used
📓 Path-based instructions (9)
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/prisma/migrations/20251003000636_default_rule_automate/migration.sqlapps/web/utils/rule/rule.tsapps/web/prisma/schema.prisma
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/prisma/migrations/20251003000636_default_rule_automate/migration.sqlapps/web/utils/rule/rule.tsapps/web/prisma/schema.prisma
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/utils/rule/rule.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod
Files:
apps/web/utils/rule/rule.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/utils/rule/rule.ts
apps/web/utils/**
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Create utility functions in
utils/folder for reusable logic
Files:
apps/web/utils/rule/rule.ts
apps/web/utils/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size
Files:
apps/web/utils/rule/rule.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/utils/rule/rule.ts
apps/web/prisma/schema.prisma
📄 CodeRabbit inference engine (.cursor/rules/prisma.mdc)
The Prisma schema file must be located at
apps/web/prisma/schema.prisma
Files:
apps/web/prisma/schema.prisma
🧬 Code graph analysis (1)
apps/web/utils/rule/rule.ts (1)
apps/web/utils/risk.ts (1)
getActionRiskLevel(24-103)
🔇 Additional comments (3)
apps/web/utils/rule/rule.ts (3)
175-185: LGTM! Field rename aligns with PR objectives.The rename from
automatetoenabledis consistent with removing the pending rules feature and treating rules as either enabled or disabled. The action mapping logic is correct.
297-308: LGTM! Function rename and early exit logic are correct.The rename from
shouldAutomatetoshouldEnablealigns with the PR objectives. The early exit conditions properly prevent enablement of example rules.
321-322: LGTM! Logic correctly disables non-low-risk rules.The comment update is consistent with the function rename, and the logic correctly ensures that rules are only enabled when ALL actions have low risk. Any action with medium, high, or very high risk will cause the function to return false, disabling the rule. This addresses the concern from the previous review about high-risk rules remaining enabled.
| const riskLevels = actions.map( | ||
| (action) => getActionRiskLevel(action, false, {}).level, | ||
| (action) => getActionRiskLevel(action, {}).level, | ||
| ); | ||
| // Only automate if all actions are low risk | ||
| // User can manually enable in other cases | ||
| // Only enable if all actions are low risk | ||
| return riskLevels.every((level) => level === "low"); |
There was a problem hiding this comment.
Pass rule conditions instead of empty object to getActionRiskLevel.
The function passes {} as the RuleConditions parameter to getActionRiskLevel. According to the function signature in apps/web/utils/risk.ts (lines 23-28), it expects actual rule conditions and internally calls isAIRule(rule) (line 58), which may not work correctly with an empty object.
Since the rule parameter (line 298) contains the necessary condition information, extract and pass the relevant fields.
- const riskLevels = actions.map(
- (action) => getActionRiskLevel(action, {}).level,
- );
+ const riskLevels = actions.map(
+ (action) => getActionRiskLevel(action, {
+ aiInstructions: rule.condition.aiInstructions,
+ from: rule.condition.static?.from,
+ to: rule.condition.static?.to,
+ subject: rule.condition.static?.subject,
+ }).level,
+ );📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const riskLevels = actions.map( | |
| (action) => getActionRiskLevel(action, false, {}).level, | |
| (action) => getActionRiskLevel(action, {}).level, | |
| ); | |
| // Only automate if all actions are low risk | |
| // User can manually enable in other cases | |
| // Only enable if all actions are low risk | |
| return riskLevels.every((level) => level === "low"); | |
| const riskLevels = actions.map( | |
| (action) => | |
| getActionRiskLevel(action, { | |
| aiInstructions: rule.condition.aiInstructions, | |
| from: rule.condition.static?.from, | |
| to: rule.condition.static?.to, | |
| subject: rule.condition.static?.subject, | |
| }).level, | |
| ); | |
| // Only enable if all actions are low risk | |
| return riskLevels.every((level) => level === "low"); |
🤖 Prompt for AI Agents
In apps/web/utils/rule/rule.ts around lines 318 to 322, the call to
getActionRiskLevel currently passes an empty object for RuleConditions; replace
that with the actual rule conditions from the surrounding `rule` parameter
(e.g., pass rule.conditions or construct the RuleConditions object from fields
on `rule` that hold condition data) so getActionRiskLevel receives the proper
context; update the actions.map call to forward those extracted condition fields
to getActionRiskLevel and ensure types align with the RuleConditions signature.
1 participant
Summary by CodeRabbit