Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds Loops contact update utilities and integrates company size updating into onboarding. The onboarding action now accepts a logger, persists answers, and attempts a company size update in parallel with error logging. Version bumped to v2.9.43. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant W as Web App (onboarding action)
participant DB as User Store
participant L as Loops API
U->>W: Submit onboarding answers
rect rgba(200,230,255,0.2)
note over W: Save answers
W->>DB: Update user (onboardingAnswers, derived fields)
DB-->>W: Result
end
par Intended external update
note over W: Update company size (if provided)
W->>L: updateContactCompanySize(email, companySize)
alt Success
L-->>W: { success: true }
else Failure
L-->>W: { success: false }
W->>W: logger.error(...)
end
and Parallel join
note over W: Promise.all([...])
end
sequenceDiagram
autonumber
participant C as Caller
participant LP as updateContactProperty
participant LC as getLoopsClient
participant L as Loops Client
C->>LP: (email, { companySize })
LP->>LC: getLoopsClient()
alt Client unavailable
LC-->>LP: null/undefined
LP-->>C: { success: false }
else Client available
LC-->>LP: L
LP->>L: updateContact({ email, properties })
L-->>LP: { success: boolean }
LP-->>C: { success: boolean }
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/utils/actions/onboarding.ts (1)
111-122: Select email once to avoid an extra DB read and feed Loops.
Select- const userPromise = prisma.user.update({ + const userPromise = prisma.user.update({ where: { id: userId }, data: { onboardingAnswers: { surveyId, questions, answers }, surveyFeatures: extractedAnswers.surveyFeatures, surveyRole: extractedAnswers.surveyRole, surveyGoal: extractedAnswers.surveyGoal, surveyCompanySize: extractedAnswers.surveyCompanySize, surveySource: extractedAnswers.surveySource, surveyImprovements: extractedAnswers.surveyImprovements, - }, - }); + }, + select: { email: true }, + });
🧹 Nitpick comments (2)
packages/loops/src/loops.ts (2)
101-113: Helper is fine; keep the return shape consistent.
Looks good. Consider markingpropertiesasReadonly<Record<string, string | number | boolean>>to prevent accidental mutation, but non-blocking.
115-121: Export explicit return type for API stability.
Add the explicit Promise type to the exported function.-export async function updateContactCompanySize( +export async function updateContactCompanySize( email: string, companySize: number, -) { - return updateContactProperty(email, { companySize }); -} +): Promise<{ success: boolean }> { + return updateContactProperty(email, { companySize }); +}
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/web/utils/actions/onboarding.ts(4 hunks)packages/loops/src/loops.ts(1 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
version.txtpackages/loops/src/loops.tsapps/web/utils/actions/onboarding.ts
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
version.txtpackages/loops/src/loops.tsapps/web/utils/actions/onboarding.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod
Files:
packages/loops/src/loops.tsapps/web/utils/actions/onboarding.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
packages/loops/src/loops.tsapps/web/utils/actions/onboarding.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
packages/loops/src/loops.tsapps/web/utils/actions/onboarding.ts
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/utils/actions/onboarding.ts
apps/web/utils/actions/**/*.ts
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/utils/actions/**/*.ts: Use server actions for all mutations (create/update/delete operations)
next-safe-actionprovides centralized error handling
Use Zod schemas for validation on both client and server
UserevalidatePathin server actions for cache invalidation
apps/web/utils/actions/**/*.ts: Use server actions (withnext-safe-action) for all mutations (create/update/delete operations); do NOT use POST API routes for mutations.
UserevalidatePathin server actions to invalidate cache after mutations.
Files:
apps/web/utils/actions/onboarding.ts
apps/web/utils/actions/*.ts
📄 CodeRabbit inference engine (.cursor/rules/server-actions.mdc)
apps/web/utils/actions/*.ts: Implement all server actions using thenext-safe-actionlibrary for type safety, input validation, context management, and error handling. Refer toapps/web/utils/actions/safe-action.tsfor client definitions (actionClient,actionClientUser,adminActionClient).
UseactionClientUserwhen only authenticated user context (userId) is needed.
UseactionClientwhen both authenticated user context and a specificemailAccountIdare needed. TheemailAccountIdmust be bound when calling the action from the client.
UseadminActionClientfor actions restricted to admin users.
Access necessary context (likeuserId,emailAccountId, etc.) provided by the safe action client via thectxobject in the.action()handler.
Server Actions are strictly for mutations (operations that change data, e.g., creating, updating, deleting). Do NOT use Server Actions for data fetching (GET operations). For data fetching, use dedicated GET API Routes combined with SWR Hooks.
UseSafeErrorfor expected/handled errors within actions if needed.next-safe-actionprovides centralized error handling.
Use the.metadata({ name: "actionName" })method to provide a meaningful name for monitoring. Sentry instrumentation is automatically applied viawithServerActionInstrumentationwithin the safe action clients.
If an action modifies data displayed elsewhere, userevalidatePathorrevalidateTagfromnext/cachewithin the action handler as needed.Server action files must start with
use server
Files:
apps/web/utils/actions/onboarding.ts
apps/web/utils/**
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Create utility functions in
utils/folder for reusable logic
Files:
apps/web/utils/actions/onboarding.ts
apps/web/utils/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size
Files:
apps/web/utils/actions/onboarding.ts
🧬 Code graph analysis (1)
apps/web/utils/actions/onboarding.ts (1)
packages/loops/src/loops.ts (1)
updateContactCompanySize(115-120)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🔇 Additional comments (2)
version.txt (1)
1-1: Version bump looks good.
No issues. Matches PR intent.apps/web/utils/actions/onboarding.ts (1)
26-26: Verify logger is present in ctx.
EnsureactionClientUserprovidesloggerinctx. If not, this destructure will throw.
| await Promise.all([ | ||
| userPromise, | ||
| async () => { | ||
| if (extractedAnswers.surveyCompanySize) { | ||
| updateContactCompanySize( | ||
| userId, | ||
| extractedAnswers.surveyCompanySize, | ||
| ).catch((error) => { | ||
| logger.error("Error updating company size", { error }); | ||
| }); | ||
| } | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
Company size update never runs (async fn not invoked) and wrong identifier used.
- The async function is passed to
Promise.allwithout invocation, so it never executes. updateContactCompanySizeexpects an email, butuserIdis passed.- Also log when
success === false, not only on thrown errors.
Apply these changes:
- await Promise.all([
- userPromise,
- async () => {
- if (extractedAnswers.surveyCompanySize) {
- updateContactCompanySize(
- userId,
- extractedAnswers.surveyCompanySize,
- ).catch((error) => {
- logger.error("Error updating company size", { error });
- });
- }
- },
- ]);
+ await Promise.all([
+ userPromise,
+ (async () => {
+ const size = extractedAnswers.surveyCompanySize;
+ if (typeof size !== "number" || !Number.isFinite(size)) return;
+ const { email } = await userPromise; // from select below
+ if (!email) return;
+ try {
+ const resp = await updateContactCompanySize(email, size);
+ if (!resp.success) {
+ logger.error("Loops updateContactCompanySize returned success=false", { userId, email, companySize: size });
+ }
+ } catch (error) {
+ logger.error("Error updating company size", { error, userId, email, companySize: size });
+ }
+ })(),
+ ]);Additionally, if any UI depends on these fields, consider revalidatePath here.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| await Promise.all([ | |
| userPromise, | |
| async () => { | |
| if (extractedAnswers.surveyCompanySize) { | |
| updateContactCompanySize( | |
| userId, | |
| extractedAnswers.surveyCompanySize, | |
| ).catch((error) => { | |
| logger.error("Error updating company size", { error }); | |
| }); | |
| } | |
| }, | |
| ]); | |
| await Promise.all([ | |
| userPromise, | |
| (async () => { | |
| const size = extractedAnswers.surveyCompanySize; | |
| if (typeof size !== "number" || !Number.isFinite(size)) return; | |
| const { email } = await userPromise; // from select below | |
| if (!email) return; | |
| try { | |
| const resp = await updateContactCompanySize(email, size); | |
| if (!resp.success) { | |
| logger.error("Loops updateContactCompanySize returned success=false", { userId, email, companySize: size }); | |
| } | |
| } catch (error) { | |
| logger.error("Error updating company size", { error, userId, email, companySize: size }); | |
| } | |
| })(), | |
| ]); |
🤖 Prompt for AI Agents
In apps/web/utils/actions/onboarding.ts around lines 124 to 136, the inline
async function is being passed to Promise.all without invocation and thus never
runs, updateContactCompanySize is called with userId but expects an email, and
failures where the API returns success === false are not logged; fix by
replacing the array entry with an invoked async function (e.g., immediately
executed async arrow), call updateContactCompanySize with the user's email (not
userId), await its result and check the returned success flag and log an error
when success === false as well as catching thrown errors, and if any UI depends
on the updated fields call revalidatePath for the affected route after a
successful update.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="apps/web/utils/actions/onboarding.ts">
<violation number="1" location="apps/web/utils/actions/onboarding.ts:126">
The async function is being passed to Promise.all without being invoked, so the update logic never runs. Pass a promise to Promise.all by immediately invoking the async arrow or by creating a promise and including that instead.</violation>
<violation number="2" location="apps/web/utils/actions/onboarding.ts:129">
updateContactCompanySize expects an email address, but userId is passed here. Use the user’s email (e.g., from the updated user record) to ensure the correct contact is updated.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| async () => { | ||
| if (extractedAnswers.surveyCompanySize) { | ||
| updateContactCompanySize( | ||
| userId, |
There was a problem hiding this comment.
updateContactCompanySize expects an email address, but userId is passed here. Use the user’s email (e.g., from the updated user record) to ensure the correct contact is updated.
Prompt for AI agents
Address the following comment on apps/web/utils/actions/onboarding.ts at line 129:
<comment>updateContactCompanySize expects an email address, but userId is passed here. Use the user’s email (e.g., from the updated user record) to ensure the correct contact is updated.</comment>
<file context>
@@ -120,6 +120,20 @@ export const saveOnboardingAnswersAction = actionClientUser
+ async () => {
+ if (extractedAnswers.surveyCompanySize) {
+ updateContactCompanySize(
+ userId,
+ extractedAnswers.surveyCompanySize,
+ ).catch((error) => {
</file context>
|
|
||
| await Promise.all([ | ||
| userPromise, | ||
| async () => { |
There was a problem hiding this comment.
The async function is being passed to Promise.all without being invoked, so the update logic never runs. Pass a promise to Promise.all by immediately invoking the async arrow or by creating a promise and including that instead.
Prompt for AI agents
Address the following comment on apps/web/utils/actions/onboarding.ts at line 126:
<comment>The async function is being passed to Promise.all without being invoked, so the update logic never runs. Pass a promise to Promise.all by immediately invoking the async arrow or by creating a promise and including that instead.</comment>
<file context>
@@ -120,6 +120,20 @@ export const saveOnboardingAnswersAction = actionClientUser
+
+ await Promise.all([
+ userPromise,
+ async () => {
+ if (extractedAnswers.surveyCompanySize) {
+ updateContactCompanySize(
</file context>
1 participant
Summary by CodeRabbit