Conversation
Co-authored-by: eliesteinbock <eliesteinbock@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
WalkthroughIntroduces a new feature-flag variant and hook for controlling the Welcome page’s Testimonial block. The page reads the variant via useWelcomeTestimonialVariant and conditionally renders the Testimonial only when the variant is "control". Public API additions are limited to the new type and hook in feature flags. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant P as WelcomeUpgradePage
participant H as useWelcomeTestimonialVariant
participant F as FeatureFlagService
U->>P: Navigate to page
P->>H: Get testimonial variant
H->>F: read("welcome-testimonial")
F-->>H: variant key or undefined
H-->>P: "control" or "hidden" (defaults to "control")
alt variant == "control"
P->>P: Render Testimonial block
else variant == "hidden"
P->>P: Omit Testimonial block
end
note over P: No public API change to page component
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/app/(landing)/welcome-upgrade/page.tsx (2)
17-21: Optional: avoid shipping testimonial code when variant hides it.Dynamically import the testimonial to trim the bundle for the "hidden" variant.
-import { ABTestimonial } from "@/components/PersonWithLogo"; +import dynamic from "next/dynamic"; +const ABTestimonial = dynamic( + () => + import("@/components/PersonWithLogo").then((m) => m.ABTestimonial), + { ssr: false }, +);
17-21: Guard against unexpected variant values (defensive).Today, an unknown truthy variant would hide the testimonial. Either sanitize in the hook (preferred; see separate comment) or gate on "!== 'hidden'" here.
- {testimonialVariant === "control" && ( + {testimonialVariant !== "hidden" && ( <div className="mt-20"> <Testimonial /> </div> )}
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/app/(landing)/welcome-upgrade/page.tsx(1 hunks)apps/web/hooks/useFeatureFlags.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (17)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/hooks/useFeatureFlags.ts
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsx
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/hooks/useFeatureFlags.ts
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/hooks/useFeatureFlags.ts
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/hooks/useFeatureFlags.ts
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/hooks/useFeatureFlags.ts
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(landing)/welcome-upgrade/page.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/hooks/**/*.ts
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use SWR for efficient data fetching and caching
apps/web/hooks/**/*.ts: Use SWR for client-side data fetching and caching.
Callmutate()after successful mutations to refresh SWR data on the client.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Call
mutate()after successful mutations to refresh dataFiles:
apps/web/hooks/useFeatureFlags.ts**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/hooks.mdc)
Place custom hooks in the
apps/web/hooks/directory.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/use*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/hooks.mdc)
apps/web/hooks/use*.{js,jsx,ts,tsx}: Name custom hooks with theuseprefix (e.g.,useAccounts.ts).
For fetching data from API endpoints in custom hooks, prefer usinguseSWR.
Create dedicated hooks for specific data types (e.g.,useAccounts,useLabels).
Custom hooks should encapsulate reusable stateful logic, especially for data fetching or complex UI interactions.
Keep custom hooks focused on a single responsibility.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/useFeatureFlags.ts
📄 CodeRabbit inference engine (.cursor/rules/posthog-feature-flags.mdc)
apps/web/hooks/useFeatureFlags.ts: All feature flag hooks should be defined in apps/web/hooks/useFeatureFlags.ts
Use kebab-case for feature flag keys (e.g., 'inbox-cleaner', 'pricing-options-2')
Use 'use[FeatureName]Enabled' for boolean flag hook names and 'use[FeatureName]Variant' for variant flag hook names
Always define types for variant flags
Always provide a default/control fallback for variant flags
Keep all feature flag hooks centralized in useFeatureFlags.tsFiles:
apps/web/hooks/useFeatureFlags.ts🧠 Learnings (6)
📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Use 'use[FeatureName]Enabled' for boolean flag hook names and 'use[FeatureName]Variant' for variant flag hook namesApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : All feature flag hooks should be defined in apps/web/hooks/useFeatureFlags.tsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Always define types for variant flagsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Keep all feature flag hooks centralized in useFeatureFlags.tsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Always provide a default/control fallback for variant flagsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Use kebab-case for feature flag keys (e.g., 'inbox-cleaner', 'pricing-options-2')Applied to files:
apps/web/hooks/useFeatureFlags.ts🧬 Code graph analysis (1)
apps/web/app/(landing)/welcome-upgrade/page.tsx (1)
apps/web/hooks/useFeatureFlags.ts (1)
useWelcomeTestimonialVariant(61-66)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🔇 Additional comments (3)
apps/web/app/(landing)/welcome-upgrade/page.tsx (2)
1-1: Correctly marked as a client component.Needed for PostHog hooks. LGTM.
8-12: Uses centralized feature‑flag hook via path alias.Import path and hook name conform to guidelines; defaulting to "control" aligns with flag policy.
apps/web/hooks/useFeatureFlags.ts (1)
59-66: Flag naming, location, and default look good.Kebab-case key, centralized hook, and "control" fallback match our rules.
Please confirm the PostHog flag has exactly two variants spelled: control, hidden.
| export type WelcomeTestimonialVariant = "control" | "hidden"; | ||
|
|
||
| export function useWelcomeTestimonialVariant() { | ||
| return ( | ||
| (useFeatureFlagVariantKey("welcome-testimonial") as WelcomeTestimonialVariant) || | ||
| "control" | ||
| ); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Harden variant handling with typed constants and runtime validation.
Prevents accidental unknown variants from flowing through while keeping the default "control".
-export type WelcomeTestimonialVariant = "control" | "hidden";
-
-export function useWelcomeTestimonialVariant() {
- return (
- (useFeatureFlagVariantKey("welcome-testimonial") as WelcomeTestimonialVariant) ||
- "control"
- );
-}
+const WELCOME_TESTIMONIAL_FLAG = "welcome-testimonial" as const;
+const WELCOME_TESTIMONIAL_VARIANTS = ["control", "hidden"] as const;
+export type WelcomeTestimonialVariant =
+ (typeof WELCOME_TESTIMONIAL_VARIANTS)[number];
+
+export function useWelcomeTestimonialVariant(): WelcomeTestimonialVariant {
+ const v = useFeatureFlagVariantKey(WELCOME_TESTIMONIAL_FLAG);
+ return (WELCOME_TESTIMONIAL_VARIANTS as readonly string[]).includes(
+ (v as string) ?? "",
+ )
+ ? (v as WelcomeTestimonialVariant)
+ : "control";
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export type WelcomeTestimonialVariant = "control" | "hidden"; | |
| export function useWelcomeTestimonialVariant() { | |
| return ( | |
| (useFeatureFlagVariantKey("welcome-testimonial") as WelcomeTestimonialVariant) || | |
| "control" | |
| ); | |
| } | |
| const WELCOME_TESTIMONIAL_FLAG = "welcome-testimonial" as const; | |
| const WELCOME_TESTIMONIAL_VARIANTS = ["control", "hidden"] as const; | |
| export type WelcomeTestimonialVariant = | |
| (typeof WELCOME_TESTIMONIAL_VARIANTS)[number]; | |
| export function useWelcomeTestimonialVariant(): WelcomeTestimonialVariant { | |
| const v = useFeatureFlagVariantKey(WELCOME_TESTIMONIAL_FLAG); | |
| return (WELCOME_TESTIMONIAL_VARIANTS as readonly string[]).includes( | |
| (v as string) ?? "", | |
| ) | |
| ? (v as WelcomeTestimonialVariant) | |
| : "control"; | |
| } |
🤖 Prompt for AI Agents
In apps/web/hooks/useFeatureFlags.ts around lines 59 to 66, the hook currently
casts the feature flag string to WelcomeTestimonialVariant which can allow
unknown values; change it to validate the runtime value against a typed list of
allowed variants (e.g., export a const array or set of ["control","hidden"] and
a corresponding type) and return "control" if the retrieved variant is not one
of those allowed values; remove the unsafe cast and perform an includes/check at
runtime so only known variants propagate and the default "control" is used for
anything else.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/app/(landing)/welcome-upgrade/page.tsx">
<violation number="1" location="apps/web/app/(landing)/welcome-upgrade/page.tsx:11">
Defaulting to 'control' can cause a flash of the testimonial for users in the 'hidden' variant before the flag loads, biasing results and causing layout shift; render nothing until the flag value is resolved.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| import { useWelcomeTestimonialVariant } from "@/hooks/useFeatureFlags"; | ||
|
|
||
| export default function WelcomeUpgradePage() { | ||
| const testimonialVariant = useWelcomeTestimonialVariant(); |
There was a problem hiding this comment.
Defaulting to 'control' can cause a flash of the testimonial for users in the 'hidden' variant before the flag loads, biasing results and causing layout shift; render nothing until the flag value is resolved.
Prompt for AI agents
Address the following comment on apps/web/app/(landing)/welcome-upgrade/page.tsx at line 11:
<comment>Defaulting to 'control' can cause a flash of the testimonial for users in the 'hidden' variant before the flag loads, biasing results and causing layout shift; render nothing until the flag value is resolved.</comment>
<file context>
@@ -1,17 +1,24 @@
+import { useWelcomeTestimonialVariant } from "@/hooks/useFeatureFlags";
export default function WelcomeUpgradePage() {
+ const testimonialVariant = useWelcomeTestimonialVariant();
+
return (
</file context>
3 participants
Add an A/B test to conditionally show/hide the testimonial on the welcome upgrade page to measure its impact on conversions.
This test introduces a
welcome-testimonialfeature flag with 'control' (show testimonial) and 'hidden' (hide testimonial) variants.Summary by CodeRabbit