Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe UI switches from navigation-based rule viewing to an inline dialog via a new useRuleDialog hook. RuleCell props drop emailAccountId. Consumers (History, Pending) update accordingly. useAssistantNavigation is removed. Rules.tsx adjusts history links. HoverCard adds open/close delays. Minor cleanup and version bump. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant RuleCell as RuleCell
participant useRuleDialog as useRuleDialog()
participant Dialog as RuleDialogComponent
participant RuleDialog as RuleDialog
User->>RuleCell: Click "View Rule"
RuleCell->>useRuleDialog: ruleDialog.onOpen({ ruleId })
useRuleDialog-->>Dialog: isOpen=true, state={ ruleId }
Note right of Dialog: Wrapper supplies ruleId, isOpen, onClose (editMode=false)
Dialog->>RuleDialog: Render with props
RuleDialog-->>User: Display rule details modal
User->>Dialog: Close
Dialog->>useRuleDialog: onClose()
useRuleDialog-->>Dialog: isOpen=false
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Poem
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsx (1)
1-3: Add 'use client' — this file uses hooks and onClick.
Without it, Next.js will error when importing client hooks/components and event handlers.+ "use client"; + import Link from "next/link"; import { ExternalLinkIcon, EyeIcon } from "lucide-react";
🧹 Nitpick comments (4)
apps/web/components/HoverCard.tsx (1)
7-16: Make delays configurable with sensible defaults.
Avoid hard-coding; expose as props with defaults.Apply:
export function HoverCard(props: { children: React.ReactNode; content: React.ReactNode; className?: string; + openDelay?: number; + closeDelay?: number; }) { return ( - <HoverCardUi openDelay={100} closeDelay={100}> + <HoverCardUi + openDelay={props.openDelay ?? 100} + closeDelay={props.closeDelay ?? 100} + > <HoverCardTrigger asChild>{props.children}</HoverCardTrigger> <HoverCardContent className={props.className} align="start" side="right"> {props.content} </HoverCardContent> </HoverCardUi> ); }apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx (1)
386-401: Add rel to external target for safety.
When opening in a new tab, include rel to prevent window.opener leaks.<Link href={ isColdEmailBlocker ? prefixPath( emailAccountId, "/cold-email-blocker", ) : prefixPath( emailAccountId, `/automation?tab=history&ruleId=${rule.id}`, ) } target={ isColdEmailBlocker ? "_blank" : undefined } + rel={isColdEmailBlocker ? "noopener noreferrer" : undefined} >apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx (1)
58-59: Handle onOpenChange explicitly.
Avoid calling onClose when framework invokes onOpenChange(true).- <Dialog open={isOpen} onOpenChange={onClose}> + <Dialog + open={isOpen} + onOpenChange={(open) => { + if (!open) onClose(); + }} + >apps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsx (1)
141-142: Consider a single shared dialog per table to reduce mounts.
Rendering one dialog instance per row can be heavy; hoist a single dialog to the table/page and pass the selected ruleId.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
apps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsx(4 hunks)apps/web/app/(app)/[emailAccountId]/assistant/FixWithChat.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/History.tsx(1 hunks)apps/web/app/(app)/[emailAccountId]/assistant/Pending.tsx(0 hunks)apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx(3 hunks)apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx(1 hunks)apps/web/components/HoverCard.tsx(1 hunks)apps/web/hooks/useAssistantNavigation.ts(0 hunks)version.txt(1 hunks)
💤 Files with no reviewable changes (3)
- apps/web/app/(app)/[emailAccountId]/assistant/FixWithChat.tsx
- apps/web/hooks/useAssistantNavigation.ts
- apps/web/app/(app)/[emailAccountId]/assistant/Pending.tsx
🧰 Additional context used
📓 Path-based instructions (15)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsxversion.txt
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
apps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
apps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
apps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsxversion.txt
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsxapps/web/app/(app)/[emailAccountId]/assistant/History.tsxapps/web/components/HoverCard.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsxapps/web/components/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use React Hook Form with Zod validation for form handling
Use the
LoadingContentcomponent to handle loading and error states consistently in data-fetching components.Use PascalCase for components (e.g.
components/Button.tsx)Files:
apps/web/components/HoverCard.tsx🧠 Learnings (6)
📚 Learning: 2025-07-18T17:27:58.249Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/server-actions.mdc:0-0 Timestamp: 2025-07-18T17:27:58.249Z Learning: Applies to apps/web/utils/actions/*.ts : Use `actionClient` when both authenticated user context and a specific `emailAccountId` are needed. The `emailAccountId` must be bound when calling the action from the client.Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/History.tsx📚 Learning: 2025-07-18T15:07:00.269Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/page-structure.mdc:0-0 Timestamp: 2025-07-18T15:07:00.269Z Learning: Applies to apps/web/app/(app)/*/**/*.tsx : If you need to use onClick in a component, that component is a client component and file must start with 'use client'Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx📚 Learning: 2025-07-20T09:00:16.505Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/project-structure.mdc:0-0 Timestamp: 2025-07-20T09:00:16.505Z Learning: Applies to apps/web/app/**/*.tsx : Components with `onClick` must be client components with `use client` directiveApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx📚 Learning: 2025-07-19T17:50:22.078Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/ui-components.mdc:0-0 Timestamp: 2025-07-19T17:50:22.078Z Learning: Applies to components/**/*.tsx : Use the `LoadingContent` component to handle loading statesApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/*.tsx : Use `LoadingContent` component to handle loading and error states consistentlyApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx📚 Learning: 2025-07-18T15:05:16.146Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/fullstack-workflow.mdc:0-0 Timestamp: 2025-07-18T15:05:16.146Z Learning: Applies to apps/web/components/**/*.tsx : Use the `LoadingContent` component to handle loading and error states consistently in data-fetching components.Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx🧬 Code graph analysis (4)
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx (1)
apps/web/utils/path.ts (1)
prefixPath(1-4)apps/web/app/(app)/[emailAccountId]/assistant/History.tsx (1)
apps/web/providers/EmailAccountProvider.tsx (1)
useAccount(72-82)apps/web/app/(app)/[emailAccountId]/assistant/ExecutedRulesTable.tsx (1)
apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx (1)
useRuleDialog(25-40)apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx (1)
apps/web/hooks/useDialogState.ts (1)
useDialogState(8-32)🔇 Additional comments (6)
version.txt (1)
1-1: Version bump looks good.
No concerns.apps/web/components/HoverCard.tsx (1)
13-18: Confirm HoverCardUi supports openDelay/closeDelay.
If the underlying ui/hover-card export wasn’t updated, this will be a type/runtime error.apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx (1)
393-396: History link construction LGTM.
Using prefixPath with ruleId in the query aligns with the new per-account routing.apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx (2)
25-40: Reusable dialog hook looks solid.
Clean API and memoized component wrapper.
50-51: Avoid fetching when ruleId is empty.
Ensure useRule short-circuits (e.g., SWR key null) when ruleId is falsy to prevent unnecessary requests.apps/web/app/(app)/[emailAccountId]/assistant/History.tsx (1)
68-70: Prop cleanup LGTM.
Dropping emailAccountId from RuleCell usage is consistent with the new API.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| export function useRuleDialog() { | ||
| const ruleDialog = useDialogState<{ ruleId: string }>(); | ||
|
|
||
| const RuleDialogComponent = useCallback(() => { |
There was a problem hiding this comment.
Defining the component with useCallback tied to changing deps will remount the component on each change (e.g., toggling isOpen), potentially losing internal state; consider returning a memoized element instead or render RuleDialog directly with the returned state.
Prompt for AI agents
Address the following comment on apps/web/app/(app)/[emailAccountId]/assistant/RuleDialog.tsx at line 28:
<comment>Defining the component with useCallback tied to changing deps will remount the component on each change (e.g., toggling isOpen), potentially losing internal state; consider returning a memoized element instead or render RuleDialog directly with the returned state.</comment>
<file context>
@@ -20,6 +22,23 @@ interface RuleDialogProps {
+export function useRuleDialog() {
+ const ruleDialog = useDialogState<{ ruleId: string }>();
+
+ const RuleDialogComponent = useCallback(() => {
+ return (
+ <RuleDialog
</file context>
1 participant
Summary by CodeRabbit