Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Caution Review failedThe pull request is closed. WalkthroughRemoved per-email add‑on pricing from premium config and UIs; UI now omits dynamic extra‑email prices and shows a conditional "Contact Support" alert for business tiers. Updated config (removed priceAdditional/pricingAdditonalEmail), STRIPE old price IDs, and advanced marketing submodule; minor import adjustments. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant UI as Pricing UI
participant C as Premium Config
participant S as Support
U->>UI: Open Pricing or MultiAccount settings
UI->>C: Load tiers (priceAdditional removed)
C-->>UI: Tier data (price, ids, etc.)
alt Tier is BUSINESS_MONTHLY or BUSINESS_ANNUALLY
rect rgb(240,248,255)
UI-->>U: Show "Need multiple accounts? Contact Support" alert
U->>S: Click "Contact Support" -> open support channel
end
else Other tiers
UI-->>U: Show standard upgrade CTAs (no per-email add‑on price)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/app/(app)/premium/config.ts (1)
58-69: Remove active price IDs from oldPriceIds arraysThe duplicate check passed, but in apps/web/app/(app)/premium/config.ts the BASIC_MONTHLY tier’s
oldPriceIdsincludes its activepriceId(price_1RfeDLKGf8mwZWHn6UW8wJcY) and the BASIC_ANNUALLY tier’soldPriceIdsincludes its activepriceId(price_1RfeDLKGf8mwZWHn5kfC8gcM). Remove these entries sooldPriceIdsonly contains legacy IDs.
🧹 Nitpick comments (3)
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsx (1)
253-257: Use tier display names instead of capital-casing enum valuesCapital-casing
PremiumTier(e.g., COPILOT_MONTHLY → “Copilot Monthly”) can diverge from public-facing names (“Enterprise”, “Team”, “Individual”). Use thetiersconfig to resolve the display name, falling back tocapitalCaseonly if unknown.Apply within this range:
- description={`You are on the ${capitalCase( - premiumTier, - )} plan. You will be billed for each additional team member you add to your account.`} + description={`You are on the ${getTierDisplayName( + premiumTier, + )} plan. You will be billed for each additional team member you add to your account.`}Add outside the range (top-level helper + import):
// add alongside other imports import { tiers as premiumTiers } from "@/app/(app)/premium/config"; // add above ExtraSeatsAlert() function getTierDisplayName(tier: PremiumTier) { const match = premiumTiers.find( (t) => t.tiers.monthly === tier || t.tiers.annually === tier, ); return match?.name ?? capitalCase(tier); }apps/web/app/(app)/premium/Pricing.tsx (2)
113-129: Conditional “Contact Support” alert reads clearlyLogic and UX copy look good. Minor optional cleanup: you can tighten the condition with an includes check to reduce repetition.
- {userPremiumTier === "BUSINESS_MONTHLY" || - userPremiumTier === "BUSINESS_ANNUALLY" ? ( + {["BUSINESS_MONTHLY", "BUSINESS_ANNUALLY"].includes( + userPremiumTier as any, + ) ? ( <AlertWithButtonNote: If you want to keep strict typing without
any, define aconstarray typed asreadonly PremiumTier[]elsewhere and reference it here.
327-333: Avoid console in client code; surface and capture errors insteadReplace
console.errorwith user-visible feedback (you’re already usingtoastError) and optionally capture to your telemetry (e.g., Sentry) if configured.- } catch (error) { - console.error(error); + } catch (error) { + toastError({ + description: "Unexpected error. Please try again or contact support.", + }); } finally {
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsx(1 hunks)apps/web/app/(app)/premium/Pricing.tsx(2 hunks)apps/web/app/(app)/premium/config.ts(2 hunks)apps/web/app/(marketing)(1 hunks)
🧰 Additional context used
📓 Path-based instructions (15)
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(marketing)apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/premium/config.ts
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/app/(marketing)apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/premium/config.ts
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/app/(marketing)apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/premium/config.ts
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/premium/config.ts
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/premium/config.ts
apps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/premium/config.ts
apps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsx
apps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/premium/config.ts
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(app)/[emailAccountId]/settings/MultiAccountSection.tsxapps/web/app/(app)/premium/Pricing.tsx**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/app/(app)/premium/config.ts🧬 Code graph analysis (2)
apps/web/app/(app)/premium/Pricing.tsx (1)
apps/web/components/Button.tsx (1)
Button(60-87)apps/web/app/(app)/premium/config.ts (1)
apps/web/env.ts (1)
env(16-235)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Jit Security
🔇 Additional comments (2)
apps/web/app/(marketing) (1)
1-1: Ignore submodule-check — this is a Next.js route‐group folder, not a Git submodule
The change toapps/web/app/(marketing)updated the directory’s tree SHA (Next.js grouping), not a submodule gitlink. There is no .gitmodules entry and no CI submodule checkout is required.Likely an incorrect or invalid review comment.
apps/web/app/(app)/premium/Pricing.tsx (1)
14-15: Imports update looks goodType-only import for
Tierand narrowing totierskeeps the client bundle lean and aligns with the config changes.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
1 participant
Summary by CodeRabbit