Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughProvider-aware UI gating added to Early Access page; NavUser menu items reorganized and gated; SideNav gains account-aware Settings link and Premium item with icon/type adjustments; version bumped to v2.8.7. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant EarlyAccessPage
participant Account as useAccount()
participant Provider as isGoogleProvider()
User->>EarlyAccessPage: Navigate to /early-access
EarlyAccessPage->>Account: get account/provider
Account-->>EarlyAccessPage: provider
EarlyAccessPage->>Provider: check isGoogleProvider(provider)
alt provider is Google
EarlyAccessPage-->>User: Render Sender Categories Card + Mail (Beta) + Early Access Card
else provider is not Google
EarlyAccessPage-->>User: Render Early Access Card only
end
sequenceDiagram
autonumber
actor User
participant SideNav
participant Account as useAccount()
participant Router
User->>SideNav: View sidebar
SideNav->>Account: get emailAccountId
Account-->>SideNav: emailAccountId
SideNav-->>User: Render footer items\n- Premium (/premium)\n- Settings (/{emailAccountId}/settings)
User->>Router: Click Settings
Router-->>User: Navigate to account-scoped settings
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/components/SideNav.tsx (1)
178-190: Back link should be account-scoped.Current
href: "/automation"can lose account context.Apply:
- { - name: "Back", - href: "/automation", - icon: ArrowLeftIcon, - }, + { + name: "Back", + href: prefixPath(emailAccountId, "/automation"), + icon: ArrowLeftIcon, + },And update dependencies:
- }, [showMailNav], + }, [showMailNav, emailAccountId],
🧹 Nitpick comments (2)
apps/web/app/(app)/early-access/page.tsx (2)
1-1: Client page: OK, but consider keeping the page server and moving client-only logic to a child.Optional: to align with “pages are Server components” guidance, keep this page server and lift
useAccount()+ provider-gated cards into a small client child component.
13-18: Preserve account context in links (use prefixPath).Linking to
/smart-categoriesandprefixPath(emailAccountId, ...).Apply:
@@ -import { isGoogleProvider } from "@/utils/email/provider-types"; +import { isGoogleProvider } from "@/utils/email/provider-types"; +import { prefixPath } from "@/utils/path"; import { useAccount } from "@/providers/EmailAccountProvider"; @@ - const { provider } = useAccount(); + const { provider, emailAccountId } = useAccount(); @@ - <Button asChild> - <Link href="/smart-categories">Sender Categories</Link> - </Button> + <Button asChild> + <Link href={prefixPath(emailAccountId, "/smart-categories")}> + Sender Categories + </Link> + </Button> @@ - <Button asChild> - <Link href="/mail">Mail</Link> - </Button> + <Button asChild> + <Link href={prefixPath(emailAccountId, "/mail")}>Mail</Link> + </Button>Also applies to: 23-55
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
apps/web/app/(app)/early-access/page.tsx(2 hunks)apps/web/components/NavUser.tsx(1 hunks)apps/web/components/SideNav.tsx(5 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (16)
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
version.txtapps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
version.txtapps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
apps/web/components/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use React Hook Form with Zod validation for form handling
Use the
LoadingContentcomponent to handle loading and error states consistently in data-fetching components.Use PascalCase for components (e.g.
components/Button.tsx)
Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/components/SideNav.tsxapps/web/components/NavUser.tsxapps/web/app/(app)/early-access/page.tsxapps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(app)/early-access/page.tsxapps/web/app/(app)/*/page.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
apps/web/app/(app)/*/page.tsx: Create new pages at: apps/web/app/(app)/PAGE_NAME/page.tsx
Pages are Server components so you can load data into them directly
apps/web/app/(app)/*/page.tsx: Create new pages at:apps/web/app/(app)/PAGE_NAME/page.tsx
Pages are Server components for direct data loadingFiles:
apps/web/app/(app)/early-access/page.tsxapps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/early-access/page.tsxapps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/early-access/page.tsxapps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/early-access/page.tsxapps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirectiveFiles:
apps/web/app/(app)/early-access/page.tsx🧠 Learnings (4)
📚 Learning: 2025-07-18T17:27:58.249Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/server-actions.mdc:0-0 Timestamp: 2025-07-18T17:27:58.249Z Learning: Applies to apps/web/utils/actions/*.ts : Use `actionClient` when both authenticated user context and a specific `emailAccountId` are needed. The `emailAccountId` must be bound when calling the action from the client.Applied to files:
apps/web/components/SideNav.tsx📚 Learning: 2025-07-08T13:14:07.449Z
Learnt from: elie222 PR: elie222/inbox-zero#537 File: apps/web/app/(app)/[emailAccountId]/clean/onboarding/page.tsx:30-34 Timestamp: 2025-07-08T13:14:07.449Z Learning: The clean onboarding page in apps/web/app/(app)/[emailAccountId]/clean/onboarding/page.tsx is intentionally Gmail-specific and should show an error for non-Google email accounts rather than attempting to support multiple providers.Applied to files:
apps/web/app/(app)/early-access/page.tsx📚 Learning: 2025-07-20T09:00:16.505Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/project-structure.mdc:0-0 Timestamp: 2025-07-20T09:00:16.505Z Learning: Applies to apps/web/app/**/*.tsx : Components with `onClick` must be client components with `use client` directiveApplied to files:
apps/web/app/(app)/early-access/page.tsx📚 Learning: 2025-07-18T15:07:00.269Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/page-structure.mdc:0-0 Timestamp: 2025-07-18T15:07:00.269Z Learning: Applies to apps/web/app/(app)/*/**/*.tsx : If you need to use onClick in a component, that component is a client component and file must start with 'use client'Applied to files:
apps/web/app/(app)/early-access/page.tsx🧬 Code graph analysis (3)
apps/web/components/SideNav.tsx (2)
apps/web/providers/EmailAccountProvider.tsx (1)
useAccount(72-82)apps/web/utils/path.ts (1)
prefixPath(1-4)apps/web/components/NavUser.tsx (1)
apps/web/utils/path.ts (1)
prefixPath(1-4)apps/web/app/(app)/early-access/page.tsx (3)
apps/web/providers/EmailAccountProvider.tsx (1)
useAccount(72-82)apps/web/app/(app)/early-access/EarlyAccessFeatures.tsx (1)
EarlyAccessFeatures(22-78)apps/web/utils/email/provider-types.ts (1)
isGoogleProvider(1-3)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cursor Bugbot
🔇 Additional comments (5)
version.txt (1)
1-1: Version bump to v2.8.7 — LGTM.No code impact. Remember to tag the release and update changelog if applicable.
apps/web/components/SideNav.tsx (3)
239-245: Premium link in footer — LGTM.Simple, consistent placement in the sidebar footer.
246-252: Account-scoped Settings — LGTM.Correct use of
prefixPath(emailAccountId, "/settings").
232-237: Add rel attribute to external<Link>components
Prevent reverse tabnabbing when usingtarget="_blank".- <Link href="https://docs.getinboxzero.com" target="_blank"> + <Link href="https://docs.getinboxzero.com" target="_blank" rel="noopener noreferrer">Please verify no other
<Link>instances usetarget="_blank"withoutrel(e.g.rg -nP '<Link[^>]*target=["'\'']_blank["'\'']' apps/web/**/*.tsx).apps/web/components/NavUser.tsx (1)
134-139: Usage moved and account-scoped — LGTM.Good consolidation; the path uses
prefixPath.
| name: string; | ||
| href: string; | ||
| icon: LucideIcon | ((props: any) => React.ReactNode); | ||
| icon: LucideIcon | (() => React.ReactNode); |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Icon type is too restrictive; keep support for className props.
(() => React.ReactNode) prevents consumers from passing className (common for sizing). Prefer a component type with props.
Apply:
-type NavItem = {
+type NavItem = {
name: string;
href: string;
- icon: LucideIcon | (() => React.ReactNode);
+ icon: React.ComponentType<{ className?: string }>;
target?: "_blank";
count?: number;
hideInMail?: boolean;
};This remains compatible with LucideIcon and custom icons.
Run to confirm SideNavMenu passes className to icons:
🏁 Script executed:
#!/bin/bash
rg -nP -C2 'SideNavMenu.*icon|icon:.*=>|className="size-4"' -- apps/webLength of output: 23089
🏁 Script executed:
#!/bin/bash
file=$(find . -type f -name 'SideNavMenu.tsx')
echo "Inspecting file: $file"
sed -n '1,200p' "$file"Length of output: 1312
🏁 Script executed:
#!/bin/bash
# Locate and display the beginning of SideNav.tsx to verify NavItem definition and usage
file=$(find apps/web/components -type f -name SideNav.tsx)
echo "Inspecting file: $file"
sed -n '1,200p' "$file"Length of output: 5136
Broaden NavItem.icon signature and pass className in SideNavMenu
- Update the
NavItemtype in bothapps/web/components/SideNav.tsxandapps/web/components/SideNavMenu.tsxto
icon: React.ComponentType<{ className?: string }>; - In
apps/web/components/SideNavMenu.tsx, change the icon render from
<item.icon />
to
<item.icon className="size-4" />
so consumers can size viaclassName.
🤖 Prompt for AI Agents
In apps/web/components/SideNav.tsx around line 64 and
apps/web/components/SideNavMenu.tsx (where item.icon is rendered), the
NavItem.icon signature must be broadened and the icon should accept a className
for sizing: change the NavItem type in both files to icon: React.ComponentType<{
className?: string }>; and in SideNavMenu replace the current <item.icon />
render with <item.icon className="size-4" /> so consumers can control icon
sizing via className.
1 participant
Summary by CodeRabbit
New Features
Refactor
Chores