Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughIntroduces an optional examples array into the examples pipeline: components accept and pass examples to getExamplePrompts(provider, examples). RulesPromptNew renders an always-visible Examples panel (when examples exist) that inserts selections into the editor. RulesPrompt comments out the old Examples rendering. Version bumped to v2.7.9. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant RulesPromptNew as RulesPromptNew
participant Examples as ExamplesList
participant Editor as Rules Editor
participant Utils as getExamplePrompts()
Note over RulesPromptNew: Mount with provider and persona.examples
RulesPromptNew->>Examples: Render with {provider, examples[]}
Examples->>Utils: getExamplePrompts(provider, examples[])
Utils-->>Examples: Prompt list (processed)
Examples-->>RulesPromptNew: Display example items
User->>Examples: Click example
Examples-->>RulesPromptNew: onSelect(example)
RulesPromptNew->>Editor: Insert trimmed example text
Editor-->>User: Updated content
sequenceDiagram
autonumber
actor User
participant RulesPrompt (old)
participant Examples (old)
Note over RulesPrompt: Examples rendering is commented out
User->>RulesPrompt: Toggle showExamples
RulesPrompt--x Examples: No mount (commented)
Note over User,RulesPrompt: Examples UI not available in this flow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, please upgrade to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free!
| const personaPrompt = persona | ||
| ? personas[persona as keyof typeof personas]?.prompt | ||
| const examples = persona | ||
| ? personas[persona as keyof typeof personas].promptArray |
There was a problem hiding this comment.
Bug: Optional Chaining Removed Causing Runtime Errors
It looks like the optional chaining operator (?.) was removed when accessing personas[persona as keyof typeof personas].promptArray. If persona isn't a valid key, this could lead to a runtime error trying to access promptArray on an undefined value, where the previous code would have safely returned undefined.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
apps/web/app/(app)/[emailAccountId]/assistant/examples.ts (1)
70-77: Clarify fallback when an empty examples array is passed.
Usingexamples || examplePromptsBasetreats[]as truthy, yielding no prompts. If you intend to fall back whenexamplesis empty, switch to a length check.Apply:
-export function getExamplePrompts( - provider: string, - examples?: string[], -): string[] { - return processPromptsWithTerminology( - examples || examplePromptsBase, - provider, - ); -} +export function getExamplePrompts( + provider: string, + examples?: string[], +): string[] { + const source = examples && examples.length > 0 ? examples : examplePromptsBase; + return processPromptsWithTerminology(source, provider); +}apps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsx (1)
10-16: Ensure buttons don’t submit forms if embedded later.
Guidelines require a type on buttons. These buttons could be placed within a form in future usages.Outside this hunk, update the Example button:
- <Button + <Button + type="button" key={example} variant="outline" onClick={() => onSelect(example)} className="h-auto w-full justify-start text-wrap py-2 text-left" >Also applies to: 20-20
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsx (1)
347-349: Commented Examples block is now outdated (prop change).
If you re-enable it,Examplesnow requires anexamplesprop. Also,addExamplePromptis currently unused.Consider:
-{/* {showExamples && ( - <Examples onSelect={addExamplePrompt} provider={provider} /> -)} */} +{/* {showExamples && ( + <Examples + examples={personas.other.promptArray} + onSelect={addExamplePrompt} + provider={provider} + /> +)} */}Or remove
addExamplePromptuntil this block is restored.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
apps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsx(1 hunks)apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsx(1 hunks)apps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx(5 hunks)apps/web/app/(app)/[emailAccountId]/assistant/examples.ts(1 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (15)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/examples.tsapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/examples.tsapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/examples.tsversion.txtapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/examples.tsapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
apps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/examples.tsapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
apps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
apps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/examples.tsapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/examples.tsversion.txtapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesPrompt.tsxapps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsxapps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/app/(app)/[emailAccountId]/assistant/examples.ts🧬 Code graph analysis (1)
apps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx (3)
apps/web/app/(app)/[emailAccountId]/assistant/create/examples.tsx (1)
examples(13-144)apps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsx (1)
Examples(55-55)apps/web/components/editor/SimpleRichTextEditor.tsx (1)
SimpleRichTextEditor(28-158)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cursor Bugbot
🔇 Additional comments (9)
version.txt (1)
1-1: Version bump looks good.
No functional impact here.apps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsx (1)
10-16: Type is fine; consider defensive fallback.
examples: string[]is required and you already gate rendering upstream. If you ever relax that, pass a non-empty array to avoid rendering nothing.Would you like me to add a tiny guard here to default to base prompts when
examples.length === 0?Also applies to: 20-20
apps/web/app/(app)/[emailAccountId]/assistant/RulesPromptNew.tsx (7)
42-44: Persona → examples mapping looks correct.
Good use ofpromptArrayto drive the Examples panel.
51-53: Prop threading LGTM.
PassingexamplesintoRulesPromptFormkeeps the flow clean.
68-75: Props shape update looks consistent.
Optionalexamples?: string[]aligns with conditional rendering paths.
150-157: Examples panel integration looks good; ensure child is client.
This relies onExamplesList.tsxbeing a Client Component. Add "use client" there (see comment in that file).
182-182: Skeleton height reduction acknowledged.
No UX concerns; matches editor height change.
187-187: Editor height reduced to 180.
Confirm readability on smaller screens; otherwise fine.
201-202: Copy update reads better.
“Choose from examples” is clearer for users.
| examples, | ||
| onSelect, | ||
| provider, | ||
| className = "mt-1.5 sm:h-[60vh] sm:max-h-[60vh]", | ||
| }: { | ||
| examples: string[]; | ||
| onSelect: (example: string) => void; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Mark this component as a Client Component.
This file defines interactive UI (onClick) and is imported by Client Components. Add the "use client" directive to avoid Next.js RSC import errors.
Add at the very top of the file:
"use client";Also applies to: 20-20
🤖 Prompt for AI Agents
In apps/web/app/(app)/[emailAccountId]/assistant/ExamplesList.tsx around lines
10-16 (and also line 20), this component uses interactive handlers and is
imported by Client Components but lacks the Next.js Client Component directive;
add the "use client" directive as the very first line of the file (before any
imports or code) to mark it as a client component and prevent RSC import errors.
1 participant
Summary by CodeRabbit
New Features
UI/UX
Changes
Chores