Update cookie settings. Add cookie env

[edulelis]

Summary by CodeRabbit

• New Features

  • Added support for account linking across Google and Microsoft providers, allowing users to link accounts with different emails.
  • Introduced a new environment variable for cookie domain configuration to enhance cross-subdomain authentication.

• Improvements

  • Updated authentication flow to redirect new users to a welcome page after connecting Google or Microsoft accounts.
  • Enhanced cookie handling by making the domain configurable via environment settings.
  • Improved security by disabling ID token sign-in for social providers.

[vercel]

@edulelis is attempting to deploy a commit to the Inbox Zero OSS Program Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates authentication and environment configuration in the web app. It introduces a new environment variable for cookie domains, dynamically applies this variable to cookie settings, enables account linking for Google and Microsoft providers, adds a new user callback URL for social sign-ins, and disables ID token sign-in for these providers.

Changes

Cohort / File(s)	Change Summary
Social Sign-In Callback Update apps/web/app/(app)/accounts/AddAccount.tsx	Adds newUserCallbackURL: "/welcome" to Google and Microsoft social sign-in calls.
Environment Variable Addition apps/web/env.ts	Introduces COOKIE_DOMAIN as a server environment variable with a default value.
Auth Configuration Enhancements apps/web/utils/auth.ts	Replaces hardcoded cookie domain with env.COOKIE_DOMAIN, enables account linking for Google and Microsoft, and adds disableIdTokenSignIn: true to their provider configs.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AddAccountComponent
    participant AuthClient
    participant AuthConfig

    User->>AddAccountComponent: Click "Connect Google/Microsoft"
    AddAccountComponent->>AuthClient: signIn.social({callbackURL, newUserCallbackURL, scopes})
    AuthClient->>AuthConfig: Use provider config (with disableIdTokenSignIn, accountLinking)
    AuthClient->>User: Redirect to provider auth flow
    Note right of AuthClient: Cookie domain set from env.COOKIE_DOMAIN

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Add consent and account_select to Microsoft Entra #613: Modifies Microsoft provider configuration in apps/web/utils/auth.ts, similar to changes in provider settings in this PR.
• Update scopes, baseURL. Add patch to output extra logs #643: Updates social sign-in calls and auth configuration in overlapping files, including account linking and callback URLs.

Poem

A hop and a skip, a cookie domain anew,
Linking accounts for a trusted few.
Welcome, new users, with callbacks in tow,
Google and Microsoft—let the sign-ins flow!
With settings now smarter, and linking in sight,
This bunny reviews with pure delight. 🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7851db and f4cc018.

📒 Files selected for processing (3)

• apps/web/app/(app)/accounts/AddAccount.tsx (2 hunks)
• apps/web/env.ts (1 hunks)
• apps/web/utils/auth.ts (4 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.