Skip to content

Comments

Test with reduced scope#629

Merged
edulelis merged 1 commit intoelie222:stagingfrom
edulelis:staging-test-select-account-prompt
Aug 1, 2025
Merged

Test with reduced scope#629
edulelis merged 1 commit intoelie222:stagingfrom
edulelis:staging-test-select-account-prompt

Conversation

@edulelis
Copy link
Collaborator

@edulelis edulelis commented Aug 1, 2025

Summary by CodeRabbit

  • Chores
    • Enhanced Microsoft OAuth security by enabling PKCE during sign-in.
    • Updated Microsoft integration by disabling several mail and contacts permission scopes.

@vercel
Copy link

vercel bot commented Aug 1, 2025

@edulelis is attempting to deploy a commit to the Inbox Zero OSS Program Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates the Microsoft OAuth provider configuration to include PKCE checks in the authentication flow and comments out several Microsoft Graph API mail and contact permission scopes, disabling their inclusion in the exported scopes array. No other logic or public API is modified.

Changes

Cohort / File(s) Change Summary
Microsoft OAuth PKCE Option
apps/web/utils/auth.ts
Adds checks: ["pkce"] to the Microsoft OAuth provider configuration in getAuthOptions.
Disable Mail and Contact Scopes
apps/web/utils/outlook/scopes.ts
Comments out multiple Microsoft Graph API mail and contact permission scopes in the exported SCOPES array.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Allow dangerous linking #623: Also modifies the Microsoft OAuth provider configuration in getAuthOptions, adding a different option.
  • Skip checks as test #626: Alters the Microsoft provider's checks option in the same function, with related authentication logic refactoring.
  • Outlook auth #493: Introduces Microsoft OAuth support and configures provider and scopes, directly related to the same files and features.

Poem

A bunny with nimble paws and keen sight,
Tweaked PKCE checks for OAuth’s delight.
Scoped out some permissions, tucked them away,
Leaving just what’s needed for another day.
With a hop and a skip, the code is now neat—
Secure and selective, a rabbit’s feat! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8968ef9 and 02e7c07.

📒 Files selected for processing (2)
  • apps/web/utils/auth.ts (1 hunks)
  • apps/web/utils/outlook/scopes.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@edulelis edulelis merged commit 1160cd2 into elie222:staging Aug 1, 2025
4 of 7 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 5, 2025
@edulelis edulelis deleted the staging-test-select-account-prompt branch August 27, 2025 20:32
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant