Skip to content

Set logger, update error page#620

Merged
edulelis merged 2 commits intoelie222:stagingfrom
edulelis:staging-test-select-account-prompt
Aug 1, 2025
Merged

Set logger, update error page#620
edulelis merged 2 commits intoelie222:stagingfrom
edulelis:staging-test-select-account-prompt

Conversation

@edulelis
Copy link
Collaborator

@edulelis edulelis commented Aug 1, 2025

Summary by CodeRabbit

  • New Features

    • Improved redirect handling during authentication for more consistent navigation.
    • Enhanced logging for authentication events, providing clearer error and debug information.
  • Bug Fixes

    • Updated error page routing to direct users to the main login page on authentication errors.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new asynchronous redirect callback was added to the NextAuth configuration to normalize and log redirect URLs. The error page path was updated from "/login/error" to "/login". A custom logger object with error, warn, and debug methods was introduced, mapping debug calls to info-level logs.

Changes

Cohort / File(s) Change Summary
NextAuth Configuration Enhancements
apps/web/utils/auth.ts
Added async redirect callback for URL normalization and logging; updated error page path; introduced custom logger object with mapped log levels.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NextAuth (auth.ts)
    participant Logger

    User->>NextAuth (auth.ts): Initiates authentication/redirect
    NextAuth (auth.ts)->>Logger: Log redirect details (debug/info)
    NextAuth (auth.ts)->>User: Redirects to normalized URL

    Note over NextAuth (auth.ts): On error, redirect to "/login"
    NextAuth (auth.ts)->>Logger: Log error/warn/debug as needed
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A bunny hopped through fields of code,
Tweaking redirects on the road.
With logs that chirp and errors light,
The login path now feels just right.
Debug and warn, info in tow—
The auth flow’s clear, so off we go!
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b65228 and 523e85f.

📒 Files selected for processing (1)
  • apps/web/utils/auth.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Aug 1, 2025

@edulelis is attempting to deploy a commit to the Inbox Zero OSS Program Team on Vercel.

A member of the Team first needs to authorize it.

@edulelis edulelis merged commit a665d97 into elie222:staging Aug 1, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments