Add ultracite/biome by elie222 · Pull Request #569 · elie222/inbox-zero

elie222 · 2025-07-14T22:49:21Z

I disabled a lot of rules as it will lead to a big merge conflict with staging if we add all rules now. Once staging is merged in we can delete most of the disabled lint rules.

Summary by CodeRabbit

New Features
- Introduced Ultracite configuration with comprehensive coding standards for JavaScript and TypeScript projects.
- Added a strict TypeScript configuration enabling strict null checks.
Chores
- Removed all ESLint and Prettier configurations, dependencies, and related files.
- Updated formatting and linting tools to use Biome and Ultracite.
- Updated VSCode settings for consistent formatting and auto-fixing on save.
- Enhanced pre-commit hook to include Ultracite formatting.
- Cleaned up Dockerfile and project documentation to reflect tool changes.
Style
- Applied minor formatting improvements across code, configuration, and documentation files.
Bug Fixes
- Fixed comment syntax in code documentation.
Refactor
- Simplified code syntax and improved type safety in several utility and component files.
Tests
- Minor syntax improvements and removal of unused imports in test files.

vercel · 2025-07-14T22:49:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
inbox-zero	✅ Ready (Inspect)	Visit Preview	Jul 14, 2025 11:02pm

coderabbitai · 2025-07-14T22:49:27Z

Walkthrough

This update removes all ESLint-related configuration, packages, and documentation from the repository, replacing linting and formatting tools with Biome and Ultracite. It introduces a stricter TypeScript null checking policy, updates project formatting and VSCode settings, and makes minor syntax, style, and formatting improvements throughout the codebase.

Changes

File(s) / Path(s)	Change Summary
`.eslintrc.js`, `apps/web/.eslintrc.json`, `packages/eslint-config/*`	Removed all ESLint configuration files and the internal ESLint config package.
`package.json`, `apps/web/package.json`, `biome.json`, `.vscode/settings.json`, `.husky/pre-commit`, `.cursor/rules/ultracite.mdc`, `.cursor/rules/project-structure.mdc`	Replaced ESLint/Prettier with Biome and Ultracite; updated lint-staged, VSCode, and pre-commit settings; added Ultracite rules.
`tsconfig.json`	Added with `"strictNullChecks": true` for stricter TypeScript null handling.
`docker/Dockerfile.prod`	Stopped copying `packages/eslint-config/package.json` during build.
`apps/web/utils/error.ts`, `apps/web/utils/redis/subscriber.ts`, `apps/web/utils/assess.ts`	Simplified function/class signatures by removing explicit access modifiers or multi-line declarations.
`apps/web/utils/actions/admin.ts`, `apps/web/app/api/user/stats/day/route.ts`	Removed unnecessary explicit `undefined` initializations.
`apps/web/app/api/google/webhook/process-history-item.test.ts`, `apps/web/app/api/lemon-squeezy/webhook/route.ts`, `apps/web/__tests__/ai-extract-from-email-history.test.ts`	Refactored to use ES6 object property shorthand.
`apps/web/components/assistant-chat/message.tsx`	Added `key` prop to `<Skeleton>` component in list rendering.
`apps/web/components/assistant-chat/message-editor.tsx`	Disabled a Biome linter rule with a comment directive.
`apps/web/components/TabSelect.tsx`	Removed `aria-selected` attribute from button.
`apps/web/app/(app)/[emailAccountId]/assistant/group/ViewGroup.tsx`	Removed `void` operator from form submission handler.
`apps/web/__tests__/ai/reply/draft-with-knowledge.test.ts`	Removed unused type import.
`apps/web/components/editor/SimpleRichTextEditor.css`	Reformatted CSS selectors for improved readability.
`apps/web/styles/globals.css`, `turbo.json`, `apps/web/app/manifest.json`	Removed trailing whitespace or added newline for formatting consistency.
`apps/web/sanity.cli.ts`, `apps/web/postcss.config.js`, `apps/web/vitest.config.mts`	Fixed comment or statement termination and formatting.
`apps/web/app/(marketing)`	Updated subproject commit reference.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Pre-commit Hook
    participant Ultracite
    participant Biome
    participant VSCode

    Developer->>Pre-commit Hook: Stage changes & commit
    Pre-commit Hook->>Ultracite: Run format (npx ultracite format)
    Pre-commit Hook->>lint-staged: Run on staged files
    VSCode->>Biome: Format on save/paste
    VSCode->>Ultracite: (optionally) Run formatting via tasks

Possibly related PRs

Add UI for cursor rules style prompt #227: Removes the ESLint config package and its usage, including deleting packages/eslint-config/next.js and apps/web/.eslintrc.json, directly related to ESLint config removal in this PR.

Poem

🐇✨
A rabbit hops, the code is neat,
ESLint and Prettier take their seat.
Biome and Ultracite now lead the way,
Formatting files in a snappy ballet.
With strict null checks and cleaner style,
This codebase will run for many a mile!
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e85824d and 7d98382.

📒 Files selected for processing (1)

apps/web/utils/error.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/web/utils/error.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Jit Security
GitHub Check: claude-review
GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

claude · 2025-07-14T22:49:35Z

Claude finished @elie222's task —— View job

PR Review: ESLint to Biome Migration

Reviewing this major migration from ESLint to Biome. Here's my analysis progress:

Review Biome configuration (biome.json)
Analyze removed ESLint configurations
Check package.json changes and dependency updates
Review formatting changes across codebase
Examine new Cursor rules and documentation
Check pre-commit hook updates
Assess security and performance implications
Provide comprehensive feedback

Summary

This PR successfully migrates the inbox-zero codebase from ESLint to Biome, implementing the "Ultracite" configuration standard. The migration appears well-executed with comprehensive configuration and documentation.

✅ Strengths

Complete Migration: Properly removes all ESLint configurations (.eslintrc.js, apps/web/.eslintrc.json, entire packages/eslint-config/ package)
Comprehensive Biome Configuration: biome.json:115 extends "ultracite" with extensive rule customizations that appropriately disable overly strict rules while maintaining code quality
Updated Tooling Integration:
- Pre-commit hooks updated (.husky/pre-commit:4) to use npx ultracite format
- VSCode settings (.vscode/settings.json:4,11,18) properly configured for Biome formatting
- Package scripts (root package.json:11-12) include new format commands
Excellent Documentation: The new .cursor/rules/ultracite.mdc provides comprehensive guidelines covering accessibility, React best practices, TypeScript conventions, and security
Performance Benefits: Biome provides significantly faster linting/formatting than ESLint

⚠️ Areas for Attention

Many Disabled Rules: The Biome configuration disables many recommended rules (54 total disabled rules). While this enables easier migration, consider gradually re-enabling rules that provide value:
- correctness.noUnusedImports: "off" (biome.json:62) - unused imports should typically be cleaned up
- correctness.noUnusedVariables: "off" (biome.json:61) - unused variables can indicate dead code
- style.useFilenamingConvention: "off" (biome.json:12) - consistent file naming improves maintainability
Linting Workflow: The turbo configuration (turbo.json:127) shows an empty lint task, but it's unclear how Biome linting is integrated into the build process
Missing Error Handling: No apparent fallback if Biome formatting fails in pre-commit hooks

🔍 Security & Performance Analysis

Security: ✅ Clean migration with no security concerns

Biome is a well-maintained tool by the Babel team
Configuration doesn't expose sensitive data
No suspicious dependencies added

Performance: ✅ Significant improvements expected

Biome is ~100x faster than ESLint for similar operations
Reduced dependency tree (removed entire ESLint ecosystem)
Bundle size reduction from fewer dev dependencies

📝 Minor Suggestions

Consider Re-enabling Select Rules:

"correctness": {
  "noUnusedImports": "warn", // Instead of "off"
  "noUnusedVariables": "warn", // Instead of "off"
}

Add Biome to Turbo Pipeline: Update turbo.json to include Biome linting:
```
"lint": {
  "dependsOn": ["^lint"],
  "outputs": []
}
```
Document Migration: Consider adding a brief migration note to explain the switch from ESLint to Biome for team members

🎯 Overall Assessment

Excellent migration that modernizes the tooling stack with significant performance benefits. The Ultracite configuration provides comprehensive code quality standards while remaining practical for a large codebase. The extensive documentation in .cursor/rules/ultracite.mdc is particularly valuable for maintaining consistency.

Recommendation: ✅ Approve with minor suggestions

The migration is well-executed and ready for production. The disabled rules can be addressed incrementally in future PRs as the team adapts to Biome's more opinionated defaults.

socket-security · 2025-07-14T22:49:56Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	capital-case@2.0.0
	class-variance-authority@0.7.1
	cheerio@1.0.0
	@biomejs/biome@1.9.4 ⏵ 2.1.1	⁺⁷

View full report

coderabbitai

Actionable comments posted: 5

🧹 Nitpick comments (4)

apps/web/sanity.cli.ts (1)
1-4: Good catch on the comment terminator – consider validating env vars as well

The */ fix prevents malformed JSDoc parsing. While touching this header, it’s worth asserting that projectId and dataset are defined before exporting the config to avoid Sanity CLI runtime failures in mis-configured environments.
+if (!projectId || !dataset) {
+  throw new Error("Sanity CLI requires NEXT_PUBLIC_SANITY_PROJECT_ID and NEXT_PUBLIC_SANITY_DATASET");
+}
apps/web/components/assistant-chat/message-editor.tsx (1)
34-34: Complete the explanation for the lint rule suppression.

The biome-ignore comment contains a placeholder <explanation> that should be replaced with a proper explanation for why the useExhaustiveDependencies rule is being disabled.
-  // biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
+  // biome-ignore lint/correctness/useExhaustiveDependencies: adjustHeight is stable and only needed to run once on mount
package.json (1)

24-26: Duplicate formatting on pre-commit – lint-staged already runs Ultracite.

Running npx ultracite format inside lint-staged and again inside the Husky hook wastes time and may create merge-index churn.

If Husky executes lint-staged, drop the explicit ultracite format step in one place to avoid double work.
biome.json (1)
88-93: Formatter config duplicates rules – keep it in one place.

"javascript.formatter" overrides quoteStyle & trailingCommas, but Biome already respects the top-level formatter options.
Unless you need language-specific overrides, prefer a single source of truth:
-  "javascript": {
-    "formatter": {
-      "quoteStyle": "double",
-      "trailingCommas": "all"
-    }
-  },
+  // Remove block above – configure via top-level "formatter" or .editorconfig

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f650225 and e85824d.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (37)

.cursor/rules/project-structure.mdc (1 hunks)
.cursor/rules/ultracite.mdc (1 hunks)
.eslintrc.js (0 hunks)
.husky/pre-commit (1 hunks)
.vscode/settings.json (1 hunks)
apps/web/.eslintrc.json (0 hunks)
apps/web/__tests__/ai-extract-from-email-history.test.ts (1 hunks)
apps/web/__tests__/ai/reply/draft-with-knowledge.test.ts (0 hunks)
apps/web/app/(app)/[emailAccountId]/assistant/group/ViewGroup.tsx (1 hunks)
apps/web/app/(marketing) (1 hunks)
apps/web/app/api/google/webhook/process-history-item.test.ts (1 hunks)
apps/web/app/api/lemon-squeezy/webhook/route.ts (1 hunks)
apps/web/app/api/user/stats/day/route.ts (1 hunks)
apps/web/app/manifest.json (1 hunks)
apps/web/components/TabSelect.tsx (0 hunks)
apps/web/components/assistant-chat/message-editor.tsx (1 hunks)
apps/web/components/assistant-chat/message.tsx (1 hunks)
apps/web/components/editor/SimpleRichTextEditor.css (2 hunks)
apps/web/package.json (0 hunks)
apps/web/postcss.config.js (1 hunks)
apps/web/sanity.cli.ts (1 hunks)
apps/web/styles/globals.css (1 hunks)
apps/web/utils/actions/admin.ts (1 hunks)
apps/web/utils/assess.ts (1 hunks)
apps/web/utils/error.ts (1 hunks)
apps/web/utils/redis/subscriber.ts (2 hunks)
apps/web/vitest.config.mts (1 hunks)
biome.json (1 hunks)
docker/Dockerfile.prod (0 hunks)
package.json (1 hunks)
packages/eslint-config/README.md (0 hunks)
packages/eslint-config/library.js (0 hunks)
packages/eslint-config/next.js (0 hunks)
packages/eslint-config/package.json (0 hunks)
packages/eslint-config/react-internal.js (0 hunks)
tsconfig.json (1 hunks)
turbo.json (1 hunks)

💤 Files with no reviewable changes (11)

apps/web/tests/ai/reply/draft-with-knowledge.test.ts
apps/web/components/TabSelect.tsx
packages/eslint-config/README.md
docker/Dockerfile.prod
apps/web/package.json
.eslintrc.js
packages/eslint-config/package.json
packages/eslint-config/react-internal.js
apps/web/.eslintrc.json
packages/eslint-config/next.js
packages/eslint-config/library.js

🧰 Additional context used

📓 Path-based instructions (8)

apps/web/app/**/*

Instructions used from: