Skip to content

Comments

fix: Add missing digest migration to resolve schema diff#528

Merged
elie222 merged 2 commits intoelie222:mainfrom
edulelis:fix-digest-migrations
Jun 27, 2025
Merged

fix: Add missing digest migration to resolve schema diff#528
elie222 merged 2 commits intoelie222:mainfrom
edulelis:fix-digest-migrations

Conversation

@edulelis
Copy link
Collaborator

@edulelis edulelis commented Jun 27, 2025

Summary by CodeRabbit

  • Chores
    • Updated the database schema by removing the digest schedule field from email accounts.

@vercel
Copy link

vercel bot commented Jun 27, 2025

@edulelis is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 27, 2025

Walkthrough

A database migration script was added to modify the schema by removing the digestScheduleId column from the EmailAccount table. The script first drops the related foreign key constraint and index, then deletes the column, with a warning that all data in this column will be lost.

Changes

File(s) Change Summary
apps/web/prisma/migrations/20250627111946_update_digest/... Migration script removes digestScheduleId from EmailAccount, including its foreign key and index.

Poem

Goodbye, old column, you’ve served your quest,
Now the schema’s lighter, off to rest.
Foreign keys and indexes, swept away,
Our tables are cleaner as of today.
With every migration, we hop ahead—
The database garden freshly bred! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9239e5 and 2530dc4.

📒 Files selected for processing (1)
  • apps/web/prisma/migrations/20250627111946_update_digest/migration.sql (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/prisma/migrations/20250627111946_update_digest/migration.sql
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Jit Security
  • GitHub Check: test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@edulelis edulelis marked this pull request as ready for review June 27, 2025 11:24
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/web/prisma/migrations/20250627111946_update_digest/migration.sql (1)

1-6: Add an explicit “down” migration or at least document rollback steps

The script is one-way; rolling back will require manual SQL. Either add a companion DOWN script or leave a short comment explaining the exact ALTER TABLE … ADD COLUMN … sequence needed to restore the column so that future hot-fixes aren’t blocked.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1b814a and a9239e5.

📒 Files selected for processing (1)
  • apps/web/prisma/migrations/20250627111946_update_digest/migration.sql (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`apps/web/**`: Install packages only within the 'apps/web' directory, not at the repository root.

apps/web/**: Install packages only within the 'apps/web' directory, not at the repository root.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/installing-packages.mdc)

List of files the instruction was applied to:

  • apps/web/prisma/migrations/20250627111946_update_digest/migration.sql
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Secret Detection
  • GitHub Check: Jit Security
  • GitHub Check: test
🔇 Additional comments (1)
apps/web/prisma/migrations/20250627111946_update_digest/migration.sql (1)

13-15: DROP COLUMN already cascades indexes – double-check the extra DROP INDEX

PostgreSQL drops indexes on a column automatically when the column is removed. Keeping the explicit DROP INDEX is harmless but redundant and slightly prolongs lock time on large tables. Consider deleting it unless your target DB requires it.

@elie222 elie222 merged commit 76010f4 into elie222:main Jun 27, 2025
5 of 6 checks passed
@edulelis edulelis deleted the fix-digest-migrations branch July 24, 2025 18:15
@coderabbitai coderabbitai bot mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants