-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Outlook login with NextAuth #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,15 @@ | |
| import { createEnv } from "@t3-oss/env-nextjs"; | ||
| import { z } from "zod"; | ||
|
|
||
| export const env = createEnv({ | ||
|
Check failure on line 5 in apps/web/env.ts
|
||
| server: { | ||
| NODE_ENV: z.enum(["development", "production", "test"]), | ||
| DATABASE_URL: z.string().url(), | ||
| NEXTAUTH_SECRET: z.string().min(1), | ||
| NEXTAUTH_URL: z.string().optional(), | ||
| MICROSOFT_CLIENT_ID: z.string().min(1), | ||
| MICROSOFT_CLIENT_SECRET: z.string().min(1), | ||
| MICROSOFT_ISSUER: z.string().default("common"), | ||
|
Comment on lines
+11
to
+13
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainAddress inconsistency between environment variable names. There's a naming inconsistency: Please clarify:
🏁 Script executed: #!/bin/bash
# Check for Microsoft environment variable usage across the codebase
echo "Searching for Microsoft environment variable usage..."
rg -A 2 -B 2 "MICROSOFT_(CLIENT_ID|CLIENT_SECRET|TENANT_ID|ISSUER)"Length of output: 2859 🏁 Script executed: #!/bin/bash
# Locate .env.example files and check for MICROSOFT_TENANT_ID usage
echo "Locating .env.example files..."
find . -type f -name ".env.example"
echo
echo "Searching for MICROSOFT_TENANT_ID in .env.example files..."
for file in $(find . -type f -name ".env.example"); do
echo "File: $file"
grep -n "MICROSOFT_TENANT_ID" "$file" || echo " → No occurrences found in $file"
doneLength of output: 1224 Standardize Microsoft tenant environment variable naming There’s an inconsistency between your validation schema and example files:
This can confuse users setting up Azure credentials. Please align the names across all references. Affected locations:
Suggested diff for - MICROSOFT_TENANT_ID=
+ MICROSOFT_ISSUER=And update the README so it consistently describes
🤖 Prompt for AI Agents |
||
| GOOGLE_CLIENT_ID: z.string().min(1), | ||
| GOOGLE_CLIENT_SECRET: z.string().min(1), | ||
| GOOGLE_ENCRYPT_SECRET: z.string(), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix copy-paste error: These should reference Microsoft/Azure, not Google.
These environment variable descriptions incorrectly reference "Google OAuth" when they should reference "Microsoft" or "Azure".
📝 Committable suggestion
🤖 Prompt for AI Agents