Update seats on stripe when sharing premium#488
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe update refactors premium account seat management by introducing a new helper function, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant updateMultiAccountPremiumAction
participant DB
participant updateAccountSeatsForPremium
participant StripeOrLemonSqueezy
User->>updateMultiAccountPremiumAction: Trigger premium seat update
updateMultiAccountPremiumAction->>DB: Fetch premium record (with user accounts & pending invites)
updateMultiAccountPremiumAction->>updateAccountSeatsForPremium: Call with premium record & total seats
updateAccountSeatsForPremium->>StripeOrLemonSqueezy: Update subscription item quantity
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
apps/web/utils/actions/ai-rule.tsOops! Something went wrong! :( ESLint: 9.28.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by apps/web/utils/actions/group.tsOops! Something went wrong! :( ESLint: 9.28.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by apps/web/utils/actions/admin.tsOops! Something went wrong! :( ESLint: 9.28.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on June 9, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
apps/web/utils/actions/admin.ts(2 hunks)apps/web/utils/actions/ai-rule.ts(4 hunks)apps/web/utils/actions/categorize.ts(1 hunks)apps/web/utils/actions/generate-reply.ts(2 hunks)apps/web/utils/actions/group.ts(3 hunks)apps/web/utils/actions/mail.ts(10 hunks)apps/web/utils/actions/permissions.ts(4 hunks)apps/web/utils/actions/premium.ts(7 hunks)apps/web/utils/actions/rule.ts(8 hunks)apps/web/utils/actions/stats.ts(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/web/utils/actions/premium.ts
🧰 Additional context used
🧬 Code Graph Analysis (9)
apps/web/utils/actions/stats.ts (1)
apps/web/utils/error.ts (1)
SafeError(83-91)
apps/web/utils/actions/categorize.ts (1)
apps/web/utils/error.ts (1)
SafeError(83-91)
apps/web/utils/actions/generate-reply.ts (1)
apps/web/utils/error.ts (1)
SafeError(83-91)
apps/web/utils/actions/permissions.ts (3)
apps/web/utils/error.ts (1)
SafeError(83-91)apps/web/utils/gmail/permissions.ts (1)
handleGmailPermissionsCheck(71-106)apps/web/utils/account.ts (1)
getGmailAndAccessTokenForEmail(25-39)
apps/web/utils/actions/mail.ts (1)
apps/web/utils/error.ts (1)
SafeError(83-91)
apps/web/utils/actions/rule.ts (1)
apps/web/utils/error.ts (1)
SafeError(83-91)
apps/web/utils/actions/ai-rule.ts (1)
apps/web/utils/error.ts (1)
SafeError(83-91)
apps/web/utils/actions/group.ts (1)
apps/web/utils/error.ts (1)
SafeError(83-91)
apps/web/utils/actions/admin.ts (2)
apps/web/utils/error.ts (1)
SafeError(83-91)apps/web/utils/user/delete.ts (1)
deleteUser(14-74)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Jit Security
🔇 Additional comments (27)
apps/web/utils/actions/stats.ts (1)
15-15: LGTM: Standardized error handling with SafeError.The addition of
SafeErrorimport and the change from returning an error object to throwing aSafeErrorexception properly standardizes error handling across the codebase. This improves control flow by using exceptions for error signaling.Also applies to: 31-31
apps/web/utils/actions/categorize.ts (1)
256-256: LGTM: Consistent error handling for duplicate category names.The change from returning an error object to throwing a
SafeErrorexception aligns with the broader error handling standardization across the codebase. The error message remains clear and appropriate.apps/web/utils/actions/rule.ts (1)
156-156: LGTM: Comprehensive error handling standardization.All error cases have been consistently updated from returning error objects to throwing
SafeErrorexceptions. This improves control flow and aligns with proper exception-based error handling patterns. The error messages remain clear and appropriate for each scenario.Also applies to: 256-256, 259-261, 279-279, 304-304, 331-331, 360-360, 389-389, 448-448
apps/web/utils/actions/generate-reply.ts (1)
9-9: LGTM: Proper error handling standardization.The addition of
SafeErrorimport and the conversion of error returns to exception throwing is consistent with the broader error handling refactoring. Both error cases are handled appropriately with clear error messages.Also applies to: 21-21, 25-25
apps/web/utils/actions/admin.ts (3)
9-9: LGTM: SafeError import added appropriately.The import is correctly placed and aligns with the error handling standardization across the codebase.
44-44: LGTM: Consistent error handling with SafeError.The change from returning an error object to throwing a SafeError exception improves consistency and follows the standardized error handling pattern.
49-51: LGTM: Proper error wrapping and logging.The error handling correctly wraps the original error message in a SafeError while maintaining the logging for debugging purposes. This is appropriate for admin functionality.
apps/web/utils/actions/group.ts (3)
11-11: LGTM: SafeError import correctly added.The import is properly placed and supports the error handling standardization.
22-22: LGTM: Consistent error throwing for missing rule.The change from returning an error object to throwing SafeError improves error handling consistency and provides clear feedback.
48-52: LGTM: Proper validation and permission checking.Both error conditions (missing group and permission validation) are handled consistently with clear, user-friendly error messages using SafeError.
apps/web/utils/actions/permissions.ts (3)
9-9: LGTM: SafeError import added for standardization.The import supports the consistent error handling pattern being implemented across the codebase.
21-21: LGTM: Consistent error handling in checkPermissionsAction.All error conditions are now handled uniformly by throwing SafeError exceptions instead of returning error objects, improving consistency and error propagation.
Also applies to: 27-27, 40-40
55-55: LGTM: Standardized error handling in adminCheckPermissionsAction.The error handling follows the same consistent pattern as the regular permissions action, with appropriate error messages for admin context.
Also applies to: 61-61, 67-67, 71-71
apps/web/utils/actions/ai-rule.ts (5)
214-214: LGTM: Clear error handling for missing execution plan.The change from returning an error object to throwing SafeError("Plan not found") provides clear feedback and follows the standardized error handling pattern.
278-278: LGTM: Consistent error handling for missing email account.The error handling is standardized and provides appropriate feedback when the email account cannot be found.
510-510: LGTM: Duplicate pattern for email account validation.The error handling is consistent with the previous instance and follows the standardized SafeError pattern.
567-567: LGTM: Appropriate error handling for AI generation failure.The SafeError provides clear feedback when the AI fails to generate a rules prompt, maintaining consistency with the standardized error handling.
1-583: Flag inconsistency between AI summary and actual changes.The AI-generated summary mentions premium account seat management and a new helper function
updateAccountSeatsForPremium, but the actual changes in this file are only related to error handling standardization. The summary appears to be inconsistent with the actual code changes.Likely an incorrect or invalid review comment.
apps/web/utils/actions/mail.ts (9)
22-22: LGTM: SafeError import added correctly.The import aligns with the standardized error handling refactoring.
67-68: Consistent error handling pattern applied.The change from returning error objects to throwing
SafeErrorexceptions follows the same pattern as other functions in this refactoring.
80-80: Good maintenance: Updated commented code.Even though this code is commented out, updating it to follow the new error handling pattern shows good attention to detail and maintains consistency.
93-93: Consistent error handling pattern applied.The standardized error handling approach is correctly implemented.
110-110: Consistent error handling pattern applied.The error message is clear and follows the established pattern.
123-123: Consistent error handling pattern applied.The standardized error handling approach is correctly implemented.
139-139: Consistent error handling pattern applied.The error message accurately describes the failure scenario.
159-160: Consistent error handling pattern applied.The change maintains the same error handling pattern while preserving the return statement for successful responses.
174-174: Consistent error handling pattern applied.The one-line format is clean and follows the established pattern.
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ The following Jit checks failed to run:
- secret-detection
- static-code-analysis-js
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
There was a problem hiding this comment.
❌ The following Jit checks failed to run:
- secret-detection
- static-code-analysis-js
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
1 participant
Summary by CodeRabbit