Skip to content

Adjust static matching#473

Merged
elie222 merged 1 commit intomainfrom
fix/match-static
Jun 3, 2025
Merged

Adjust static matching#473
elie222 merged 1 commit intomainfrom
fix/match-static

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Jun 3, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced support for wildcard patterns in matching email headers, allowing wildcards to be used anywhere in the pattern and improving handling of special characters.
  • Tests
    • Added comprehensive test cases to verify matching behavior for subjects and addresses containing special characters and various wildcard scenarios.
  • Chores
    • Updated version number to v1.3.0.

@vercel
Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inbox-zero ✅ Ready (Inspect) Visit Preview Jun 3, 2025 9:47pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 3, 2025

Walkthrough

Wildcard and special character handling in the matchesStaticRule function was improved to support more flexible pattern matching. The test suite was expanded with cases covering various special characters and patterns in email headers. The project version was incremented from v1.2.44 to v1.3.0.

Changes

File(s) Change Summary
apps/web/utils/ai/choose-rule/match-rules.ts Enhanced safeRegexTest to escape regex special characters (except *), enabling robust wildcard pattern support.
apps/web/utils/ai/choose-rule/match-rules.test.ts Added extensive test cases for special characters, wildcards, and empty values in email header matching.
version.txt Updated version from v1.2.44 to v1.3.0.

Poem

Oh, wildcards dance and special signs gleam,
In headers and subjects, a matcher’s dream.
From brackets to plus, and curious dots,
Patterns now match in so many spots!
With version bumped and tests anew,
This rabbit hops forward—cheering for you!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/utils/ai/choose-rule/match-rules.test.ts

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/utils/ai/choose-rule/match-rules.ts

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a294270 and 5479bbc.

📒 Files selected for processing (3)
  • apps/web/utils/ai/choose-rule/match-rules.test.ts (1 hunks)
  • apps/web/utils/ai/choose-rule/match-rules.ts (1 hunks)
  • version.txt (1 hunks)
🔇 Additional comments (3)
version.txt (1)

1-1: LGTM! Appropriate version bump for enhanced pattern matching.

The minor version increment from v1.2.44 to v1.3.0 correctly reflects the addition of improved wildcard and special character handling functionality.

apps/web/utils/ai/choose-rule/match-rules.ts (1)

277-281: Excellent improvement to regex pattern handling!

The enhanced safeRegexTest function properly escapes all regex special characters except asterisk, then converts wildcards to .* for flexible pattern matching. This allows wildcards anywhere in the pattern and prevents regex compilation errors from special characters in email headers.

The regex escaping pattern [.+?^${}()|[\]\\] correctly covers all problematic regex metacharacters while preserving wildcard functionality.

apps/web/utils/ai/choose-rule/match-rules.test.ts (1)

98-246: Comprehensive test coverage for enhanced pattern matching!

The extensive test suite thoroughly validates the improved regex handling with excellent coverage of:

  • Special characters: brackets, parentheses, plus signs, dots, dollar signs, curly braces, pipe symbols, question marks, caret symbols, and backslashes
  • Wildcard patterns: including combinations with special characters like *[Important]*
  • Common email patterns: notification addresses and receipt subjects
  • Edge cases: empty headers, case sensitivity, and exact matching

These tests ensure the enhanced safeRegexTest function works correctly across diverse real-world email header scenarios.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 9, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@elie222 elie222 merged commit 38b6a15 into main Jun 3, 2025
7 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 3, 2025
@elie222 elie222 deleted the fix/match-static branch December 18, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant