Admin delete user function

[elie222]

Summary by CodeRabbit

• New Features

  • Added ability for admins to delete user accounts directly from the admin interface.
  • Enhanced user account management controls.

• Bug Fixes

  • Streamlined user deletion process with a more efficient data removal mechanism.

• Refactor

  • Simplified account deletion logic across multiple utility functions.
  • Updated button styling in admin user controls.

• Chores

  • Modernized component import paths.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
inbox-zero	✅ Ready (Inspect)	Visit Preview	Jan 26, 2025 4:25pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces enhancements to user account management for administrators, focusing on the ability to delete user accounts directly from the interface. Key changes include the addition of a new adminDeleteAccountAction in the admin actions, a streamlined deleteUser utility function for comprehensive data removal, and updates to the AdminUserControls component to incorporate a deletion button. Additionally, modifications to button properties and imports in other components reflect a refinement in user interface elements.

Changes

File	Change Summary
apps/web/app/(app)/admin/AdminUpgradeUserForm.tsx	Updated Button import from @/components/Button to @/components/ui/button, added variant="destructive" prop, removed color="red" prop.
apps/web/app/(app)/admin/AdminUserControls.tsx	Added new state isDeleting and a button for deleting user accounts, integrating adminDeleteAccountAction.
apps/web/utils/actions/admin.ts	Introduced adminDeleteAccountAction for handling user account deletion by admin.
apps/web/utils/actions/user.ts	Simplified deleteAccountAction to use a single deleteUser function for user deletion.
apps/web/utils/user/delete.ts	Created new deleteUser function to manage comprehensive user data removal.
apps/web/app/(app)/settings/DeleteSection.tsx	Modified onClick handler for the delete button to call onCancelLoadBatch() before showing the confirmation dialog.

Sequence Diagram

sequenceDiagram
    participant Admin
    participant AdminUserControls
    participant AdminDeleteAction
    participant DeleteUserUtil
    participant Database

    Admin->>AdminUserControls: Click "Delete User"
    AdminUserControls->>AdminDeleteAction: Call adminDeleteAccountAction
    AdminDeleteAction->>DeleteUserUtil: Invoke deleteUser
    DeleteUserUtil->>Database: Delete user labels
    DeleteUserUtil->>Database: Delete inbox labels
    DeleteUserUtil->>Database: Delete user statistics
    DeleteUserUtil->>Database: Remove user record
    DeleteUserUtil-->>AdminDeleteAction: Return deletion result
    AdminDeleteAction-->>AdminUserControls: Confirm deletion
    AdminUserControls-->>Admin: Show deletion status

Loading

Possibly related PRs

• Server log out after delete #306: The changes in the main PR regarding the AdminUpgradeUserForm component's button modifications may relate to the DeleteSection component's updates in the retrieved PR, as both involve changes to button properties and user feedback mechanisms during actions (deletion in this case).
• Clean up cold email page #311: The cleanup of the cold email page may relate to the changes in the AdminUpgradeUserForm as both involve UI components and user interaction elements, although the specifics of the changes differ.

Poem

🐰 A Rabbit's Deletion Ballad 🗑️
With admin powers swift and bright,
We trim accounts with pure delight,
One click to purge, no fuss or fear,
Our deletion dance is crystal clear!
Farewell, old user, time to part! 🚪

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3511e30 and 18524ed.

📒 Files selected for processing (1)

• apps/web/app/(app)/settings/DeleteSection.tsx (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 8

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9f69bf and 3511e30.

📒 Files selected for processing (5)

• apps/web/app/(app)/admin/AdminUpgradeUserForm.tsx (2 hunks)
• apps/web/app/(app)/admin/AdminUserControls.tsx (2 hunks)
• apps/web/utils/actions/admin.ts (2 hunks)
• apps/web/utils/actions/user.ts (2 hunks)
• apps/web/utils/user/delete.ts (1 hunks)

🔇 Additional comments (3)

apps/web/utils/user/delete.ts (1)

25-40: Consider sequential deletion for critical dependencies.

Using Promise.allSettled might not be ideal if some operations depend on others. Consider identifying critical dependencies and executing them sequentially.

Let's analyze the dependencies between these operations:

apps/web/app/(app)/admin/AdminUpgradeUserForm.tsx (2)

132-132: LGTM! Semantic improvement to the Downgrade button.

The change from color="red" to variant="destructive" better conveys the semantic meaning of the action and aligns with modern UI component library patterns.

---

Line range hint 1-146: Verify the relationship to admin delete user functionality.

While these changes improve UI consistency, they seem peripheral to the main PR objective of adding admin delete user functionality. Consider splitting UI library updates into a separate PR to maintain focused code reviews.