Skip to content

Fix blog post load by removing PostHog SSR experiments#225

Merged
elie222 merged 1 commit intomainfrom
remove-posthog-ssr
Sep 13, 2024
Merged

Fix blog post load by removing PostHog SSR experiments#225
elie222 merged 1 commit intomainfrom
remove-posthog-ssr

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Sep 13, 2024

We added PostHog SSR capabilities so that search engines could read the homepage text without seeing a skeleton, and so that users wouldn't see a flicker on load.

This method relied on adding cookies to the RootLayout, but this broke static page generation fo the blog posts. The error was: DynamicServerError. More here: https://nextjs.org/docs/messages/dynamic-server-error

To fix this, we reverted using cookies in the RootLayout. We should one piece of text before hydration, and then we show another upon hydration. And to avoid the flicker a user might see, we fade in from opactity-0. By the time the fade in is complete the user only sees the final text.

There are other ways to fix this, by using multiple layouts, or with Next.js middleware, but both would have been annoying so we're using the solution in this PR.

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced HeroAB component for improved responsiveness and user experience.
    • Simplified rendering logic in the Hero component with a default static message.
  • Bug Fixes

    • Resolved flickering text issues in the HeroAB component during hydration.
  • Refactor

    • Transitioned HeroAB to client-side rendering using React hooks.
    • Removed unnecessary asynchronous data fetching for PostHog integration.
  • Chores

    • Removed unused uuidv7 dependency from the project.

@vercel
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inbox-zero 🔄 Building (Inspect) Visit Preview Sep 13, 2024 11:55am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve significant refactoring of several components in the application, particularly the Hero and HeroAB components. The Hero component now directly renders a static string when the title prop is absent, while HeroAB has transitioned from server-side rendering to a client-side implementation using React hooks. Additionally, the PostHogProvider has been simplified by removing the dependency on bootstrap data, and the bootstrap.ts file has been removed entirely, indicating a shift in how PostHog integration is handled.

Changes

Files Change Summary
apps/web/app/(landing)/home/Hero.tsx Removed commented-out fallback for title prop; now defaults to static string in HeroText if title is not provided.
apps/web/app/(landing)/home/HeroAB.tsx Changed from an async SSR function to a client-side component using hooks; updated state management for title, subtitle, and isHydrated; improved rendering logic to mitigate flickering text issues.
apps/web/app/layout.tsx Removed fetching mechanism for PostHog bootstrap data; simplified initialization of PostHogProvider by eliminating the bootstrapData prop.
apps/web/package.json Removed dependency on uuidv7, suggesting a change in how unique identifiers are managed within the application.
apps/web/providers/PostHogProvider.tsx Simplified PostHogProvider by removing bootstrapData from props; now initializes the PostHog client unconditionally if the API key is defined.
apps/web/utils/posthog/bootstrap.ts Removed file containing functionality for fetching PostHog bootstrap data and user identification, which was used for server-side rendering and A/B testing.

Possibly related PRs

  • Add a/b test for home #213: Changes in HeroAB.tsx relate to rendering logic adjustments that may connect with CTAButtons.tsx and FAQs.tsx, which also use feature flags.
  • Add copilot plan #204: Modifications in HeroAB.tsx and Hero.tsx involve rendering logic adjustments aimed at simplifying component behavior.
  • Add support for Anthropic #215: Enhancements in HeroAB.tsx may relate to the addition of support for Anthropic, focusing on improving user experience with AI functionalities.
  • Add bulk actions #223: Changes in HeroAB.tsx may connect with the introduction of bulk actions, both aiming to enhance user interaction within the application.

Poem

In the meadow where bunnies play,
Changes hop in a joyful way.
With simpler paths and clearer sights,
Our code now dances in the lights.
Hooray for features, so bright and new,
A leap of joy, we celebrate too! 🐇✨

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elie222 elie222 merged commit 817236e into main Sep 13, 2024
@elie222 elie222 deleted the remove-posthog-ssr branch September 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments