Fix #179 - Replace autocomplete for contacts by madhav-relish · Pull Request #220 · elie222/inbox-zero

madhav-relish · 2024-08-27T17:41:12Z

Modal is now big and fully responsive
Simplified the styling
changed the design of the "To" input to the desired ComboBox.

- Modal is now big and fully responsive - Simplified the styling - changed the design of the "To" autocomplete to the desired one

vercel · 2024-08-27T17:41:16Z

@madhav-relish is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-08-27T17:41:20Z

Walkthrough

The changes primarily involve enhancements to the ComposeEmailForm component by integrating ComboboxInput for improved email address selection and refining the styling of the modal component. These modifications aim to streamline user interaction and maintain a cleaner code structure, ensuring better usability and presentation across the application.

Changes

File	Change Summary
`apps/web/app/(app)/compose/ComposeEmailForm.tsx`	Updated import to include `ComboboxInput`, replaced `Combobox.Input` with `ComboboxInput`, and modified styling for improved layout and user experience.
`apps/web/components/Modal.tsx`	Restructured `DialogPanel` props by moving the className to the parent `div`, enhancing readability and maintainability.

Assessment against linked issues

Objective	Addressed	Explanation
Replace autocomplete for contacts (#179)	✅

🐰 In a world of emails, bright and neat,
A new combobox makes our task a treat.
With badges and styles, we hop with cheer,
Crafting messages, our friends draw near!
Let's celebrate this change, oh what fun,
A rabbit's delight, our work is done! ✉️✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e4912e6 and 10ac3ee.

Files selected for processing (2)

apps/web/app/(app)/compose/ComposeEmailForm.tsx (4 hunks)
apps/web/components/Modal.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

apps/web/components/Modal.tsx

Additional comments not posted (5)

apps/web/app/(app)/compose/ComposeEmailForm.tsx (5)

3-8: LGTM!

The import statements are correctly updated to include ComboboxInput.

The code changes are approved.

174-174: LGTM!

The JSX structure changes for the Combobox component are correctly implemented.

The code changes are approved.

179-179: LGTM!

The styling changes for the Badge component are correctly implemented.

The code changes are approved.

193-195: LGTM!

The introduction of the ComboboxInput component and its styling changes are correctly implemented.

The code changes are approved.

303-303: LGTM!

The class name update for the EditorContent component is correctly implemented.

The code changes are approved.

elie222 · 2024-08-29T07:42:53Z

apps/web/app/(app)/compose/ComposeEmailForm.tsx

                      key={emailAddress}
                      variant="outline"
-                      className="mr-1.5"
+                      className="h-8 rounded-md border-primary bg-primary text-white"


avoid primary and just go with the color. we don't use bg-primary anywhere in the codebase

elie222 · 2024-08-29T07:44:04Z

apps/web/components/Modal.tsx

              leave="ease-in duration-200"
              leaveFrom="opacity-100 scale-100"
              leaveTo="opacity-0 scale-95"
+              className={clsx(


modals everywhere else on the site still work fine after this change?

Yeah, the only place where layout was not looking good was the VideoDemo.tsx modal (Demo video on the landing page) which is now fixed in the latest PR #201

elie222

A few questions

Fix elie222#179

10ac3ee

- Modal is now big and fully responsive - Simplified the styling - changed the design of the "To" autocomplete to the desired one

coderabbitai bot reviewed Aug 27, 2024

View reviewed changes

elie222 reviewed Aug 29, 2024

View reviewed changes

elie222 requested changes Aug 29, 2024

View reviewed changes

elie222 merged commit 10ac3ee into elie222:main Sep 10, 2024

coderabbitai bot mentioned this pull request Feb 6, 2025

Show drafts in thread #324

Merged

coderabbitai bot mentioned this pull request Feb 15, 2025

Add dark mode #337

Merged

coderabbitai bot mentioned this pull request Feb 24, 2025

feat: Mail: reply all button #357

Closed

coderabbitai bot mentioned this pull request Apr 5, 2025

add multi-email input component and refactor compose email form #386

Closed

coderabbitai bot mentioned this pull request Dec 14, 2025

UI Migration: Modern components and styling from Mail-0/Zero #1091

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #179 - Replace autocomplete for contacts#220

Fix #179 - Replace autocomplete for contacts#220
elie222 merged 1 commit intoelie222:mainfrom
madhav-relish:main

madhav-relish commented Aug 27, 2024 •

edited

Loading

Uh oh!

vercel bot commented Aug 27, 2024

Uh oh!

coderabbitai bot commented Aug 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

elie222 Aug 29, 2024

Uh oh!

madhav-relish Aug 30, 2024

Uh oh!

elie222 Aug 29, 2024

Uh oh!

madhav-relish Aug 30, 2024 •

edited

Loading

Uh oh!

elie222 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

madhav-relish commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Aug 27, 2024

Uh oh!

coderabbitai bot commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

elie222 Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

madhav-relish Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

elie222 Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

madhav-relish Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elie222 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

madhav-relish commented Aug 27, 2024 •

edited

Loading

coderabbitai bot commented Aug 27, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

madhav-relish Aug 30, 2024 •

edited

Loading