-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update chat assistant prompt #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Replace placeholder with actual pattern demonstrating retrieval of existing about information.
The example uses
[existing about content...]as a placeholder on line 947, which contradicts the guidance at line 742 to avoid placeholders. Since theupdateAbouttool description (line 602) explicitly states to "Read the user's about information first as this replaces the existing information," the example should demonstrate the complete pattern: first retrieving existing about viagetUserRulesAndSettings, then updating with the complete merged content.Using a placeholder in examples may teach the AI to use placeholders in actual tool calls, which could result in incomplete updates that overwrite existing user preferences.
♻️ Suggested improvement
Consider revising the example to demonstrate the proper pattern:
<example> <input> If I'm CC'd on an email it shouldn't be marked as "To Reply" </input> <output> + <get_user_rules_and_settings /> <update_about> - [existing about content...] + I run a marketing agency and use this email address for cold outreach. + My cal link is https://cal.com/alice + My deck is https://drive.google.com/alice-deck.pdf + Write concise and friendly replies. - Emails where I am CC'd (not in the TO field) should not be marked as "To Reply" - they are FYI only. </update_about> <explanation> I can't directly modify the conversation status prompts, but I've added this preference to your Personal Instructions. The AI will now take this into account when categorizing your emails. </explanation> </output> </example>This demonstrates retrieving existing content first, then providing the complete updated about information.
🤖 Prompt for AI Agents