Skip to content

assistant: fix all rules disabled banner logic #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elie222 merged 1 commit into from
Jan 6, 2026
Merged

assistant: fix all rules disabled banner logic #1220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/web/app/(app)/[emailAccountId]/assistant/AllRulesDisabledBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ export function AllRulesDisabledBanner() {

if (isLoading || !rules) return null;

const allRulesDisabled =
rules.length > 0 && rules.every((rule) => !rule.enabled);
const allRulesDisabled = rules.every((rule) => !rule.enabled);
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

if (!allRulesDisabled) return null;

Comment on lines 19 to 24
Copy link
Copy Markdown
Contributor

@baz-reviewer baz-reviewer bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the rules.length > 0 guard means rules.every((rule) => !rule.enabled) now returns true when the list is empty, so the "All rules are disabled" banner renders for accounts that actually have no rules yet. That makes the copy inaccurate and will confuse users in the empty/onboarding state, whereas prior logic only showed the banner once at least one rule existed and was disabled.

Suggested change
if (isLoading || !rules) return null;
const allRulesDisabled =
rules.length > 0 && rules.every((rule) => !rule.enabled);
const allRulesDisabled = rules.every((rule) => !rule.enabled);
if (!allRulesDisabled) return null;
if (isLoading || !rules) return null;
const allRulesDisabled =
rules.length > 0 && rules.every((rule) => !rule.enabled);
if (!allRulesDisabled) return null;

Finding type: Logical Bugs

Expand Down
Loading