Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions apps/web/__tests__/ai-meeting-briefing.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ function getMeetingBriefingData(
return {
event: getCalendarEvent(),
externalGuests: [{ email: "alice@external.com", name: "Alice External" }],
internalTeamMembers: [],
emailThreads: [],
pastMeetings: [],
...overrides,
Expand Down
37 changes: 37 additions & 0 deletions apps/web/utils/meeting-briefs/gather-context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,15 @@ export interface ExternalGuest {
name?: string;
}

export interface InternalTeamMember {
email: string;
name?: string;
}

export interface MeetingBriefingData {
event: CalendarEvent;
externalGuests: ExternalGuest[];
internalTeamMembers: InternalTeamMember[];
emailThreads: EmailThread[];
pastMeetings: CalendarEvent[];
}
Expand All @@ -46,10 +52,16 @@ export async function gatherContextForEvent({
logger: Logger;
}): Promise<MeetingBriefingData> {
const externalAttendees = getExternalAttendees(event, userEmail, userDomain);
const internalAttendees = getInternalTeamMembers(
event,
userEmail,
userDomain,
);
const participantEmails = externalAttendees.map((a) => a.email);

logger.info("Gathering context for external guests", {
guestCount: externalAttendees.length,
internalTeamCount: internalAttendees.length,
});

const [emailProvider, calendarProviders] = await Promise.all([
Expand Down Expand Up @@ -91,6 +103,10 @@ export async function gatherContextForEvent({
email: a.email,
name: a.name,
})),
internalTeamMembers: internalAttendees.map((a) => ({
email: a.email,
name: a.name,
})),
emailThreads: cappedThreads,
pastMeetings,
};
Expand Down Expand Up @@ -165,6 +181,27 @@ function getExternalAttendees(
});
}

function getInternalTeamMembers(
event: CalendarEvent,
userEmail: string,
userDomain: string,
): CalendarEventAttendee[] {
const normalizedUserEmail = userEmail.trim().toLowerCase();
const normalizedUserDomain = userDomain.trim().toLowerCase();

return event.attendees.filter((attendee) => {
const normalizedAttendeeEmail = attendee.email.trim().toLowerCase();
const attendeeDomain = extractDomainFromEmail(normalizedAttendeeEmail);

// Internal team members share the same domain but are not the user themselves
return (
attendeeDomain &&
attendeeDomain === normalizedUserDomain &&
normalizedAttendeeEmail !== normalizedUserEmail
);
Comment on lines +192 to +201
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since extractDomainFromEmail can return undefined, the guard (if (!attendeeDomain) return false;) seems redundant—could we just return the boolean expression directly and flatten the function?

Suggested change
return event.attendees.filter((attendee) => {
const normalizedAttendeeEmail = attendee.email.trim().toLowerCase();
const attendeeDomain = extractDomainFromEmail(normalizedAttendeeEmail);
if (!attendeeDomain) return false;
// Internal team members share the same domain but are not the user themselves
return (
attendeeDomain === normalizedUserDomain &&
normalizedAttendeeEmail !== normalizedUserEmail
);
return event.attendees.filter((attendee) => {
const normalizedAttendeeEmail = attendee.email.trim().toLowerCase();
const attendeeDomain = extractDomainFromEmail(normalizedAttendeeEmail);
// Internal team members share the same domain but are not the user themselves
return (
attendeeDomain &&
attendeeDomain === normalizedUserDomain &&
normalizedAttendeeEmail !== normalizedUserEmail
);

Finding type: Conciseness

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied! Flattened the filter to include attendeeDomain && in the return expression rather than using a separate guard clause.

});
}

async function fetchPastMeetingsWithParticipants({
calendarProviders,
participantEmails,
Expand Down
1 change: 1 addition & 0 deletions apps/web/utils/meeting-briefs/process.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ export async function runMeetingBrief({
await sendBriefingEmail({
event,
briefingContent,
internalTeamMembers: briefingData.internalTeamMembers,
emailAccountId,
userEmail,
provider,
Expand Down
13 changes: 12 additions & 1 deletion apps/web/utils/meeting-briefs/send-briefing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import MeetingBriefingEmail, {
generateMeetingBriefingSubject,
type MeetingBriefingEmailProps,
type BriefingContent,
type InternalTeamMember,
} from "@inboxzero/resend/emails/meeting-briefing";
import type { CalendarEvent } from "@/utils/calendar/event-types";
import type { Logger } from "@/utils/logger";
Expand All @@ -15,6 +16,7 @@ import { formatTimeInUserTimezone } from "@/utils/date";
export async function sendBriefingEmail({
event,
briefingContent,
internalTeamMembers,
emailAccountId,
userEmail,
provider,
Expand All @@ -23,6 +25,7 @@ export async function sendBriefingEmail({
}: {
event: CalendarEvent;
briefingContent: BriefingContent;
internalTeamMembers: InternalTeamMember[];
emailAccountId: string;
userEmail: string;
provider: string;
Expand All @@ -35,14 +38,22 @@ export async function sendBriefingEmail({

const unsubscribeToken = await createUnsubscribeToken({ emailAccountId });

// Merge internal team members into briefing content for the email.
// The AI generates only {guests}, while internalTeamMembers comes from
// gather-context.ts (domain-based filtering, not AI-researched).
const briefingContentWithTeam: BriefingContent = {
...briefingContent,
internalTeamMembers,
};

const emailProps: MeetingBriefingEmailProps = {
baseUrl: env.NEXT_PUBLIC_BASE_URL,
emailAccountId,
meetingTitle: event.title,
formattedTime,
videoConferenceLink: event.videoConferenceLink ?? "",
eventUrl: event.eventUrl ?? "",
briefingContent,
briefingContent: briefingContentWithTeam,
unsubscribeToken,
};

Expand Down
27 changes: 27 additions & 0 deletions packages/resend/emails/meeting-briefing.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,14 @@ export type GuestBriefing = {
bullets: string[];
};

export type InternalTeamMember = {
name?: string;
email: string;
};

export type BriefingContent = {
guests: GuestBriefing[];
internalTeamMembers?: InternalTeamMember[];
};

export type MeetingBriefingEmailProps = {
Expand Down Expand Up @@ -51,6 +57,20 @@ function renderGuestBriefings(guests: GuestBriefing[]) {
));
}

function renderInternalTeamNote(internalTeamMembers: InternalTeamMember[]) {
if (internalTeamMembers.length === 0) return null;

const names = internalTeamMembers
.map((member) => member.name || member.email)
.join(", ");

return (
<Text className="text-xs text-gray-500 mt-4 mb-0 italic">
Also attending: {names} (internal team members - no briefing included)
</Text>
);
}

export default function MeetingBriefingEmail({
baseUrl = "https://www.getinboxzero.com",
emailAccountId,
Expand Down Expand Up @@ -99,6 +119,9 @@ export default function MeetingBriefingEmail({

<Section className="px-8 pb-4">
{renderGuestBriefings(briefingContent.guests)}
{renderInternalTeamNote(
briefingContent.internalTeamMembers ?? [],
)}
</Section>

<Section className="px-8 pb-6">
Expand Down Expand Up @@ -162,6 +185,10 @@ MeetingBriefingEmail.PreviewProps = {
],
},
],
internalTeamMembers: [
{ name: "Alice Chen", email: "alice@mycompany.com" },
{ name: "Bob Williams", email: "bob@mycompany.com" },
],
},
};

Expand Down
Loading