-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enable meeting briefs beta and other feature flags #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -187,6 +187,9 @@ export const env = createEnv({ | |||||
| .default(false), | ||||||
| NEXT_PUBLIC_USE_AEONIK_FONT: z.coerce.boolean().optional().default(false), | ||||||
| NEXT_PUBLIC_BYPASS_PREMIUM_CHECKS: z.coerce.boolean().optional(), | ||||||
| NEXT_PUBLIC_DIGEST_ENABLED: z.coerce.boolean().optional(), | ||||||
| NEXT_PUBLIC_MEETING_BRIEFS_ENABLED: z.coerce.boolean().optional(), | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Feature flag missing default value. Per project conventions, feature flags should use Prompt for AI agents
Suggested change
|
||||||
| NEXT_PUBLIC_INTEGRATIONS_ENABLED: z.coerce.boolean().optional(), | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Feature flag missing default value. Per project conventions, feature flags should use Prompt for AI agents
Suggested change
|
||||||
| }, | ||||||
| // For Next.js >= 13.4.4, you only need to destructure client variables: | ||||||
| experimental__runtimeEnv: { | ||||||
|
|
@@ -243,5 +246,10 @@ export const env = createEnv({ | |||||
| NEXT_PUBLIC_USE_AEONIK_FONT: process.env.NEXT_PUBLIC_USE_AEONIK_FONT, | ||||||
| NEXT_PUBLIC_BYPASS_PREMIUM_CHECKS: | ||||||
| process.env.NEXT_PUBLIC_BYPASS_PREMIUM_CHECKS, | ||||||
| NEXT_PUBLIC_DIGEST_ENABLED: process.env.NEXT_PUBLIC_DIGEST_ENABLED, | ||||||
| NEXT_PUBLIC_MEETING_BRIEFS_ENABLED: | ||||||
| process.env.NEXT_PUBLIC_MEETING_BRIEFS_ENABLED, | ||||||
| NEXT_PUBLIC_INTEGRATIONS_ENABLED: | ||||||
| process.env.NEXT_PUBLIC_INTEGRATIONS_ENABLED, | ||||||
| }, | ||||||
| }); | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v2.23.0 | ||
| v2.23.1 |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Feature flag missing default value. Per project conventions, feature flags should use
.default(false)to avoidundefinedvalues in boolean checks. Other similar flags likeNEXT_PUBLIC_CONTACTS_ENABLEDfollow this pattern.Prompt for AI agents