-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow editing writing style #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
129 changes: 129 additions & 0 deletions
129
apps/web/app/(app)/[emailAccountId]/assistant/settings/WritingStyleSetting.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| "use client"; | ||
|
|
||
| import { useForm } from "react-hook-form"; | ||
| import { useAction } from "next-safe-action/hooks"; | ||
| import { Button } from "@/components/ui/button"; | ||
| import { Input } from "@/components/Input"; | ||
| import { SettingCard } from "@/components/SettingCard"; | ||
| import { | ||
| Dialog, | ||
| DialogContent, | ||
| DialogDescription, | ||
| DialogHeader, | ||
| DialogTitle, | ||
| DialogTrigger, | ||
| } from "@/components/ui/dialog"; | ||
| import { useAccount } from "@/providers/EmailAccountProvider"; | ||
| import { toastError, toastSuccess } from "@/components/Toast"; | ||
| import { useEmailAccountFull } from "@/hooks/useEmailAccountFull"; | ||
| import { Skeleton } from "@/components/ui/skeleton"; | ||
| import { LoadingContent } from "@/components/LoadingContent"; | ||
| import { zodResolver } from "@hookform/resolvers/zod"; | ||
| import { | ||
| type SaveWritingStyleBody, | ||
| saveWritingStyleBody, | ||
| } from "@/utils/actions/user.validation"; | ||
| import { saveWritingStyleAction } from "@/utils/actions/user"; | ||
|
|
||
| export function WritingStyleSetting() { | ||
| const { data, isLoading, error } = useEmailAccountFull(); | ||
|
|
||
| const hasWritingStyle = !!data?.writingStyle; | ||
|
|
||
| return ( | ||
| <SettingCard | ||
| title="Writing style" | ||
| description="Used to draft replies in your voice." | ||
| right={ | ||
| <LoadingContent | ||
| loading={isLoading} | ||
| error={error} | ||
| loadingComponent={<Skeleton className="h-8 w-32" />} | ||
| > | ||
| <WritingStyleDialog currentWritingStyle={data?.writingStyle || ""}> | ||
| <Button variant="outline" size="sm"> | ||
| {hasWritingStyle ? "Edit" : "Set"} | ||
| </Button> | ||
| </WritingStyleDialog> | ||
| </LoadingContent> | ||
| } | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| function WritingStyleDialog({ | ||
| children, | ||
| currentWritingStyle, | ||
| }: { | ||
| children: React.ReactNode; | ||
| currentWritingStyle: string; | ||
| }) { | ||
| const { emailAccountId } = useAccount(); | ||
| const { mutate } = useEmailAccountFull(); | ||
|
|
||
| const { | ||
| register, | ||
| formState: { errors }, | ||
| handleSubmit, | ||
| } = useForm<SaveWritingStyleBody>({ | ||
| defaultValues: { writingStyle: currentWritingStyle }, | ||
| resolver: zodResolver(saveWritingStyleBody), | ||
| }); | ||
|
|
||
| const { execute, isExecuting } = useAction( | ||
| saveWritingStyleAction.bind(null, emailAccountId), | ||
| { | ||
| onSuccess: () => { | ||
| toastSuccess({ | ||
| description: "Writing style saved!", | ||
| }); | ||
| }, | ||
| onError: (error) => { | ||
| toastError({ | ||
| description: | ||
| error.error.serverError ?? | ||
| "An unknown error occurred while saving your writing style", | ||
| }); | ||
| }, | ||
| onSettled: () => { | ||
| mutate(); | ||
| }, | ||
| }, | ||
| ); | ||
|
|
||
| return ( | ||
| <Dialog> | ||
| <DialogTrigger asChild>{children}</DialogTrigger> | ||
| <DialogContent className="max-w-2xl"> | ||
| <DialogHeader> | ||
| <DialogTitle>Writing style</DialogTitle> | ||
| <DialogDescription> | ||
| Used to draft replies in your voice. | ||
| </DialogDescription> | ||
| </DialogHeader> | ||
|
|
||
| <form onSubmit={handleSubmit(execute)}> | ||
| <Input | ||
| type="text" | ||
| autosizeTextarea | ||
| rows={8} | ||
| name="writingStyle" | ||
| label="" | ||
| registerProps={register("writingStyle")} | ||
| error={errors.writingStyle} | ||
| placeholder="Typical Length: 2-3 sentences | ||
| Formality: Informal but professional | ||
| Common Greeting: Hey, | ||
| Notable Traits: | ||
| - Uses contractions frequently | ||
| - Concise and direct responses | ||
| - Minimal closings" | ||
| /> | ||
| <Button type="submit" className="mt-8" loading={isExecuting}> | ||
| Save | ||
| </Button> | ||
| </form> | ||
| </DialogContent> | ||
| </Dialog> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v2.21.49 | ||
| v2.21.50 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.