Skip to content

Fix the footer#1028

Merged
elie222 merged 1 commit intomainfrom
chore/2fa-feature
Nov 28, 2025
Merged

Fix the footer#1028
elie222 merged 1 commit intomainfrom
chore/2fa-feature

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Nov 28, 2025

Fix the footer by centralizing footerNavigation and removing z-50 from the landing footer in Footer.tsx

Export footerNavigation and update consumers; adjust the Discord icon to inherit color/size; remove z-50 from the landing footer; refactor the new-landing footer to import footerNavigation; bump version to v2.21.6.

📍Where to Start

Start with the exported footerNavigation and footer changes in Footer.tsx, then review its consumption in sections/Footer.tsx.


Macroscope summarized ad0c53a.

Summary by CodeRabbit

Release Notes

  • New Features

    • Added footer display variant support, enabling flexible layout options
  • Bug Fixes

    • Enhanced social icon accessibility in footer sections
    • Optimized footer styling for improved visual consistency
  • Chores

    • Version updated to v2.21.6

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Nov 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
inbox-zero Building Building Preview Nov 28, 2025 1:20am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR centralizes footer navigation by exporting footerNavigation from the primary Footer component and updates the secondary footer component to import and use it. Adds a variant prop for conditional UI rendering and improves social icon accessibility.

Changes

Cohort / File(s) Change Summary
Footer Navigation Centralization
apps/web/app/(landing)/home/Footer.tsx
Exported footerNavigation constant (previously non-exported navigation); replaced internal references to use the new exported entity; minor SVG adjustments for Discord icon (added fill="currentColor", simplified attributes); footer styling changed from "relative z-50" to "relative".
Footer Component Updates
apps/web/components/new-landing/sections/Footer.tsx
Replaced inline navigation with centralized footerNavigation import; added variant?: "default" | "simple" prop to FooterProps and conditioned UnicornScene rendering on variant; updated social icon rendering to include className="h-6 w-6" and aria-hidden="true" attributes.
Version Update
version.txt
Version bumped from v2.21.5 to v2.21.6.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify all navigation references throughout both Footer components are correctly updated to use footerNavigation
  • Confirm the new variant prop doesn't break existing component usage and that conditional UnicornScene rendering works as intended
  • Check that accessibility improvements (aria-hidden, className) are properly applied
  • Ensure the styling change (removal of z-50) doesn't introduce visual regressions

Possibly related PRs

  • Add alternative to #802: Modifies footer navigation in apps/web/app/(landing)/home/Footer.tsx by adding a compare section, now centralized as part of exported footerNavigation
  • 2fa feature page #1026: Alters footer navigation items in the same file; this PR now exposes that navigation for centralized use across components
  • Use cases #472: Restructures navigation data into useCases section; this PR exports and centralizes the resulting navigation structure for reuse

Poem

🐰 Navigation paths now unified and clear,
A footer's wisdom exported for all to hear,
With variants dancing, accessibility gleams,
One source of truth fulfills our dreams! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/2fa-feature

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 110490a and ad0c53a.

📒 Files selected for processing (3)
  • apps/web/app/(landing)/home/Footer.tsx (3 hunks)
  • apps/web/components/new-landing/sections/Footer.tsx (2 hunks)
  • version.txt (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@elie222 elie222 merged commit bf05054 into main Nov 28, 2025
9 of 12 checks passed
@elie222 elie222 deleted the chore/2fa-feature branch November 28, 2025 01:20
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ The following Jit checks failed to run:

  • secret-detection
  • static-code-analysis-js

#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.

More info in the Jit platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant